New issue
Advanced search Search tips

Issue 860757 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 856161
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

"PDFTestFiles/PDFExtensionLoadTest.Load/5" test failing on official.desktop.continuous on Win, Win64 and linux64 trunk builders.

Project Member Reported by pbomm...@chromium.org, Jul 6

Issue description

Link to builders :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/87836

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/36538

https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/linux64%20trunk/builds/10927


Error log :
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fofficial.desktop.continuous%2Flinux64_trunk%2F10927%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPDFTestFiles_PDFExtensionLoadTest.Load_5%2F0


Error :
PDFTestFiles/PDFExtensionLoadTest.Load/5 (run #1):
[ RUN      ] PDFTestFiles/PDFExtensionLoadTest.Load/5
Xlib:  extension "RANDR" missing on display ":9".
[28223:29820:0706/102636.483508:ERROR:object_proxy.cc(616)] Failed to call method: org.freedesktop.Notifications.GetCapabilities: object_path= /org/freedesktop/Notifications: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Notifications was not provided by any .service files
[28223:28223:0706/102636.485531:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[28223:28223:0706/102636.548266:INFO:pdf_extension_test.cc(250)] Loading: pdf_private/interactiveform_enabled.pdf
[28223:29922:0706/102636.663484:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[28223:28223:0706/102636.724594:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[28223:28223:0706/102637.048340:INFO:pdf_extension_test.cc(250)] Loading: pdf_private/xfa_pdf_unsupported.pdf
[28223:28223:0706/102637.143681:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[28223:28223:0706/102637.440213:INFO:pdf_extension_test.cc(250)] Loading: pdf_private/crash-11-14-44.pdf
[28223:28223:0706/102637.527810:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
../../chrome/browser/pdf/pdf_extension_test.cc:252: Failure
Expected equality of these values:
  PdfIsExpectedToLoad(pdf_file)
    Which is: false
  success
    Which is: true
pdf_private/crash-11-14-44.pdf
Google Test trace:
../../chrome/browser/pdf/pdf_extension_test.cc:248: pdf_private/crash-11-14-44.pdf
Stack trace:
#0 0x00000531024c (/b/c/b/linux64_trunk/src/out/Release/browser_tests+0x531024b)
[28223:28223:0706/102637.831682:INFO:pdf_extension_test.cc(250)] Loading: pdf/combobox_form.pdf
[28223:28223:0706/102637.932995:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[28223:28223:0706/102638.242550:INFO:pdf_extension_test.cc(250)] Loading: pdf/test-title.pdf
[28223:28223:0706/102638.334969:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[28223:28223:0706/102638.667502:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[28223:28223:0706/102638.667536:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] PDFTestFiles/PDFExtensionLoadTest.Load/5, where GetParam() = 5 (4784 ms)
 
Cc: tsepez@chromium.org
Components: -Internals>Plugins>PDF Internals>Skia>PDF
Labels: Target-69
This is the regression which started since build : https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/87189

Suspected pdfium roll : https://chromium.googlesource.com/chromium/src/+/b4205309833f8d7d3c3aa5749e245e68b5a90729
This browser test is also failing on "linux64, win64-clang, win-clang and win-asan" Official desktop builders.
Mergedinto: 856161
Status: Duplicate (was: Untriaged)
I see that this been already been looked into in  issue#856161 , hence marking the bug as duplicate of the other.

Please correct me if I am wrong.
Components: -Internals>Skia>PDF Internals>Plugins>PDF
Owner: thestig@chromium.org
Status: Assigned (was: Duplicate)
Not a duplicate. PDFTestFiles/PDFExtensionLoadTest.Load is a parameterized test with many test cases. In this case, the cause of the failure is not the same.

Also, the component should have been Internals>Plugins>PDF as originally set.
Cc: art-sn...@yandex-team.ru
This is due to https://pdfium-review.googlesource.com/35432 being rolled into Chromium. The test PDF in question is from  bug 57501 . One can see the effects of the CL with pdfium_test as well:

Before:
$ out/no_xfa/pdfium_test crash-11-14-44.pdf
Rendering PDF file crash-11-14-44.pdf.
Load pdf docs unsuccessful: File not in PDF format or corrupted.

After:
$ out/no_xfa/pdfium_test crash-11-14-44.pdf
Rendering PDF file crash-11-14-44.pdf.
Rendered 1 pages.
Skipped 1 bad pages.

So all we have to do is update the test expectations now.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be8ff3e12884ec3188e5fb909b31a62b9412d808

commit be8ff3e12884ec3188e5fb909b31a62b9412d808
Author: Lei Zhang <thestig@chromium.org>
Date: Thu Jul 12 19:06:18 2018

Update PDFExtensionTest test expectation.

After https://pdfium-review.googlesource.com/35432 got rolled into
Chromium in r570889, a previously failing test case now started passing.

BUG= 860757 

Change-Id: I998a0ea8a91770bb27d92491a12ac0816f535054
Reviewed-on: https://chromium-review.googlesource.com/1132633
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574660}
[modify] https://crrev.com/be8ff3e12884ec3188e5fb909b31a62b9412d808/chrome/browser/pdf/pdf_extension_test.cc

Sign in to add a comment