New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860736 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chrome:tracing Rendering does not include 'viz'

Project Member Reported by sadrul@chromium.org, Jul 6

Issue description

A bunch of the rendering related code moved into viz, and the corresponding traces changed category from cc to viz (including the vsync markers). But the 'Rendering' or 'Javascript and rendering' record-options do not include 'viz'. So the recorded traces miss a few key traces.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7439a1c6b1778f1590ccee579857148a7bd532c9

commit 7439a1c6b1778f1590ccee579857148a7bd532c9
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Fri Jul 06 18:10:07 2018

trace-recorder: Include 'viz' category for rendering.

'viz' now includes a bunch of the rendering related traces (including
the vsync markers), so include this category when recording traces for
rendering.

BUG=chromium:860736

Change-Id: I74558d10b34d1fa86ec7bbd6dfed997942faaa1c
Reviewed-on: https://chromium-review.googlesource.com/1128046
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>

[modify] https://crrev.com/7439a1c6b1778f1590ccee579857148a7bd532c9/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd78f6d851bddc1ca99abec3ec82e2a3152d99cf

commit dd78f6d851bddc1ca99abec3ec82e2a3152d99cf
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 06 19:33:35 2018

Roll src/third_party/catapult 60e91b243904..7439a1c6b177 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/60e91b243904..7439a1c6b177


git log 60e91b243904..7439a1c6b177 --date=short --no-merges --format='%ad %ae %s'
2018-07-06 sadrul@chromium.org trace-recorder: Include 'viz' category for rendering.
2018-07-06 benjhayden@chromium.org Extend Descriptor to support more test suites.


Created with:
  gclient setdep -r src/third_party/catapult@7439a1c6b177

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:860736
TBR=sullivan@chromium.org

Change-Id: Idf3f0cd4ca3cc473f93e52f89ca50a6acd6fa5c6
Reviewed-on: https://chromium-review.googlesource.com/1128104
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573043}
[modify] https://crrev.com/dd78f6d851bddc1ca99abec3ec82e2a3152d99cf/DEPS

Sign in to add a comment