New issue
Advanced search Search tips

Issue 860733 link

Starred by 2 users
Status: Fixed
Owner:
gab@chromium.org
Closed: Jul 15
Cc:
danakj@chromium.org
kylec...@chromium.org
robliao@chromium.org
gab@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

MessageLoopTest.ExpectDeathWithStubbornPostTaskOnDestroy/WithTaskScheduler is flaky

Project Member Reported by pdr@chromium.org, Jul 6 
This test is flaky:
MessageLoopTest.ExpectDeathWithStubbornPostTaskOnDestroy/WithTaskScheduler
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=MessageLoopTest.ExpectDeathWithStubbornPostTaskOnDestroy%2FWithTaskScheduler

Here's an example failure (timeout):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/8943

This test appears to have been flaky since it was added in https://crrev.com/563846.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa9ef2b1e549c225a401873e66295bb7afdd51ee

commit fa9ef2b1e549c225a401873e66295bb7afdd51ee
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Jul 12 14:40:40 2018

[MessageLoop] Fix flaky death-on-destruction test

gtest complains about the multi-threadedness of these tests not being
supported in POSIX death tests. The multi-threadedness is caused by
the WITH_TASK_SCHEDULER test variant which is unnecessary to test this.
Hence, detaching the test from the fixture and testing independently
will fix the flake I think.

R=danakj@chromium.org

Bug:  860733 
Change-Id: I0972e3c65614145825b8b40d5bb2fa9ccea9108b
Reviewed-on: https://chromium-review.googlesource.com/1134346
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574558}
[modify] https://crrev.com/fa9ef2b1e549c225a401873e66295bb7afdd51ee/base/message_loop/message_loop_unittest.cc

Comment 2 by gab@chromium.org, Jul 15

Status: Fixed (was: Assigned)
Test is now named MessageLoopDestructionTest.ExpectDeathWithStubbornPostTaskOnDestroy and should have the same behavior as the previous MessageLoopTest.ExpectDeathWithStubbornPostTaskOnDestroy/NoTaskScheduler (and thus not flake).

Thanks for reporting!
►

Sign in to add a comment