Toolbar is lost |
|||||||
Issue descriptionApp Version: 69.0.3483.0 canary iOS Version: 11.4., 12.0 Device: iPhone x, iPhone 7 URL: Steps to reproduce: 1. Launch Google Chrome 2. Tap on Tab Switcher 3. Tap on Incognito icon 4. Open New Incognito Tab (using +) 5. Change device to landscape mode 6. Scroll up 7. Open another New Incognito Tab from Menu 8. Open another New tab from Menu 9. Scroll up 10. Open another New Incognito Tab from Menu Observed results: Toolbar is lost Expected results: Toolbar should be present Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to image: https://drive.google.com/file/d/1NWEXf2EpixOG93tlv_qEftleWoeBwbQl/view Video: https://drive.google.com/file/d/1BnbV3Nf3WtbwUSTNaJ6MHcf8tl5X7RbI/view
,
Jul 9
,
Jul 9
,
Jul 10
,
Jul 10
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfe0e8552354de80dc6dc33936b90faccaa8a903 commit dfe0e8552354de80dc6dc33936b90faccaa8a903 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Jul 10 14:32:43 2018 Update TabGridToolbarButton's label This CL changes the label of the TabGridToolbarButton to use a UILabel instead of its title label. The title label isn't hidden properly when the button is hidden. Bug: 828767 , 860712 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I30f091416b50eff035716bbfd6719b26c8308085 Reviewed-on: https://chromium-review.googlesource.com/1131180 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#573716} [modify] https://crrev.com/dfe0e8552354de80dc6dc33936b90faccaa8a903/ios/chrome/browser/ui/toolbar/buttons/toolbar_button.mm [modify] https://crrev.com/dfe0e8552354de80dc6dc33936b90faccaa8a903/ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.mm
,
Jul 10
,
Jul 17
Verified in 69.0.3494.0 Canary, iPhone X iOS 11.4 Looks good. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rakurati@chromium.org
, Jul 9