New issue
Advanced search Search tips

Issue 860695 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Jul 10
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Padding issues in import bookmark dialog

Project Member Reported by namratakannan@chromium.org, Jul 6 
For the Import bookmark dialog, the "Select items to import" should be closer to the check boxes than the dropdown.

1. Can we increase padding/margin between "Select.." and dropdown by 8px?
2. Reduce the distance between checkboxes and "Select.." to 16px or change alignment of checkboxes from centered to baseline?
Current-Import-Mozilla.png
122 KB View Download
Current-import-Safari.png
85.1 KB View Download
Desired-Import-Mozilla.png
142 KB View Download
Desired-import-Safari.png
57.5 KB View Download

Comment 1 by dpa...@chromium.org, Jul 6

Cc: aee@chromium.org
Status: Available (was: Untriaged)

Comment 2 by aee@chromium.org, Jul 6

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f820fd3d5a5acb195e9dcf68b7376992e6c53d3

commit 1f820fd3d5a5acb195e9dcf68b7376992e6c53d3
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Jul 10 00:54:33 2018

Settings: update import bookmarks dialog padding

Bug:  860695 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I7753608ce7b4f9eb3cd72bf6868b7400783de98c
Reviewed-on: https://chromium-review.googlesource.com/1128216
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573569}
[modify] https://crrev.com/1f820fd3d5a5acb195e9dcf68b7376992e6c53d3/chrome/browser/resources/settings/people_page/import_data_dialog.html

Comment 4 by aee@chromium.org, Jul 10

Status: Fixed (was: Started)
►

Sign in to add a comment