New issue
Advanced search Search tips

Issue 860682 link

Starred by 2 users
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Jul 27
Cc:
mstensho@chromium.org
susan.boorgula@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Select multiple with outline breaks multi column layout

Reported by da...@bengoarocandio.com, Jul 6 
UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce the problem:
1. Load test case, or this fiddle http://jsfiddle.net/yef8tqha/
2. Hover over select "foo 3"

What is the expected behavior?
Outline is drawn and select doesn't disappear

What went wrong?
Select input disappeared

Did this work before? Yes 66.0.3359.181

Does this work in other browsers? Yes

Chrome version: 67.0.3396.99  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 30.0 r0

Tested on Windows, Mac and Ubuntu. There seems to be a lot of variables that affect this, to reproduce the select needs to have more <option>s than there is space for, so that the select has a active scrollbar (see also "foo 5" select, that  doesn't have enough options and doesn't show this problem). Works in Chromium 66, Firefox and Edge
columns-test.html
682 bytes View Download

Comment 1 by tkent@chromium.org, Jul 6

Labels: Needs-Bisect

Comment 2 by woxxom@gmail.com, Jul 6 

Interestingly the bug is observed only in Chrome, not in Chromium.

Comment 3 by e...@chromium.org, Jul 9

Owner: mstensho@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by susan.boorgula@chromium.org, Jul 9

Cc: mstensho@chromium.org susan.boorgula@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 FoundIn-68 FoundIn-69 Target-69 Target-68 OS-Mac OS-Windows Pri-1
Owner: wangxianzhu@chromium.org
david@ Thanks for the issue.

Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the latest Stable 67.0.3396.99 and latest Canary 69.0.3485.0 as per the original comment.

Bisect Information:
===================
Good Build: 67.0.3371.0
Bad Build : 67.0.3372.0

By running the per-revision bisect script, below is the Changelog URL.

https://chromium.googlesource.com/chromium/src/+log/63667eca2a1d86f5de61f29c7c5c6417cc351757..3a3c78a924a686ed0d3f90d765b00cdd78453e11

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/923572

wangxianzhu@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Adding 'ReleaseBlock-Stable' label as this is a recent regression. Please feel free to remove if this is not applicable.

Thanks

Comment 5 by gov...@chromium.org, Jul 10

Labels: -M-67 -Target-67 M-68 M-69
We're not planning any further M67 releases. Pls target fix for M68.

Comment 6 by abdulsyed@google.com, Jul 13

Labels: -ReleaseBlock-Stable -Target-68
Since this is already present in M67, removing RBS label. Let's try to get this fixed for M69.

Comment 7 by schenney@chromium.org, Jul 23

Components: -Blink>Layout Blink>Layout>MultiCol Blink>Paint

Comment 8 by chrishtr@chromium.org, Jul 23

Owner: chrishtr@chromium.org

Comment 9 by chrishtr@chromium.org, Jul 23 

Still reproducible on Linux at ToT with devtools open.

Comment 10 by chrishtr@chromium.org, Jul 23 

Also requires --enable-prefer-compositing-to-lcd-text  to reproduce.

Comment 11 by chrishtr@chromium.org, Jul 23 

Does not require DevTools or --enable-prefer-compositing-to-lcd-text.
Just requires a scrollable document. New testcase attached.
columns-test.html
545 bytes View Download

Comment 12 by chrishtr@chromium.org, Jul 24 

The bug is that a fragment clip from the first fragment is being applied to
a fragment from the second, due to confusion in PaintLayerClipper.
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2243f482808b44fa1a39f802581276003e6102c0

commit 2243f482808b44fa1a39f802581276003e6102c0
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Jul 27 06:44:44 2018

Match root layer fragment to descendant when both root and descendant are fragmented.

Otherwise, when computing a clip between an descendant and the root layer, the fragment
clip of the root layer from its local border box properties will be wrong, and clip
out the painted output.

Bug:860682

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I04653f18441becc4557ceca5a68bf513a9908283
Reviewed-on: https://chromium-review.googlesource.com/1149517
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578551}
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/fragmentation/outline-crossing-columns.html
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/linux/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/layout_ng_experimental/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/layout_ng_experimental/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/layout_ng_experimental/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/layout_ng_experimental/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac/fragmentation/outline-crossing-columns-expected.png
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/fragmentation/outline-crossing-columns-expected.txt
[add] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/WebKit/LayoutTests/platform/win/fragmentation/outline-crossing-columns-expected.png
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/layout/layout_tree_as_text.cc
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/paint/paint_layer_clipper.cc
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/paint/paint_layer_clipper.h
[modify] https://crrev.com/2243f482808b44fa1a39f802581276003e6102c0/third_party/blink/renderer/core/paint/paint_layer_clipper_test.cc

Comment 14 by chrishtr@chromium.org, Jul 27

Labels: -Target-69
Status: Fixed (was: Assigned)
Not going to merge this fix.
►

Sign in to add a comment