New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860654 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Notifications does not work anymore on Windows 10

Reported by breitb...@gmail.com, Jul 6

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.42 Safari/537.36

Steps to reproduce the problem:
1. Ask for permission to show notifications: Notification.requestPermission()
2. Show a new notification: new Notification('Test')

The attached minimal example is also hosted here: https://dombre.github.io/notifications-minimal-example/

What is the expected behavior?
A desktop notification is shown.

What went wrong?
Since Chrome 67.0.3396.99 nothing is displayed.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 67.0.3396.99  Channel: stable
OS Version: 10.0
Flash Version: Notifications are not working on Windows 10n

Tested on Windows 10, Version 1607, Build 14393.2248

The same problem exists with Chrome Beta 68.0.3440.42.

Enabling the new native notifications (chrome://flags/#enable-native-notifications) doesn't change the behavior.

Canary (with the new native notifications) does work.
 
index.html
330 bytes View Download
Components: UI>Notifications
What happens when you enter (and then leave) fullscreen mode with F11?
Nothing. The notifications aren't displayed. 

And there are also no entries in the "Info-Center" of Windows 10.
Labels: Needs-Triage-M67
Cc: viswa.karala@chromium.org
Labels: Triaged-ET M-69 FoundIn-69 Target-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version# 67.0.3396.99 and on latest chrome# 69.0.3486.0 using Windows-10, Ubuntu 14.04 and Mac 10.13.1 with the 'index.html' file provided in comment#0. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.
Note: Able to see the notification using the UR: https://dombre.github.io/notifications-minimal-example/(provide in comment#0)

Thanks!
Cc: finnur@chromium.org
Status: Unconfirmed (was: Untriaged)
@viswa - Thanks for investigating. Re #5: I don't think that's a real repro because downloading index.html & opening it will open it as a file:// url, and notifications are only expected to work from https:// urls such as the example provided.

@breitbeil - Thanks for the report. Please can you check your notification block-list for any variant of dombre.github.io at chrome://settings/content/notifications and let us know whether you also experience the issue at https://tests.peter.sh/notification-generator/

cc'ing finnur@ in case this is a Known Issue
My reading of the original post (specifically "Enabling the new native notifications doesn't change the behavior.") is that this is a problem with the underlying notification system and not the display mechanism (native/non-native).

I'm not sure how to troubleshoot that, I only know how to troubleshoot the native notifications. 

But if we do get non-native notifications to work (but not native notifications), then it would help attaching the contents of chrome://histograms/ into this bug. 

Also pressing Windows+A, select All Settings and type Notifications into the Find a setting box. Select "Notifications & actions settings" and make sure notifications are not turned off globally or per app (for Chrome/Chromium).

But I doubt it will tell us anything until we can get non-native notifications to show up (and not native ones).
Labels: Needs-Feedback
As per comment #6, adding the Needs-Feedback label.

Thanks...!!
Sorry for the late reply, I was out of office for some days.

As @finnur said, it do have the problem with non-native and native notifications.

You asked for:

1. chrome://settings/content/notifications

The domain dombre.github.io is in the allow-list.

2. https://tests.peter.sh/notification-generator/

The same problem: I don't see a notification.

3. Windows "Notifications & actions settings"

Everything is turned on (also Chrome as an application).

4. Some additional tests and notes from my side

- With Chrome Beta 68.0.3440.59 I have the same problem: non-native and native notifications do not show up.

- With Chrome Canary 69.0.3489.0 I can't reproduce the problem: non-native and native notifications _do work_.

- On Linux (Arch Linux with current Gnome) and Chrome 67.0.3396.99 everything works. So I suppose it is only a Windows problem.
 
- The previous Chrome stable version definitely worked and we do have some users of our application reporting the same problem (all reports are from Windows 10 and Chrome 67.0.3396.99 systems).

If I can provide anything else, please tell me how I can help.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 13

Cc: krajshree@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -OS-Linux -OS-Mac
Based off of the discussion, this currently appears to only be a Windows problem thus far. Dropping Linux and Mac.
Gentle Ping..

finnur@ Request you to look into the issue and help in further triaging.

Thanks...
Labels: TE-NeedsTriageHelp
Adding 'TE-NeedsTriageHelp' as per comment #12 and requesting the appropriate team to look into the issue and help in further triaging.

Thanks..
I think I can narrow the problem down a bit: It is probably "only" a problem on Windows 10, Version 1607

Until now we didn't receive an error report from Windows 10 >= Version 1709

Sadly 1607 is the LTSB/LTSC version of Windows 10 and apparently more users/companies are using it than I thought.
Can you upload the contents of chrome://histograms on a machine where this is failing?
See the attached file for the contents of chrome://histograms of a Chrome Beta 69.0.3497.42 on Windows 10 Version 1607. Notifications weren't shown.
69-notifications-failing.txt
875 KB View Download
Thank you for sharing those!

- Native notifications were used, and all the platform requirements were met.
- One notification was successfully posted; the platform-level notification setting policy was enabled.
- After posting the notification OnFailed() was invoked.

Finnur, WDYT about logging |hr| in NotificationPlatformBridgeWinImpl::OnFailed? Why would we get that to be called?
I concur with Peter's analysis here. The Windows Action Center has received the request to show the notification, but responded back to us with an |error_code|.

> Why would we get that to be called?

I don't know the inner workings of the Action Center, but my feeling is that it seems that the Action Center is designed in such a way that it accepts requests to show notifications, and doesn't check the pre-conditions for showing them at the time they are requested. It isn't until when they are about to show that it checks the pre-conditions and returns an error_code if they are not met. We stave off some of these errors by checking if notifications have been disabled, etc, but there are others cases we probably can't check for in advance.

Unfortunately, I haven't seen a list of possible error codes returned by the Action Center, but we can add this to our histogram metrics, as Peter suggested.
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd137b16a85e1235456e7a250c52771b6f8a0b5e

commit bd137b16a85e1235456e7a250c52771b6f8a0b5e
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Aug 22 21:17:29 2018

Win Native Notifications: Log HRESULTs on failed showing of notification.

Bug:  860654 ,  734095 
Change-Id: I4a705377166d9579f27206f92371c02445f2d6bf
Reviewed-on: https://chromium-review.googlesource.com/1185081
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585251}
[modify] https://crrev.com/bd137b16a85e1235456e7a250c52771b6f8a0b5e/chrome/browser/notifications/notification_platform_bridge_win.cc
[modify] https://crrev.com/bd137b16a85e1235456e7a250c52771b6f8a0b5e/tools/metrics/histograms/histograms.xml

breitbeil FYI: The change above (to log the error message from the Action Center) is live on Canary now (https://www.google.com/chrome/canary/ -- it should install version 70.0.3531.0 or later). If you have the time to install and run that on a machine that can repro the problem, I'd be happy to take another look at the chrome://histograms results from that machine.
Labels: Needs-Feedback
Unable to reproduce the issue on chrome reported version# 67.0.3396.99 using Windows 10, version 1803 from TE end.

breitbeil/Finnur Thorarinsson@ Could you please try to test this issue on latest chrome# 70.0.3532.0 and help us in verifying the fix.

Thanks!
@finnur I'm unable to reproduce the issue with a fresh install:

Uninstalling and reinstalling Chrome stable even fixed the software notifications. I had the issue on my developer machine, too and reinstalling chrome also fixed it for me. Before uninstalling I double checked the permissions from #9

So, I believe the problem is not specific to a chrome version but in the installation.

If I get another user report I will try to get access to that system. But for the moment I'm unable to provide a new histogram log.
Project Member

Comment 23 by sheriffbot@chromium.org, Aug 27

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: peter@chromium.org chengx@chromium.org
Good feedback. This makes me suspect that your old Chrome shortcut did not have the right registration data for the Action Center. That gets fixed on re-install, I believe.

Knowing that we don't reinstall shortcuts on upgrade, I started to wonder if the code to *configure* the shortcut runs if we upgrade Chrome to the version that started supporting native notifications... I think the answer to that is yes, right Xi? I mean, it must -- otherwise we'd get a ton of these failures, and we're not (to my knowledge).

The other alternative is that we're probably looking at an error during upgrade of the shortcut.

(#sigh# I wish the Windows Action Center didn't depend on the app shortcut...) 

Anyway, if you repro this on another machine, please upload the Chrome shortcut to this bug before re-installing. You should be able to right-click it in the Start menu and select Open File Location.

Hmm, I wonder if there's an installer log somewhere on your machine. Xi, do you know if we log installs automatically?
Re Finnur: "if the code to *configure* the shortcut runs if we upgrade Chrome to the version that started supporting native notifications?" -- Yes, it must. 

If the shortcut is missing or if it's not properly configured (i.e., CLSID), Chrome will automatically use non-native notification. Apparently the native notification is still used in this case, which makes me a little confused.

As mentioned in comment 14, "...until now we didn't receive an error report from Windows 10 >= Version 1709...". This is likely to be shortcut related, as Chrome will create a new shortcut to replace the old one. Earlier, we had another Googler (suppyps@) who had his native notification suddenly fixed after an OS update.

For the installer log, I am not sure. We will have to ask installer owners. 

Following the last comment:

Here are more details:
1. Chrome auto-update will only update the shortcut (CLSID etc) when it exists. So (a) if the shortcut exist, Chrome will update the shortcut with the latest configuration so that it can use native notification. (b) If it doesn't exist, Chrome will do nothing on the shortcut so non-native notification will be used.

2. For OS upgrade, Chrome will create a new shortcut (with the latest configuration) no matter what. That is why the native notification started to work right after an OS upgrade according to some user reports.

3. For Chrome re-install (including over-install), it is the same as (2). 

Finnur, shortcut operation is logged here: https://cs.chromium.org/chromium/src/chrome/installer/setup/install.cc?sq=package:chromium&q=LogShortcutOperation&g=0&l=56
#24 - 26 -
Did I understand correctly? Is the ability to use native notifications tied to the shortcut you use to launch Chrome?
(Please, tell me it is not so...)
Unfortunately, the Start Menu shortcut is a hard requirement imposed by Windows for native notifications. 

Unlike the Desktop shortcut, the Start Menu one is almost invisible to the user though.

We have more discussion on this in crbug/872834 if you are interested.
#28 - I see, it is not about a shortcut from which you launched an application, but about a start menu shortcut being simply present. While stupid of them, I imagine not a lot of people use the start menu, so it is not a big deal (beside the issues investigated in  issue 872834 , of course).

Off topic, but still - I find the native notifications highly annoying - I do not understand why there is no close button on the notification itself when it popups up. I must go to the action center in order to dismiss a notification if I do not want to activate it (think GMail notifications where I do want to know about new e-mails, but I do not want to click on every single notification and see a popup window with the message, I will get to them later, knowing I have something to get to). What makes this worse is that going to the action center dismisses all of my notifications! I guess I was very used to the non-native way of doing things... The native way is very uncomfortable.
Sorry for babbling.
#29 - you can switch back to the non-native one via chrome://flags/#enable-native-notifications.
#30 - and revert back to a deprecated feature until you stop supporting it (which is bound to happen)? Not a very good advice...
Let's try to stick to the topic...

#26: Thanks, Xi, that's good to know. So, I can only think of two possibilities then: we're getting an error while upgrading the shortcut (as I mentioned before) or maybe the clsid used by the installer is from a wrong branch of Chrome, or something? Unlikely, but just thought I'd throw it out there.

I guess we won't know more until we see one of those failing shortcuts...
Cc: -finnur@chromium.org
Status: WontFix (was: Unconfirmed)
We can re-open it if the issue comes back. 

Sign in to add a comment