Issue metadata
Sign in to add a comment
|
History items gets override on performing history search |
||||||||||||||||||||||
Issue descriptionApp Version: 69.0.3482.0 Canary iOS Version: 10.3.3, 11.4 Device: iPhone and iPad Steps to reproduce: 1. Fresh install chrome and Launch chrome 2. Browse through few sites 3. Open History and search for the website which is already browsed in history search 4. Once the search results are displayed tap on cancel button Observed results: Notice that top history items are overridden by search result items Expected results: History items shouldn’t override Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M67 (UI Refresh is available from M69) Bug reproducible on the current beta channel build (App Version, iOS Version): No on M68 (UI Refresh is available from M69) Link to video: https://drive.google.com/file/d/1m3xdqhQGkdeHB0ctw2VXGvxT9LCzyqWB/view?usp=sharing
,
Jul 10
Note that if you cancel out of History with Done and then bring up History again, the correct history is shown. It appears that the effect of "top history items are overridden by search result items" is the display and didn't really change the history data.
,
Jul 17
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/833ca80aa1c474feb9a432f020800560c6a6eaa3 commit 833ca80aa1c474feb9a432f020800560c6a6eaa3 Author: sczs <sczs@chromium.org> Date: Thu Jul 26 00:55:38 2018 [ios] Use reloadData on HistoryTableView inserts. After crbug.com/836562 was fixed it introduced crbug.com/860649 . In order to solve this we need to keep track of which indexPaths are being inserted and if 2 items are inserted in the same indexPath we need to manually shift the previous indexPath row, if not we will end up with 2 insertions in the same indexPath and get a consistency crash. Because of this and the fact that we want to get rid of the initial insertion and search animations ( crbug.com/859736 ) I decided to get rid of the historyInserter updates and just reloadData. We will still update individual rows for the status message and deletion when editing. Bug: 860649 , 859736 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8c7488110441727be767ead22903700927f69d1 Reviewed-on: https://chromium-review.googlesource.com/1141127 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#578152} [modify] https://crrev.com/833ca80aa1c474feb9a432f020800560c6a6eaa3/ios/chrome/browser/ui/history/history_table_view_controller.mm
,
Jul 26
,
Jul 26
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d98efc287b848f75f0475c0e16be5068de4c31af commit d98efc287b848f75f0475c0e16be5068de4c31af Author: sczs <sczs@chromium.org> Date: Mon Jul 30 18:22:46 2018 [ios] Use reloadData on HistoryTableView inserts. After crbug.com/836562 was fixed it introduced crbug.com/860649 . In order to solve this we need to keep track of which indexPaths are being inserted and if 2 items are inserted in the same indexPath we need to manually shift the previous indexPath row, if not we will end up with 2 insertions in the same indexPath and get a consistency crash. Because of this and the fact that we want to get rid of the initial insertion and search animations ( crbug.com/859736 ) I decided to get rid of the historyInserter updates and just reloadData. We will still update individual rows for the status message and deletion when editing. TBR=sczs@chromium.org (cherry picked from commit 833ca80aa1c474feb9a432f020800560c6a6eaa3) Bug: 860649 , 859736 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8c7488110441727be767ead22903700927f69d1 Reviewed-on: https://chromium-review.googlesource.com/1141127 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578152} Reviewed-on: https://chromium-review.googlesource.com/1155370 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#220} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/d98efc287b848f75f0475c0e16be5068de4c31af/ios/chrome/browser/ui/history/history_table_view_controller.mm
,
Jul 31
Verified in: App Version: 70.0.3508.0 Canary Devices: iPhone 7 Plus, iPhone 6 Plus, iPad Pro, iPad Air iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5 Issue is fixed. History items are overridden by search result items. Video: https://drive.google.com/open?id=1EadFRbJP3B-Dow76gYJ_K-pkz6C9eSTm
,
Jul 31
Please add merge request label if this needs to be merged to M69.
,
Jul 31
This was solved by https://chromium-review.googlesource.com/1141127. Which was approved for merge here:https://bugs.chromium.org/p/chromium/issues/detail?id=859736 The same CL was going to fix both issues, so the fix for this has been merged to M69 already.
,
Jul 31
Removing merge TBD label per c#10. Thank sczs.
,
Aug 1
Verified on following the steps mentioned in comment #0. History items are not overridden. App version: 69.0.3497.22 beta Devices: iPhone 8 plus, iPad Pro iOS : 11.4.1, 12 beta 5 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by olivierrobin@chromium.org
, Jul 6Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)