BookmarkData has been deprecated in 2010 and bookmark EntitySpecifics have been used instead. Chrome Sync is supported back to M28 which went to stable in June 2013. It should be safe to remove the deprecated field.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee commit 4a0cf6516ff4f2a8249f479979b8f284c1eab1ee Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Jul 16 11:04:26 2018 [Sync] Deprecate BookmarkData in SyncEntity and remove related code Bug: 860643 Change-Id: Ic472b0d4a182cb70fce2a035197897cdb9e609c2 Reviewed-on: https://chromium-review.googlesource.com/1127791 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575221} [add] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/chrome/test/data/vr/webvr_info [add] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/chrome/test/data/vr/webxr_samples [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/engine_impl/commit_util.cc [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/engine_impl/syncer_unittest.cc [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/engine_impl/syncer_util.cc [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/protocol/sync.proto [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/syncable/model_type.cc [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/syncable/syncable_proto_util.cc [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/test/engine/mock_connection_manager.cc [modify] https://crrev.com/4a0cf6516ff4f2a8249f479979b8f284c1eab1ee/components/sync/test/engine/mock_connection_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da0888bbe572b42c9baf96f63fd78aa872b5a832 commit da0888bbe572b42c9baf96f63fd78aa872b5a832 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Jul 18 08:49:59 2018 Revert "[Sync] Deprecate BookmarkData in SyncEntity and remove related code" This reverts commit 4a0cf6516ff4f2a8249f479979b8f284c1eab1ee. Reason for revert: this CL accidentally readded chrome/test/data/vr/* which was moved in https://chromium.googlesource.com/chromium/src/+/a9ced4c437fa8451fd9d2ca7e2c125242e0494d4 Original change's description: > [Sync] Deprecate BookmarkData in SyncEntity and remove related code > > Bug: 860643 > Change-Id: Ic472b0d4a182cb70fce2a035197897cdb9e609c2 > Reviewed-on: https://chromium-review.googlesource.com/1127791 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575221} TBR=mastiz@chromium.org,mamir@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 860643 Change-Id: Iba22f9fd1319bf1f3076332858562a3e92070a5b Reviewed-on: https://chromium-review.googlesource.com/1141624 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#575980} [delete] https://crrev.com/9159e523ff939514ed3ece9579251432b9bda19c/chrome/test/data/vr/webvr_info [delete] https://crrev.com/9159e523ff939514ed3ece9579251432b9bda19c/chrome/test/data/vr/webxr_samples [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/engine_impl/commit_util.cc [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/engine_impl/syncer_unittest.cc [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/engine_impl/syncer_util.cc [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/protocol/sync.proto [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/syncable/model_type.cc [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/syncable/syncable_proto_util.cc [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/test/engine/mock_connection_manager.cc [modify] https://crrev.com/da0888bbe572b42c9baf96f63fd78aa872b5a832/components/sync/test/engine/mock_connection_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe271294e83d3aa93219baf7fe66e81304489a1c commit fe271294e83d3aa93219baf7fe66e81304489a1c Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Jul 18 11:30:10 2018 Reland "[Sync] Deprecate BookmarkData in SyncEntity and remove related code" This is a reland of 4a0cf6516ff4f2a8249f479979b8f284c1eab1ee Original change's description: > [Sync] Deprecate BookmarkData in SyncEntity and remove related code > > Bug: 860643 > Change-Id: Ic472b0d4a182cb70fce2a035197897cdb9e609c2 > Reviewed-on: https://chromium-review.googlesource.com/1127791 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575221} Bug: 860643 Change-Id: I61fc398f00e53f7b4c51f85e82da897cd5f91d9d Reviewed-on: https://chromium-review.googlesource.com/1141626 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#576005} [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/engine_impl/commit_util.cc [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/engine_impl/syncer_unittest.cc [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/engine_impl/syncer_util.cc [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/protocol/sync.proto [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/syncable/model_type.cc [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/syncable/syncable_proto_util.cc [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/test/engine/mock_connection_manager.cc [modify] https://crrev.com/fe271294e83d3aa93219baf7fe66e81304489a1c/components/sync/test/engine/mock_connection_manager.h
Comment 1 by mamir@chromium.org
, Jul 6