Issue metadata
Sign in to add a comment
|
Regression: Browser gets unresponsive and delay is observed after dragging a sample thumbnail in omnibox
Reported by
shruti.j...@etouch.net,
Jul 6
|
||||||||||||||||||||||
Issue descriptionChrome Version :69.0.3483.0 (Official Build) (cohort: Stable)Revision 68bf9707c1026959630e89e90235cfcf0440c08c-refs/branch-heads/3483@{#1}(64-bit) OS: Windows(7,8,8.1,10) Steps to reproduce: 1.Launch chrome and navigate to chrome://thumbnails. 2.Drag the thumbnail present on chrome://thumbnails to NTP. 2.Observe browser. Actual Result: Browser gets unresponsive and delay is observed in loading of thumbnail. Expected Result: Browser should not get unresponsive and no delay should be seen while loading the thumbnail. This is a regression issue, broken in 'M-69', and will soon provide bisect-info: Good Build:69.0.3480.0 (Revision: 572082) Bad Build: 69.0.3481.0 (Revision: 572437)
,
Jul 6
My CL only affects ash_shell_with_content. Nothing in that range is too suspicious. Is the bisect accurate? Assigning to ccameron for crrev.com/c/1123456 CC'ing wangxianzhu@ for crrev.com/c/1125300
,
Jul 7
This is indeed my patch -- we end up creating a cache entry for every character of a ~2k string. Each cache entry has the full 2k string included. And, when looking up cache entries, we re-hash every entry every time. Handful of fixes that will improve this - store the result of hb_buffer_add_utf16 instead of the full buffer - pre-compute the hash (and only hash the substr that is relevant) - diff the hb_buffer_ts
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2228dce400e0743b6dd1f59205e03e0e2aaee145 commit 2228dce400e0743b6dd1f59205e03e0e2aaee145 Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Jul 11 06:50:34 2018 RenderTextHarfBuzz: Improve cache performance Avoid checking the full input |text| string, rather, only examine the part that sits inside |range| and its adjacent context. Note that we still need the full string (or at least we need to know the offset into it that we are using), because that will affect the output. Pre-compute the input hash, to avoid re-computing a string's hash at every comparison. Add comments regarding key hash computation and thread use, and mark members as const (requested in previous patch's review). Bug: 860612 Change-Id: I9dd73e0a2d0247a7139131edfb33b3d99138b103 Reviewed-on: https://chromium-review.googlesource.com/1130159 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#574092} [modify] https://crrev.com/2228dce400e0743b6dd1f59205e03e0e2aaee145/ui/gfx/render_text_harfbuzz.cc
,
Jul 11
This should be fixed now (can't verify on Windows myself due to lack of a machine).
,
Jul 12
Update: Rechecked the above issue on Windows(7,8,8.1,10) using latest canary build #69.0.3489.0 and issue is fix.Browser does not get unresponsive after dragging sample thumbnails. Please refer attached screencast for reference. Thank You...
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/791f1c19acbf159aab8fb9652e95b77222075239 commit 791f1c19acbf159aab8fb9652e95b77222075239 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Jul 13 03:58:48 2018 MacViews: Only use context for text shape when using RTL languages The call to hb_buffer_add_utf16 will read up to 5 characters adjacent to the specified range. This context is only used in the function arabic_joining. We can get much better caching if we don't include this context in our keys. Arabic is an RTL language, so we can omit this context in the key for all non-RTL languages. Bug: 860612 , 862773 Change-Id: Icc11059886ab835032141ad25b966d358f7177b3 Reviewed-on: https://chromium-review.googlesource.com/1135723 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Sidney San MartÃn <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#574834} [modify] https://crrev.com/791f1c19acbf159aab8fb9652e95b77222075239/ui/gfx/render_text_harfbuzz.cc
,
Jul 16
Update : Rechecked the above issue on Windows(7,8,8.1,10)OS with latest Canary Chrome version : 69.0.3493.0 and the issue is Fixed.Kindly refer the attached screen cast for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shruti.j...@etouch.net
, Jul 6Owner: msw@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Browser gets unresponsive and delay is observed after dragging a sample thumbnail in omnibox (was: Regression: Browser gets unresponsive and delay is observed in loading of thumbnail.)
430 KB
430 KB View Download