New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860601 link

Starred by 3 users
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Jul 8
Cc:
█ manoranj...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Context menu is seen misplaced from the original position of mouse click on www.flipkart.com

Reported by avsha...@etouch.net, Jul 6 
Chrome Version : 69.0.3482.0 (Official Build) f55a011c2fd928ccc84df796152c2046a33c8e32-refs/branch-heads/3482@{#1} 32/64 bit
OS : Windows (7, 8, 8.1, 10), Linux (14.04 LTS), Mac(10.12.6, 10.13.1, 10.14, 10.13.6)

Test URL : https://www.flipkart.com/

What steps will reproduce the problem?
1. Launch chrome and navigate to above test URL.
2. Scroll down the page to "Featured Brands" section and right click on any brand item.
3. Observe the context menu.

Actual Result : Context menu is seen misplaced from the original position of mouse click.

Expected Result : Context menu should open on the position where mouse is clicked.

This is a regression issue broken in ‘M-69’ and below is the bisect info :
Good Build : 69.0.3480.0 (Revision : 572082)
Bad Build : 69.0.3481.0 (Revision : 572437)

You are probably looking for a change made after 572326 (known good), but no later than 572327 (first known bad).

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/062c11cf7864134a54c9b852b8795910758ae052..1a827feb3ee5620587c6769a0a420d7426c64ea8

Suspect : https://chromium.googlesource.com/chromium/src/+/1a827feb3ee5620587c6769a0a420d7426c64ea8

Chris@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note :
1. This issue is also observed on other shopping websites like - https://www.snapdeal.com/ and https://www.aliexpress.com/

Thank You..!
Actual_Result.mp4
2.8 MB View Download
Expected_Result.mp4
1.9 MB View Download

Comment 1 by rbasuvula@chromium.org, Jul 6

Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Beta
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0081cd6f7da59813bb627dc8cbfd96a4700c11b

commit b0081cd6f7da59813bb627dc8cbfd96a4700c11b
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Sun Jul 08 05:12:53 2018

[Hit Testing] Fix PointInInnerNodeFrame for LayoutImage hit tests.

An earlier patch incorrectly changed the constructor of a temp
HitTestResult with a location_in_container which was relative to the
containing transform, rather than to the frame.

Note: this error is in part a result of the confusing nature
of HitTestResult in that it contains some parts of the request,
for no good reason. Future refactoring is needed to resolve that.

Bug:  860601 

Change-Id: I9e69dbc70a901cec4cc9a4231c705fa6f2e8ec1d
Reviewed-on: https://chromium-review.googlesource.com/1128512
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573180}
[modify] https://crrev.com/b0081cd6f7da59813bb627dc8cbfd96a4700c11b/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/b0081cd6f7da59813bb627dc8cbfd96a4700c11b/third_party/blink/renderer/core/layout/layout_image.cc
[add] https://crrev.com/b0081cd6f7da59813bb627dc8cbfd96a4700c11b/third_party/blink/renderer/core/layout/layout_image_test.cc

Comment 3 by chrishtr@chromium.org, Jul 8

Status: Fixed (was: Assigned)

Comment 4 Deleted

►

Sign in to add a comment