New issue
Advanced search Search tips

Issue 860594 link

Starred by 5 users

Issue metadata

Status: Duplicate
Merged: issue 869343
Owner: ----
Closed: Jul 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Opinion: profile chooser menu is getting too tall

Project Member Reported by tapted@chromium.org, Jul 6

Issue description

Chrome Version       : 69.0.3482.0
OS Version: OS X 10.13.5

3 extra rows were added for me in r569231, taking my profile chooser to ~678 pixels.

The 11" macbook airs still being released through 2015 only have a vertical resolution of 768 pixels. Subtract the top menubar, a bottom-aligned macOS Dock, and the potential for a browser not to be at the very top of the screen, and the likelihood of the profile switcher menu being cut off is quite high.

Regular toolkit-views menus will adjust to fit in the screen, and scroll.
 
Screen Shot 2018-07-06 at 14.07.24.png
109 KB View Download
in fact.. with the MD-Refresh UI that puts the switcher into the toolbar, there is almost exactly 100 pixels between the top of my screen and the highest point I can show the menu.

So 6 profiles will guarantee that the menu gets cut off on a screen with 768 vertical resolution. Even when the browser window is up as high as it will go.
Screen Shot 2018-07-06 at 14.20.54.png
29.5 KB View Download
Another problem is that the profile items aren't different from other actions and there are too many actions. I have just two persons and every time I open the switcher I have to find my other person in the similarly looking list of items which I never use so it's just an annoying visual noise. The old switcher had less actions so it was pretty obvious.
Two independent news on that:
- I'm gonna add even more padding in (https://chromium-review.googlesource.com/c/chromium/src/+/1126110) Yeah! :)
- We should remove the current profile from the list (see  Issue 854638 ). Hopefully, it benefits Comment #2.
tapted@, if you sign in, the menu will become shorter ;-)
Labels: Needs-Triage-M69
Labels: OS-Linux
#c4: I.. get signed out all the time for some reason :/. Every time I Quit chrome. I think the keychain on my mac is corrupt or something - I can't even reset it.

In other news, I think this is particularly bad on Desktop-Linux as well. Since we are not using a top-level window there, the profile switcher is clipped to the height of the window.
Screenshot from 2018-07-19 13-36-01.png
274 KB View Download
Could you open a bug for msarda@ and CC me about the Keychain?

On the topic: Max, should it be scrollable?
Ideally, menus should overlap the window as they do on Windows, macOS and Chrome OS. Could we do the same on Linux?
Tiny Window.png
163 KB View Download
re: first screenshot, that's a whole lot of profiles. Seems like a rare case to have that many but perhaps there should be an overflow solution instead of showing an arbitrarily large number of them at the top level? Luckily, "manage people" already provides the overflow solution so we'd just need to update the UI to make that connection apparent. (Probably not worth the effort of implementing a submenu.)
Why Passwords, Payments, and Addresses were added? Was it based on usage histograms? Because in ~10 years I opened these settings just a few times. 

Another weird thing: these items look just like the user names, and it's not immediately clear these items are in a group - the divider has almost the same height as the overall excessive MD spacing around items.

Also, maybe you can show these three items as icons in one row?
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Target-70 M-70 FoundIn-70 OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chromium version 69.0.3482.0 also on latest chrome 70.0.3506.0 using Mac 10.13.5, Ubuntu 17.10 and Windows 10.  

Same behaviour is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged.

Thanks! 
Mergedinto: 869343
Status: Duplicate (was: Untriaged)
Thanks for reporting! This is indeed not ideal on small screens and M69. We're going to make this view scrollable.

Sign in to add a comment