Chrome Version: 69 OS: Chrome OS The minimum width of hosted app windows is different between LTR and RTL UI modes. In RTL it is too big. See screenshots.
WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1127212
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d2c822c6ebbb9cd52097025b54b48ac4efabe15 commit 3d2c822c6ebbb9cd52097025b54b48ac4efabe15 Author: Alan Cutter <alancutter@chromium.org> Date: Wed Jul 18 03:16:51 2018 Fix hosted app window minimum widths in RTL UI mode This CL moves RTL mirroring logic out of FrameHeader::GetTitleBounds() and closer to where it's necessary. This fixes uses of GetTitleBounds() that shouldn't use mirrored coordinates. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347205&signed_aid=BHR4RQzcQgoqMRZiktSbrA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347206&signed_aid=_yNGcCCrQWXCWUB5bjJwSQ==&inline=1 Bug: 860590 Change-Id: Ie58194b4cf5e397967bf376d368146f180e7220e Reviewed-on: https://chromium-review.googlesource.com/1127212 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#575922} [modify] https://crrev.com/3d2c822c6ebbb9cd52097025b54b48ac4efabe15/ash/frame/default_frame_header_unittest.cc [modify] https://crrev.com/3d2c822c6ebbb9cd52097025b54b48ac4efabe15/ash/frame/frame_header.cc [modify] https://crrev.com/3d2c822c6ebbb9cd52097025b54b48ac4efabe15/base/i18n/rtl.cc [modify] https://crrev.com/3d2c822c6ebbb9cd52097025b54b48ac4efabe15/base/i18n/rtl.h [modify] https://crrev.com/3d2c822c6ebbb9cd52097025b54b48ac4efabe15/base/i18n/rtl_unittest.cc
Comment 1 by alancutter@chromium.org
, Jul 636.1 KB
36.1 KB View Download