New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860586 link

Starred by 3 users
Status: Fixed
Owner:
█ nednguyen@chromium.org
Last visit > 30 days ago
Closed: Jul 17
Cc:
eyaich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

All perf dashboard upload failed on Windows builders due to add_reserved_diagnostics error

Project Member Reported by nednguyen@chromium.org, Jul 6 
From https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_Perf%2F2710%2F%2B%2Frecipes%2Fsteps%2Fperformance_test_suite_on__102b__GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Flogs%2FMerge_script_log%2F0

Sample stack trace:
Traceback (most recent call last):
  File "E:\b\c\b\Win_7_Perf\src\third_party\catapult\tracing\bin\add_reserved_diagnostics", line 84, in <module>
    sys.exit(main())
  File "E:\b\c\b\Win_7_Perf\src\third_party\catapult\tracing\bin\add_reserved_diagnostics", line 78, in main
    with open(path, 'w') as f:
IOError: [Errno 13] Permission denied: 'c:\\users\\chrome~2\\appdata\\local\\temp\\tmptsb00m\\0\\dummy_benchmark.noisy_benchmark_1\\perf_results.json'
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e38f123f2d5fac5c5c5cfe9ce02ecbf938760b3a

commit e38f123f2d5fac5c5c5cfe9ce02ecbf938760b3a
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jul 06 04:19:40 2018

Try to set writeable permission for histogram file

TBR=eyaich@chromium.org
NOTRY=true

Bug:  860586 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9ba453fc31264cdb53f0ad81f92ec024b56a83c6
Reviewed-on: https://chromium-review.googlesource.com/1127486
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#572892}
[modify] https://crrev.com/e38f123f2d5fac5c5c5cfe9ce02ecbf938760b3a/tools/perf/core/results_dashboard.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a532d24cd9700d7c19f54c9b6b2545034bcbb411

commit a532d24cd9700d7c19f54c9b6b2545034bcbb411
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jul 06 14:40:26 2018

Write result of add_diagnostic to a tempfile instead of cloberring existing histogram file


TBR=eyaich@chromium.org
NOTRY=true

Bug:  860586 
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: If112935b78096b59b5301d2eaaea69e3beff32c1
Reviewed-on: https://chromium-review.googlesource.com/1127846
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#572968}
[modify] https://crrev.com/a532d24cd9700d7c19f54c9b6b2545034bcbb411/tools/perf/core/results_dashboard.py

Comment 3 by nednguyen@chromium.org, Jul 17

Status: Fixed (was: Started)
►

Sign in to add a comment