New issue
Advanced search Search tips

Issue 860559 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

H264VideoEncodeAndValidate hardcodes pixel format when encoding

Reported by seadu...@amazon.com, Jul 5

Issue description

Steps to reproduce the problem:
run_media_unittests -f '*H264VideoEncodeAndValidate*' with a device that doesn't support COLOR_FORMAT_YUV420_SEMIPLANAR

What is the expected behavior?
Test should pass

What went wrong?
Test fails

Did this work before? No 

Chrome version: master  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 30.0 r0

I have a patch for this issue, just creating crbug to track
 
Components: Internals>Media
CL: https://chromium-review.googlesource.com/c/chromium/src/+/1127469

It is just a bug fix to a test, so hopefully can go through pretty quick.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bd5cafd46685177663ed991f974e7edc072df73

commit 0bd5cafd46685177663ed991f974e7edc072df73
Author: Sean DuBois <seaduboi@amazon.com>
Date: Mon Jul 09 17:57:04 2018

Android: Query encoder for supported pixel formats

Test H264VideoEncodeAndValidate would fail on devices that don't
support COLOR_FORMAT_YUV420_SEMIPLANAR. This make it so the test
queries the encoder, and then take the color format from the
returned set.

R=braveyao@chromium.org

Bug:  860559 
Change-Id: I524a7e803e9781960a99308834bac4d361e0c442
Reviewed-on: https://chromium-review.googlesource.com/1127469
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573361}
[modify] https://crrev.com/0bd5cafd46685177663ed991f974e7edc072df73/media/base/android/media_codec_bridge_impl_unittest.cc

Status: Fixed (was: Unconfirmed)
Hi Sean, the cl is reverted due to  issue862251 , which should be on a Nexus 5 with Kitkat. Please take a look if you still need this change.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d6e4b23897a1e7a5ff37838744e8bfe39ff2952

commit 3d6e4b23897a1e7a5ff37838744e8bfe39ff2952
Author: Joshua Pawlicki <waffles@chromium.org>
Date: Tue Jul 10 19:00:04 2018

Revert "Android: Query encoder for supported pixel formats"

This reverts commit 0bd5cafd46685177663ed991f974e7edc072df73.

Reason for revert: Speculative revert: we observe flakiness in the test after the change landed along the lines of:

../../media/base/android/media_codec_bridge_impl_unittest.cc:455: Failure
Value of: media_codec
Expected: isn't NULL
  Actual: 4-byte object <00-00 00-00>

Original change's description:
> Android: Query encoder for supported pixel formats
> 
> Test H264VideoEncodeAndValidate would fail on devices that don't
> support COLOR_FORMAT_YUV420_SEMIPLANAR. This make it so the test
> queries the encoder, and then take the color format from the
> returned set.
> 
> R=​braveyao@chromium.org
> 
> Bug:  860559 
> Change-Id: I524a7e803e9781960a99308834bac4d361e0c442
> Reviewed-on: https://chromium-review.googlesource.com/1127469
> Reviewed-by: Weiyong Yao <braveyao@chromium.org>
> Reviewed-by: John Rummell <jrummell@chromium.org>
> Commit-Queue: Weiyong Yao <braveyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573361}

TBR=jrummell@chromium.org,braveyao@chromium.org,seaduboi@amazon.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  860559 
Change-Id: I160c1f0caa5088d7691da8445f0c8a11bb3faf0c
Reviewed-on: https://chromium-review.googlesource.com/1132054
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573839}
[modify] https://crrev.com/3d6e4b23897a1e7a5ff37838744e8bfe39ff2952/media/base/android/media_codec_bridge_impl_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3827aaa589084c040456086e571fc92276b28381

commit 3827aaa589084c040456086e571fc92276b28381
Author: Sean DuBois <seaduboi@amazon.com>
Date: Thu Jul 12 21:34:06 2018

Reland "Android: Query encoder for supported pixel formats"

This is a reland of 0bd5cafd46685177663ed991f974e7edc072df73
The original implementation would incorrectly try to use other
pixel formats besides COLOR_FORMAT_YUV420_SEMIPLANAR and
COLOR_FORMAT_YUV420_PLANAR

Original change's description:
> Test H264VideoEncodeAndValidate would fail on devices that don't
> support COLOR_FORMAT_YUV420_SEMIPLANAR. This make it so the test
> queries the encoder, and then take the color format from the
> returned set.
>
> R=braveyao@chromium.org
>
> Bug:  860559 
> Change-Id: I524a7e803e9781960a99308834bac4d361e0c442
> Reviewed-on: https://chromium-review.googlesource.com/1127469
> Reviewed-by: Weiyong Yao <braveyao@chromium.org>
> Reviewed-by: John Rummell <jrummell@chromium.org>
> Commit-Queue: Weiyong Yao <braveyao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#573361}

R=braveyao@chromium.org

Bug:  860559 
Change-Id: If2926cb692910fcd8672ddefcf0c4e45e5998e10
Reviewed-on: https://chromium-review.googlesource.com/1132342
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574730}
[modify] https://crrev.com/3827aaa589084c040456086e571fc92276b28381/media/base/android/media_codec_bridge_impl_unittest.cc

Sign in to add a comment