New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860545 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Scheduler: Experiment with using resource fetch priorites.

Project Member Reported by farahcharab@chromium.org, Jul 5

Issue description

Experiment with using resource fetch priorities when posting resource loading tasks from content::WebUrlLoaderImpl to Blink's scheduler.
 

Comment 1 Deleted

Components: -Blink
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4b35d746e8582e457a14e3ca305dbf05d8f0fec

commit a4b35d746e8582e457a14e3ca305dbf05d8f0fec
Author: Farah Charab <farahcharab@google.com>
Date: Tue Jul 17 22:45:57 2018

Scheduler: Infrastructure to support using resource fetch priorities.

Provide support for experimenting with using resource fetch priorities
for resource loading tasks in blink.

Bug: 860545
Change-Id: I064f287ea2c96d67f532ba7dc03abb45875947c3
Reviewed-on: https://chromium-review.googlesource.com/1128857
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575821}
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/public/platform/scheduler/DEPS
[add] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/public/platform/scheduler/web_resource_loading_task_runner_handle.h
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/public/platform/task_type.h
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/child/features.h
[add] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/common/unprioritized_resource_loading_task_runner_handle.cc
[add] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/common/unprioritized_resource_loading_task_runner_handle.h
[add] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/common/web_resource_loading_task_runner_handle.cc
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[add] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/resource_loading_task_runner_handle_impl.cc
[add] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/main_thread/resource_loading_task_runner_handle_impl.h
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h
[modify] https://crrev.com/a4b35d746e8582e457a14e3ca305dbf05d8f0fec/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abac20b43c3c938f3c8ac35060d16fd3de86c0bb

commit abac20b43c3c938f3c8ac35060d16fd3de86c0bb
Author: Farah Charab <farahcharab@google.com>
Date: Wed Jul 18 14:04:35 2018

Scheduler: Use net to blink priority map passed by finch parameters.

Use the map passed in the parameters of the resource fetch priority
finch study to schedule resource loading tasks on Blink.

Bug: 860545
Change-Id: I156afc89a347cc26816070679d2a8a568217720a
Reviewed-on: https://chromium-review.googlesource.com/1140155
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576030}
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/DEPS
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/abac20b43c3c938f3c8ac35060d16fd3de86c0bb/third_party/blink/renderer/platform/scheduler/main_thread/resource_loading_task_runner_handle_impl.cc

Labels: Merge-Request-69
This is a non-risky internal scheduling change which is not user-facing and with no UX/privacy/security implications.

We would like to merge this CL https://chromium-review.googlesource.com/c/chromium/src/+/1138079 to Beta's branch. It integrates the CL linked in this bug (which was submitted before Beta's freeze) into our existing code. It has been submitted since Monday, and no Crashes have been reported. 
Labels: -Pri-3 Pri-1
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 25

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OSs label. Thank you.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 for this CL https://chromium-review.googlesource.com/c/chromium/src/+/1138079  based on comment #5. Pls merge ASAP. Thank you.
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week last M69 Dev release. Thank you.
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week LAST M69 Dev release before Beta promotion. Thank you.

Labels: -Merge-Approved-69 merge-merged-3497
It's merged, but the bug was missing from the original patch, so no notification for the merge as well.

https://chromium-review.googlesource.com/c/chromium/src/+/1151990
Status: Started (was: Assigned)
Labels: -Type-Bug Type-Feature

Sign in to add a comment