[Autofill] JS formatting contradicts the last user edit logic. |
|||||||||||
Issue descriptionWhen we Autofill, to decide if we should fill a field or leave it as is, we check if the last edit was user's edit. If so, we would not autofill (clear, etc). But sometimes, the website writes on the top of the autofilled value (exp: formatting a phone number). So, if the user adds a value on the field, the JS would edit it, and it would be overwritten by autofill. Exp: disney, shipping, phone field.
,
Jul 5
,
Jul 20
also zip for etsy.
,
Jul 25
,
Jul 25
etsy and freepeople are of another nature. The problem is most probably rooted in the dynamic form. Added them to crbug/850231.
,
Jul 26
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469 commit e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Mon Jul 30 15:11:58 2018 [Autofill] Keeping the user edit. Problem: When we Autofill, to decide if we should fill a field or leave it as is, we check if the last edit was user's edit. If so, we would not autofill (clear, etc). But sometimes, the website writes on the top of the autofilled value (exp: formatting a phone number). So, if the user adds a value on the field, the JS would edit it, and it would be overwritten by autofill. Solution: Instead of looking at the last edit, look if the user has ever edited that field. Bug: 860542 , 867556 Change-Id: I59ec9c1efab98a9a07f23a47a0354e04ba9b87aa Reviewed-on: https://chromium-review.googlesource.com/1150683 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#579038} [modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/chrome/renderer/autofill/form_autofill_browsertest.cc [modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/components/autofill/content/renderer/form_autofill_util.cc [modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/public/web/web_form_control_element.h [modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/renderer/core/exported/web_form_control_element.cc [modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/renderer/core/html/forms/text_control_element.cc [modify] https://crrev.com/e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469/third_party/blink/renderer/core/html/forms/text_control_element.h
,
Jul 30
,
Jul 30
,
Jul 30
,
Jul 30
Pls apply appropriate OSs label.
,
Jul 30
,
Jul 31
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 31
Pls merge your change to M69 branch 3497 ASAP so we can pick it up for this week M69 Dev/Beta release. Thank you.
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2171da0f30ec3b712f4d23363c5950d38a8a140b commit 2171da0f30ec3b712f4d23363c5950d38a8a140b Author: Parastoo Geranmayeh <parastoog@google.com> Date: Tue Jul 31 19:42:18 2018 Merge-69 [Autofill] Keeping the user edit. Problem: When we Autofill, to decide if we should fill a field or leave it as is, we check if the last edit was user's edit. If so, we would not autofill (clear, etc). But sometimes, the website writes on the top of the autofilled value (exp: formatting a phone number). So, if the user adds a value on the field, the JS would edit it, and it would be overwritten by autofill. Solution: Instead of looking at the last edit, look if the user has ever edited that field. Bug: 860542 , 867556 Change-Id: I59ec9c1efab98a9a07f23a47a0354e04ba9b87aa Reviewed-on: https://chromium-review.googlesource.com/1150683 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Original-Commit-Position: refs/heads/master@{#579038}(cherry picked from commit e9e9833d8b0bedfd9d1a43084d2cd1aed13ef469) Reviewed-on: https://chromium-review.googlesource.com/1156766 Cr-Commit-Position: refs/branch-heads/3497@{#291} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/chrome/renderer/autofill/form_autofill_browsertest.cc [modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/components/autofill/content/renderer/form_autofill_util.cc [modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/public/web/web_form_control_element.h [modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/renderer/core/exported/web_form_control_element.cc [modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/renderer/core/html/forms/text_control_element.cc [modify] https://crrev.com/2171da0f30ec3b712f4d23363c5950d38a8a140b/third_party/blink/renderer/core/html/forms/text_control_element.h
,
Aug 2
mahmadi@: Maybe we should check this for iOS as well. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by parastoog@chromium.org
, Jul 5