New issue
Advanced search Search tips

Issue 860540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Enterprise startup dialog is crash on Mac

Project Member Reported by zmin@chromium.org, Jul 5

Issue description

The dialog is crashed when clicking the menu bar or dock icon due to there is no initialed Profile.
 
Labels: OS-Mac
Owner: zmin@chromium.org
Status: Assigned (was: Untriaged)
Components: Enterprise

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c5d538edca1d4ce88f6339e15b147def089b77a

commit 8c5d538edca1d4ce88f6339e15b147def089b77a
Author: Owen Min <zmin@chromium.org>
Date: Thu Aug 02 17:52:43 2018

Prevent app_controller_mac.mm access lastProfile when EnterpriseStartupDialog is displayed.

Because the dialog must be displayed before the Profile initalization as
the process might load the extensions which might open browser windows.

TEST=Set up a invalid token by setting any non-empty string in policy.
     MachineLevelUserCloudPolicyEnrollmentToken.
     a) Login mac.
     b) Create com.google.Chrome.plist (org.chromium.Chromium.plist for chromium) for the
        following content:
         <?xml version="1.0" encoding="UTF-8"?>
         <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
         <plist version="1.0">
         <dict>
            <key>MachineLevelUserCloudPolicyEnrollmentToken</key>
            <string>invalid-token</string>
         </dict>
         </plist>
     (More details in https://support.google.com/chrome/a/answer/7550274?hl=en)
     Launch Chrome. Instead of the chrome window, there should be an error dialog indicates
     that launching is blocked.
     1) The error dialog could be hidden/shown, lose or gain focus without any issue.
     2) Clicking any option in the menu bar or dock menu shouldn't open any browser window.

Bug:  860540 
Change-Id: Ibf4b7c2794a8ad78b9fedb2da67512508d3d7621
Reviewed-on: https://chromium-review.googlesource.com/1145862
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580242}
[modify] https://crrev.com/8c5d538edca1d4ce88f6339e15b147def089b77a/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/8c5d538edca1d4ce88f6339e15b147def089b77a/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc
[add] https://crrev.com/8c5d538edca1d4ce88f6339e15b147def089b77a/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest_mac_util.h
[add] https://crrev.com/8c5d538edca1d4ce88f6339e15b147def089b77a/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest_mac_util.mm
[modify] https://crrev.com/8c5d538edca1d4ce88f6339e15b147def089b77a/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.cc
[modify] https://crrev.com/8c5d538edca1d4ce88f6339e15b147def089b77a/chrome/test/BUILD.gn

Labels: -Pri-3 Pri-2
Status: Fixed (was: Assigned)

Sign in to add a comment