New issue
Advanced search Search tips

Issue 860528 link

Starred by 1 user
Status: Fixed
Owner:
mustaq@chromium.org
Closed: Jul 6
Cc:
csharrison@chromium.org
foolip@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 802294



Sign in to add a comment

NavigationConsumesUserGesture_Fullscreen test shouldn't pass!

Project Member Reported by mustaq@chromium.org, Jul 5 
Since a fullscreen request doesn't consume user activation, repeated requests are not blocked.  In this test we have an assertion that the second request would fail, which is wrong.

Perhaps the second request used to fail because of some race condition somewhere.  This is no longer the case with UAv2.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/731db1a9ccfa187184d84ed9ea6e7f0b4e1611f3

commit 731db1a9ccfa187184d84ed9ea6e7f0b4e1611f3
Author: Mustaq Ahmed <mustaq@google.com>
Date: Fri Jul 06 16:25:31 2018

Removed a test expectation that was passing mysteriously.

Since fullscreen requests doesn't consume user activation, repeated
requests don't fail.  The assertion removed here is wrong, may be
it was passing because of the back-to-back calls.

Change-Id: I6e74ec0fa2377e8e6876a07dc70bde1457a5312a
Bug:  860528 
Reviewed-on: https://chromium-review.googlesource.com/1108572
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572988}
[modify] https://crrev.com/731db1a9ccfa187184d84ed9ea6e7f0b4e1611f3/chrome/browser/chrome_navigation_browsertest.cc

Comment 2 by mustaq@chromium.org, Jul 6

Status: Fixed (was: Started)
►

Sign in to add a comment