New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860526 link

Starred by 11 users
Status: Fixed
Owner:
se...@chromium.org
Closed: Sep 24
Cc:
vamshi.kommuri@chromium.org
gov...@chromium.org
maxwalker@chromium.org
█ cma...@chromium.org
benmason@chromium.org
se...@chromium.org
jdoerrie@chromium.org
vkasatkin@google.com
anthonyvd@chromium.org
kariahda@chromium.org
█ durgapandey@chromium.org
█ jayhlee@chromium.org
ftirelo@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: 5
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature
Launch-Accessibility: NA
Launch-Exp-Leadership: NA
Launch-Leadership: NA
Launch-Legal: NA
Launch-Privacy: NA
Launch-Security: NA
Launch-Test: NA
Launch-UI: NA
Rollout-Type: Default

Blocked on:
issue 870328
issue 870366


Sign in to add a comment

Split profiles and credit cards policy/preference flags for enabling autofill

Project Member Reported by etiennep@chromium.org, Jul 5 
Feature description:
Autofill settings are coarse-grained today. An overall device level setting enables or disables Autofill on that device. This prevents users who might want to selectively enable addresses/contact info or payment methods from being able to do so. 

The proposal is to split Autofill addresses and payment methods into different settings pages, and have dedicated toggles for addresses (incl. autocomplete) and payment methods on their respective pages. Note that the new toggles only control the Autofill functionality.

It is also a requirement for the Butter project.

Details:
Add AutofillProfileEnabled user preference and policy to enable/disable autofill for profile information only, analog to AutofillCreditCardEnabled.
Add AutofillCreditCardEnabled policy as a user setting.
The combination of AutofillProfileEnabled and AutofillCreditCardEnabled will replace AutofillEnabled

Eng owner: etiennep@

Comment 1 by etiennep@chromium.org, Jul 10

Status: Started (was: Assigned)

Comment 2 by se...@chromium.org, Jul 11

Cc: vamshi.kommuri@chromium.org jayhlee@chromium.org vkasatkin@google.com
 Issue 855869  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/009cee5a893563d9ba27a73467f1b92f10c93b35

commit 009cee5a893563d9ba27a73467f1b92f10c93b35
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Wed Jul 11 16:12:18 2018

[Autofill]: Add AutofillProfileEnabled preference.

This creates and uses AutofillProfileEnabled flag to disable profile autofill.
This affects:
- PersonalDatamanager
- FormDataImporter
- AutofillManager

AutofillProfileEnabled will be added as a policy as a follow up CL.

Bug:  860526 
Change-Id: Ied9a29c9ada7b7e564f1ba19fa738854fab7b17e
Reviewed-on: https://chromium-review.googlesource.com/1127344
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574186}
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/autofill_merge_unittest.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/form_data_importer.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/form_data_importer.h
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/form_data_importer_unittest.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/test_autofill_manager.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/test_autofill_manager.h
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/test_personal_data_manager.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/common/autofill_pref_names.cc
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/autofill/core/common/autofill_pref_names.h
[modify] https://crrev.com/009cee5a893563d9ba27a73467f1b92f10c93b35/components/browser_sync/profile_sync_service_autofill_unittest.cc

Comment 4 by etiennep@chromium.org, Jul 12 

Adding screenshots for CL 1129471
Screenshot from 2018-07-12 09-45-04.png
34.7 KB View Download
Screenshot from 2018-07-12 09-45-19.png
36.9 KB View Download
Screenshot from 2018-07-12 09-46-17.png
5.5 KB View Download
Screenshot from 2018-07-12 09-46-43.png
6.7 KB View Download

Comment 5 by se...@chromium.org, Jul 12 

Quick question about your second screenshot, should having the master toggle to off set the sub-toggles to off too?

Comment 6 by etiennep@chromium.org, Jul 12 

This is shown in third screenshot. Sub-toggles are not turned off but grayed out. Do you think they should be turned off as well? If yes, would that mean automatically changing pref value?

Comment 7 by se...@chromium.org, Jul 12 

Tricky... I was afraid that user's would misinterpret it as being kept on. At the same time this should be temporary, until we remove the master toggle.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b27097af312f3f4a4ee22bf0ea2c65239de03ff

commit 1b27097af312f3f4a4ee22bf0ea2c65239de03ff
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Thu Jul 12 16:50:07 2018

[Autofill]: Create a policy flag for AutofillProfileEnabled.

AutofillProfileEnabled was added as a preference setting in 1127344.
This CL creates a policy flag for AutofillProfileEnabled that can
overwrite the user preference.

Bug:  860526 
Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
Reviewed-on: https://chromium-review.googlesource.com/1127463
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574601}
[modify] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/components/autofill/core/browser/BUILD.gn
[add] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/components/autofill/core/browser/autofill_profile_policy_handler.cc
[add] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/components/autofill/core/browser/autofill_profile_policy_handler.h
[add] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
[modify] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/components/policy/resources/policy_templates.json
[modify] https://crrev.com/1b27097af312f3f4a4ee22bf0ea2c65239de03ff/tools/metrics/histograms/enums.xml

Comment 9 by etiennep@chromium.org, Jul 13 

Adding screeshots for Android
Screenshot from 2018-07-13 11-14-47.png
22.9 KB View Download
Screenshot from 2018-07-13 11-14-57.png
22.3 KB View Download

Comment 10 Deleted

Comment 11 by se...@chromium.org, Jul 13 

Can you show us the other sub-toggle :)

Comment 12 by etiennep@chromium.org, Jul 13 

And for credit cards, it's a similar view.
Screenshot from 2018-07-13 11-33-44.png
21.5 KB View Download
Screenshot from 2018-07-13 11-33-54.png
20.2 KB View Download
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b74752858c9da77cf8b4ec305e5e82a1fbebfee

commit 6b74752858c9da77cf8b4ec305e5e82a1fbebfee
Author: Etienne Pierre-doray <etiennep@chromium.org>
Date: Thu Jul 19 23:05:13 2018

[Autofill]: Add profile and payment methods toggle buttons in settings/autofill.

Both AutofillProfileEnabled and AutofillCreditCardEnabled are preferences
that can't be modified by the user. This CL adds a toggle button for each one of
them in settings/autofill.
These flags do not delete existing data, therefore we don't want addresses and
payment methods to disapear when toggling the flag.
To fix that, this CL moves enabling logic from
PersonalDataManager::Get[Profiles/CreditCards]() to
PersonalDataManager::Get[Profiles/CreditCards]ToSuggest()

Bug:  860526 
Tbr: eugenebut@
Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I03f6e16294ae2a07da854c4d276e95f1a47ebbc0
Reviewed-on: https://chromium-review.googlesource.com/1129471
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576679}
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/chrome/app/settings_strings.grdp
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/address_combobox_model_unittest.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/autofill_wallet_data_type_controller.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/autofill_wallet_data_type_controller_unittest.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/autofill/core/browser/test_personal_data_manager.h
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/ios/chrome/browser/payments/ios_payment_instrument_launcher_unittest.mm
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/ios/chrome/browser/payments/payment_request_unittest.mm
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/ios/chrome/browser/payments/payment_response_helper_unittest.mm
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/ios/chrome/browser/ui/payments/credit_card_edit_coordinator_unittest.mm
[modify] https://crrev.com/6b74752858c9da77cf8b4ec305e5e82a1fbebfee/ios/web_view/internal/autofill/cwv_autofill_data_manager_unittest.mm
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d14d78868b670a90347be1154ad4694d3c08d06

commit 3d14d78868b670a90347be1154ad4694d3c08d06
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Jul 24 21:45:33 2018

[AF][IOS] Add fine-grained profile & credit card toggles to Autofill settings

screenshot: https://drive.google.com/open?id=1td8sD7YO_VwIlY8WTW5xRc4es7bOslxu

Bug:  860526 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9d2f1a589d9ae1bb5bac45c04ceb973f88385a84
Reviewed-on: https://chromium-review.googlesource.com/1145484
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577697}
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/components/autofill/ios/browser/personal_data_manager_observer_bridge.h
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/components/autofill/ios/browser/personal_data_manager_observer_bridge.mm
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm
[modify] https://crrev.com/3d14d78868b670a90347be1154ad4694d3c08d06/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm

Comment 15 by mahmadi@chromium.org, Jul 25

Labels: Merge-Request-69
+cmasso@
Verified the iOS patch on Chrome Canary 70.0.3502.0. Requesting merge of the iOS patch into M69.

Comment 16 by mahmadi@chromium.org, Jul 25

Cc: cma...@chromium.org
Project Member

Comment 17 by sheriffbot@chromium.org, Jul 25

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 40 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 18 by gov...@chromium.org, Jul 25

Cc: kariahda@chromium.org
+ kariahda@ (Chrome on iOS TPM) for M69 merge review, ptal comment #15. Thank you.

Comment 19 by kariahda@chromium.org, Jul 25

Cc: gov...@chromium.org
Is this a feature polish? This is the only iOS CL?
https://chromium-review.googlesource.com/c/chromium/src/+/1145484

@govind, iOS CL has string changes. Is this okay?

Comment 20 by gov...@chromium.org, Jul 25 

If this is a critical feature for M69, it is fine to have string change. Thank you.
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9b9d5ce790e92a85718575f1af65234facab24a

commit e9b9d5ce790e92a85718575f1af65234facab24a
Author: sebsg <sebsg@chromium.org>
Date: Thu Jul 26 20:45:46 2018

[Autofill] Change policy name for disabling address autofill.

Was called AutofillProfileEnabled
Is now called AutofillAddressEnabled

Bug:  860526 
Change-Id: Ic2b31c4a108a01049c59b1e6ccad62a7760c2cd9
Reviewed-on: https://chromium-review.googlesource.com/1150699
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578431}
[modify] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/components/autofill/core/browser/BUILD.gn
[rename] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/components/autofill/core/browser/autofill_address_policy_handler.cc
[add] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/components/autofill/core/browser/autofill_address_policy_handler.h
[rename] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/components/autofill/core/browser/autofill_address_policy_handler_unittest.cc
[delete] https://crrev.com/9b6bff2c092b99f9311eee3b90c7de2fa2958c27/components/autofill/core/browser/autofill_profile_policy_handler.h
[modify] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/components/policy/resources/policy_templates.json
[modify] https://crrev.com/e9b9d5ce790e92a85718575f1af65234facab24a/tools/metrics/histograms/enums.xml

Comment 22 by se...@chromium.org, Jul 26

Labels: Merge-Request-69
Project Member

Comment 23 by sheriffbot@chromium.org, Jul 26

Labels: -Merge-Request-69
This bug requires manual review: There is .grd file changes and we are only 39 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 24 by kariahda@chromium.org, Jul 26 

@mahmadi please see first couple of questions in c#19.

Is this a feature polish? This is the only iOS CL?
https://chromium-review.googlesource.com/c/chromium/src/+/1145484

Comment 25 by se...@chromium.org, Jul 30

Owner: se...@chromium.org
The feature is also for Android and Desktop. mahmadi@'s cl is the only iOS CL.

Thanks!

Comment 26 by kariahda@chromium.org, Jul 30 

Thanks, approved for iOS.

Comment 27 by se...@chromium.org, Jul 30 

+govind for Desktop. Thanks!

Comment 28 by gov...@chromium.org, Jul 30

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497, pls merge ASAP. Thank you.
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52

commit b6ce4d96e199dd70bc8fdcf4b10781baa145bf52
Author: sebsg <sebsg@chromium.org>
Date: Mon Jul 30 15:18:38 2018

Merge-69 [Autofill] Change policy name for disabling address autofill.

Was called AutofillProfileEnabled
Is now called AutofillAddressEnabled

TBR=sebsg@chromium.org

(cherry picked from commit e9b9d5ce790e92a85718575f1af65234facab24a)

Bug:  860526 
Change-Id: Ic2b31c4a108a01049c59b1e6ccad62a7760c2cd9
Reviewed-on: https://chromium-review.googlesource.com/1150699
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578431}
Reviewed-on: https://chromium-review.googlesource.com/1155091
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#205}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/components/autofill/core/browser/BUILD.gn
[rename] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/components/autofill/core/browser/autofill_address_policy_handler.cc
[add] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/components/autofill/core/browser/autofill_address_policy_handler.h
[rename] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/components/autofill/core/browser/autofill_address_policy_handler_unittest.cc
[delete] https://crrev.com/e68194e9862c76fa72a351040a436f95f5699a33/components/autofill/core/browser/autofill_profile_policy_handler.h
[modify] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/components/policy/resources/policy_templates.json
[modify] https://crrev.com/b6ce4d96e199dd70bc8fdcf4b10781baa145bf52/tools/metrics/histograms/enums.xml

Comment 30 by gov...@chromium.org, Jul 30

Cc: benmason@chromium.org amineer@chromium.org
+amineer@ & benmason@ (M69 Release TPMs for Android) as FYI.

sebsg@/etiennep@, all cross functional bits are currently set to NA. Could you pls double confirm no cross functional reviews are needed for this feature?

Comment 31 by se...@chromium.org, Jul 30

Cc: durgapandey@chromium.org

Comment 32 by gov...@chromium.org, Jul 30 

 durgapandey@, PTAL comment #30 and reply pls. Thank you.

Comment 33 by ma...@chromium.org, Jul 30

Owner: ma...@chromium.org

Comment 34 by ma...@chromium.org, Jul 31 

In addition, we have to check if the policy indicators are present on the toggles (I don't believe they are).

Comment 35 by se...@chromium.org, Aug 1 

 Issue 863827  has been merged into this issue.
Project Member

Comment 36 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d

commit 54d4cbfc88b19a38f46c40fd48c089c356cb2e5d
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Aug 01 12:36:20 2018

[Settings] Split Autofill settings into addresses and payments sections

Creates a new payments_section.html/js (credit cards for now).

With Autofill Home disabled, will add a new row in the Advanced Passwords and Forms
section to go to the credit cards section. There used to be one general Autofill
row that had both addresses and credit cards.

With Autofill Home enabled, the "Payments" row on the People page will now lead
to a payments-only section, and the "Addresses" row will lead to its own section
as well.

This is one change of several that will also clean up the settings toggle to
hopefully have a clearer story.

Screenshots of the change: https://goo.gl/iZWkCE (internal)

Bug:  860526 
Test: browser_tests
Change-Id: I7572ccc71633ee806b4a5db522a64e2b4f79d5dc
Reviewed-on: https://chromium-review.googlesource.com/1152475
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579779}
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/app/settings_strings.grdp
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[add] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
[add] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/test/data/webui/BUILD.gn
[add] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/test/data/webui/settings/autofill_section_test.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/test/data/webui/settings/passwords_and_autofill_fake_data.js
[modify] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/test/data/webui/settings/passwords_and_forms_browsertest.js
[add] https://crrev.com/54d4cbfc88b19a38f46c40fd48c089c356cb2e5d/chrome/test/data/webui/settings/payments_section_test.js
[delete] https://crrev.com/cedc263f223d9f418270ef37d75b663b2cdec41b/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

Comment 37 by se...@chromium.org, Aug 1 

For M69, we will simply hide the toggles. The full launch, with the page split, will happen in M70.

I'm writing the hiding CL

Comment 38 by ftirelo@chromium.org, Aug 2 

The dropdown footer for credit cards is still linking to chrome://settings/autofill. It should point to chrome://settings/payments.

Comment 39 by ma...@chromium.org, Aug 2

Blockedon: 870366
Project Member

Comment 40 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60c3e65bdca79ce2074eb6065536b4ad191f90ad

commit 60c3e65bdca79ce2074eb6065536b4ad191f90ad
Author: sebsg <sebsg@chromium.org>
Date: Mon Aug 06 13:14:37 2018

M69 [AF] Hide the settings toggles for addresses and cards.

Also always sets the prefs for enabling addresses and cards to true
unless explicitely turned off by a policy.

The split toggles will be launched in M70 instead.

Bug:  860526 ,  870370 
Change-Id: I335482fba1f7775b16b90cc78f6c3d830086d71a
Reviewed-on: https://chromium-review.googlesource.com/1160594
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#413}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/60c3e65bdca79ce2074eb6065536b4ad191f90ad/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/60c3e65bdca79ce2074eb6065536b4ad191f90ad/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/60c3e65bdca79ce2074eb6065536b4ad191f90ad/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/60c3e65bdca79ce2074eb6065536b4ad191f90ad/components/autofill/core/browser/autofill_address_policy_handler.cc
[modify] https://crrev.com/60c3e65bdca79ce2074eb6065536b4ad191f90ad/components/autofill/core/browser/autofill_credit_card_policy_handler.cc

Comment 41 by jdoerrie@chromium.org, Aug 6

Cc: jdoerrie@chromium.org maxwalker@chromium.org
 Issue 866780  has been merged into this issue.

Comment 42 by ma...@chromium.org, Aug 14

Owner: mahmadi@chromium.org

Comment 43 by mahmadi@chromium.org, Aug 14

Blockedon: 870328
Project Member

Comment 44 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b24d6f3f4872591db9457559a7fc6bde01aaa2

commit 97b24d6f3f4872591db9457559a7fc6bde01aaa2
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Aug 14 16:30:48 2018

[AF] Deprecates autofill::prefs::kAutofillEnabled

Deprecates kAutofillEnabled in favor of finer grained
kAutofillProfileEnabled and kAutofillCreditCardEnabled

Keeps kAutofillEnabled around to maintain backward compatibility for the
extensions and the policy APIs. If kAutofillEnabled is set by an extension,
values of kAutofillProfileEnabled and  kAutofillCreditCardEnabled are also
set. Similarly, if kAutofillEnabled is disabled by policy, the two
fine-grained prefs are also disabled.

Chrome extension for testing the chrome.privacy.services API:
https://github.com/mhahmadi/autofill-pref-api-test-extension

TBR=michaelbai@

Bug:  870328 ,  860526 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8e6ca4594aa73c3d9228734948353f6a686227ad
Reviewed-on: https://chromium-review.googlesource.com/1166211
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582936}
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/android_webview/browser/aw_browser_context.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/browser/extensions/api/preference/preference_apitest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/common/extensions/api/privacy.json
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/chrome/test/data/extensions/api_test/preference/standard/test.js
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/autofill_policy_handler.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/autofill_policy_handler_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/autofill/ios/browser/autofill_agent.mm
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/password_manager/core/browser/votes_uploader_unittest.cc
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/components/policy/resources/policy_templates.json
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/97b24d6f3f4872591db9457559a7fc6bde01aaa2/ios/web_view/internal/cwv_preferences_unittest.mm

Comment 45 by francos6...@gmail.com, Aug 14 

Francis M Ramirez, Sr.
Project Member

Comment 46 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0609fce66284c741b2a63d4a9b548555af2ad8d3

commit 0609fce66284c741b2a63d4a9b548555af2ad8d3
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Aug 16 17:47:36 2018

[AF][IOS] Split Autofill settings page into two separate pages

Splits Autofill settings page into two separate pages, one for addresses
and the other for credit cards.

Bug:  860526 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8f02f93fbd54fc17c2b97e5a97d9d5a08f729197
Reviewed-on: https://chromium-review.googlesource.com/1173314
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583716}
[modify] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/BUILD.gn
[copy] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.h
[copy] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller_unittest.mm
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm
[rename] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.h
[rename] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm
[rename] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller_unittest.mm
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm
[delete] https://crrev.com/870f84343355fe3b8d9bb9f5736c822c960cb2b4/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/BUILD.gn
[rename] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/Contents.json
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses.png
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses@2x.png
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses@3x.png
[delete] https://crrev.com/870f84343355fe3b8d9bb9f5736c822c960cb2b4/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
[delete] https://crrev.com/870f84343355fe3b8d9bb9f5736c822c960cb2b4/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
[delete] https://crrev.com/870f84343355fe3b8d9bb9f5736c822c960cb2b4/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
[copy] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/Contents.json
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods.png
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods@2x.png
[add] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods@3x.png
[modify] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/0609fce66284c741b2a63d4a9b548555af2ad8d3/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
Project Member

Comment 47 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b48ae1889f39d3fd8a05f4320623e4703db2b7

commit 46b48ae1889f39d3fd8a05f4320623e4703db2b7
Author: apacible <apacible@chromium.org>
Date: Fri Aug 17 17:17:58 2018

Revert "[AF][IOS] Split Autofill settings page into two separate pages"

This reverts commit 0609fce66284c741b2a63d4a9b548555af2ad8d3.

Reason for revert: ios tests failing -- see crbug/875313

Original change's description:
> [AF][IOS] Split Autofill settings page into two separate pages
> 
> Splits Autofill settings page into two separate pages, one for addresses
> and the other for credit cards.
> 
> Bug:  860526 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I8f02f93fbd54fc17c2b97e5a97d9d5a08f729197
> Reviewed-on: https://chromium-review.googlesource.com/1173314
> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583716}

TBR=rohitrao@chromium.org,mahmadi@chromium.org

Change-Id: If4646cab4665d962e4ee166516a961390cb54436
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  860526 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1179342
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584110}
[modify] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/BUILD.gn
[rename] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/autofill_collection_view_controller.h
[rename] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[rename] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/autofill_collection_view_controller_unittest.mm
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.h
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller_unittest.mm
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm
[add] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/resources/BUILD.gn
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses.png
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses@2x.png
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses@3x.png
[rename] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
[add] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
[add] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
[add] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/Contents.json
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods.png
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods@2x.png
[delete] https://crrev.com/b597d40b6e8a61b207101fa6fb2163067bf2a4b5/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods@3x.png
[modify] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/46b48ae1889f39d3fd8a05f4320623e4703db2b7/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
Project Member

Comment 48 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb16e724c8fcbde85a7220cb0f34135d1a193a66

commit fb16e724c8fcbde85a7220cb0f34135d1a193a66
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Aug 17 21:21:18 2018

[RELAND][AF][IOS] Split Autofill settings page into two separate pages

Splits Autofill settings page into two separate pages, one for addresses
and the other for credit cards.

TBR=rohitrao@

Bug:  860526 , 875313 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b579976f44b413d24d71e04bfb6ef8642e5c78f
Reviewed-on: https://chromium-review.googlesource.com/1180266
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584193}
[modify] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/BUILD.gn
[copy] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.h
[copy] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller.mm
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_credit_card_collection_view_controller_unittest.mm
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_credit_card_settings_egtest.mm
[rename] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.h
[rename] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller.mm
[rename] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_profile_collection_view_controller_unittest.mm
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/autofill_profile_settings_egtest.mm
[delete] https://crrev.com/834c929e148794a495660aa15ef8ef5755b7e3f3/ios/chrome/browser/ui/settings/autofill_settings_egtest.mm
[modify] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/BUILD.gn
[rename] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/Contents.json
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses.png
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses@2x.png
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_addresses.imageset/addresses@3x.png
[delete] https://crrev.com/834c929e148794a495660aa15ef8ef5755b7e3f3/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
[delete] https://crrev.com/834c929e148794a495660aa15ef8ef5755b7e3f3/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
[delete] https://crrev.com/834c929e148794a495660aa15ef8ef5755b7e3f3/ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
[copy] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/Contents.json
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods.png
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods@2x.png
[add] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/resources/settings_payment_methods.imageset/payment_methods@3x.png
[modify] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/fb16e724c8fcbde85a7220cb0f34135d1a193a66/ios/chrome/browser/ui/settings/settings_navigation_controller.mm
Project Member

Comment 49 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2

commit f7714ff86806999c5f2f07b7ae5b2c1e79907ac2
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Thu Aug 30 21:20:26 2018

[Autofill] Add Autofill profile and payment methods settings on Android

This CL replicates on Android the following changes already done on
other platforms:
 - Replace the Autofill toggle with two new toggles, one for credit
   cards and one for addresses, and add them to the corresponding
   pages in Settings;
 - Update the strings for titles, toggles, and toggle descriptions;
 - Delete deprecated strings.

This takes up crrev.com/c/1135514, which was abandoned. Comments
initially added there have also been addressed here.

A follow-up CL will get rid of the "Autofill and payments" page
and move the "Addresses" and "Payments" page to the top Settings
page.

Screenshots and video (Googlers only): https://drive.google.com/open?id=1ZZr2lbX9q48DAxiTSVq6dZCImchqz-yA

Bug:  860526 
Change-Id: I613f3badfb655532228ee1b6b6029eac06f1d42f
Reviewed-on: https://chromium-review.googlesource.com/1194474
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587770}
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/res/xml/autofill_and_payments_preferences.xml
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragmentTest.java
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/android/preferences/preferences_launcher.cc
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/android/preferences/preferences_launcher.h
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/android/preferences/prefs.h
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/android/preferences/prefs_unittest.cc
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/autofill/android/personal_data_manager_android.h
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/components/autofill/core/common/autofill_prefs.cc
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/components/autofill/core/common/autofill_prefs.h
[modify] https://crrev.com/f7714ff86806999c5f2f07b7ae5b2c1e79907ac2/components/autofill_strings.grdp
Project Member

Comment 50 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/47e425cbd8219245fe7ca42c4519439ab9cea235

commit 47e425cbd8219245fe7ca42c4519439ab9cea235
Author: John Budorick <jbudorick@google.com>
Date: Fri Aug 31 04:49:16 2018
Project Member

Comment 51 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e8a67679cecb521eee5e76d59d43f8792d08897

commit 2e8a67679cecb521eee5e76d59d43f8792d08897
Author: sebsg <sebsg@chromium.org>
Date: Fri Aug 31 20:26:35 2018

[AF] Clean up Autofill settings toggles.

Remove the master toggle.
Add sublabels for the profile and credit card toggles.
Add row to inform users if an extention is managing the toggles.
Change the title from "Addresses" to "Addresses and more".

Bug:  860526 ,  877801 
Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13
Reviewed-on: https://chromium-review.googlesource.com/1196924
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588148}
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/app/settings_strings.grdp
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/test/data/extensions/api_test/settings_private/test.js
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/test/data/webui/settings/autofill_section_test.js
[modify] https://crrev.com/2e8a67679cecb521eee5e76d59d43f8792d08897/chrome/test/data/webui/settings/payments_section_test.js

Comment 52 by se...@chromium.org, Sep 4

Labels: Merge-Request-70
Project Member

Comment 53 by sheriffbot@chromium.org, Sep 4

Labels: -Merge-Request-70 Merge-Review-70
This bug requires manual review: There is .grd file changes and we are only 41 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 54 by se...@chromium.org, Sep 4 

The .grd change in my CL is removing string, I'm not adding any.

Comment 55 Deleted

Comment 56 by benmason@chromium.org, Sep 4 

Confirmed .grd change is removal. Approved for merge into 70, branch 3538.

Comment 57 by durgapandey@chromium.org, Sep 4

Labels: -Launch-Accessibility-NA -Launch-Legal-NA -Launch-Security-NA -Launch-Privacy-NA -Launch-UI-NA -Launch-Test-NA Launch-Accessibility-ReviewRequested Launch-Legal-ReviewRequested Launch-Privacy-ReviewRequested Launch-Security-ReviewRequested Launch-Test-ReviewRequested Launch-UI-ReviewRequested

Comment 58 by se...@chromium.org, Sep 5

Labels: merge-merged-3538
It seems like bugdroid didn't update this, but the merge landed on 3538: https://chromium-review.googlesource.com/c/chromium/src/+/1207215
Project Member

Comment 59 by bugdroid1@chromium.org, Sep 5

Labels: -merge-approved-70
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19e310ee3fadb69e485b2cd51485e48f6287df85

commit 19e310ee3fadb69e485b2cd51485e48f6287df85
Author: sebsg <sebsg@chromium.org>
Date: Wed Sep 05 17:26:54 2018

Merge-70 [AF] Clean up Autofill settings toggles.

Remove the master toggle.
Add sublabels for the profile and credit card toggles.
Add row to inform users if an extention is managing the toggles.
Change the title from "Addresses" to "Addresses and more".

TBR=sebsg@chromium.org

(cherry picked from commit 2e8a67679cecb521eee5e76d59d43f8792d08897)

Bug:  860526 ,  877801 
Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13
Reviewed-on: https://chromium-review.googlesource.com/1196924
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588148}
Reviewed-on: https://chromium-review.googlesource.com/1207215
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#53}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/app/settings_strings.grdp
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/test/data/extensions/api_test/settings_private/test.js
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/test/data/webui/settings/autofill_section_test.js
[modify] https://crrev.com/19e310ee3fadb69e485b2cd51485e48f6287df85/chrome/test/data/webui/settings/payments_section_test.js
Project Member

Comment 60 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cefd7e5ab34f13fda99797bfb1a054b38e14cce8

commit cefd7e5ab34f13fda99797bfb1a054b38e14cce8
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Thu Sep 06 14:17:01 2018

[AF] Move "Payment apps" into "Payment methods" on Android Settings

A follow-up CL will delete the "Autofill and payments" page and move
"Addresses and more" and "Payment methods" into the main Settings page.
Moving "Payment apps" into the "Payment methods" as a separate step
to make CLs easier to review.

Screenshots (Googlers only): https://drive.google.com/open?id=1QMBcQKZ_O2aaxLs5OFf3zfyY7JSgcxgX

Bug:  860526 
Change-Id: I57a107a15a7f8aab94a1125e79e6616957eaa49a
Reviewed-on: https://chromium-review.googlesource.com/1199684
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589156}
[modify] https://crrev.com/cefd7e5ab34f13fda99797bfb1a054b38e14cce8/chrome/android/java/res/xml/autofill_and_payments_preferences.xml
[modify] https://crrev.com/cefd7e5ab34f13fda99797bfb1a054b38e14cce8/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
[modify] https://crrev.com/cefd7e5ab34f13fda99797bfb1a054b38e14cce8/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java
[delete] https://crrev.com/19eaae68c82b00edc2a2bafbafe94961f2e9852f/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
[add] https://crrev.com/cefd7e5ab34f13fda99797bfb1a054b38e14cce8/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPaymentMethodsFragment.java
[modify] https://crrev.com/cefd7e5ab34f13fda99797bfb1a054b38e14cce8/chrome/android/java_sources.gni

Comment 61 by ma...@chromium.org, Sep 6

Owner: ftirelo@chromium.org
Project Member

Comment 63 by bugdroid1@chromium.org, Sep 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884a71627af607bfb8c97b434e158c7293f7f280

commit 884a71627af607bfb8c97b434e158c7293f7f280
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Fri Sep 07 18:12:25 2018

[AF] Move links to addresses and payment methods to main Settings page

This CL eliminates the "Autofill and payments" page and move "Addresses
and more" and "Payment methods" into the main Settings page.

A follow-up CL will fix allow access to the "Payment methods" page even
if the corresponding toggle is enabled by policy, to allow users to
access payment apps.

Screenshots (Googlers only): https://drive.google.com/open?id=17VDj8kUArJVxilLaT9CvzYYepewsUGMF

Bug:  860526 
Change-Id: I9120bd7ca21607485b2b6e144aaf8a5e31abc3c3
Reviewed-on: https://chromium-review.googlesource.com/1208191
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589585}
[delete] https://crrev.com/cf181e265fae9a5e905dde6dbcb37fc4f9826298/chrome/android/java/res/xml/autofill_and_payments_preferences.xml
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/res/xml/main_preferences.xml
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[delete] https://crrev.com/cf181e265fae9a5e905dde6dbcb37fc4f9826298/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPaymentMethodsFragment.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditorPreference.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerProfilePreferences.java
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/884a71627af607bfb8c97b434e158c7293f7f280/chrome/android/java_sources.gni

Comment 64 by amineer@chromium.org, Sep 8

Cc: -amineer@chromium.org
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!

Comment 66 by twelling...@chromium.org, Sep 12 

Is there a UI review thread approving this change for Android? Android settings historically haven't exactly mirrored desktop so it'd be good to call out the Android behavior specifically and secure approvals.

Comment 67 by ftirelo@chromium.org, Sep 12 

twellington@: This is the LR bug. We will ask the UXer to test with a Canary containing crrev.com/c/1214045.
Project Member

Comment 68 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224f33c98ecdaf0e2efeff58ba4d7befeb83fd98

commit 224f33c98ecdaf0e2efeff58ba4d7befeb83fd98
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Thu Sep 13 17:24:55 2018

[AF] Allow access to payment apps even if autofill feature is disabled

This CL includes the following changes:
 - Allow access to both "Addresses and more" and "Payment methods"
   from the main Settings page even if Autofill is disabled by
   policy. For payment methods, this allows access to the payment
   apps, which are not managed. Also enabling for addresses for
   consistency.
 - Ensure the toggles and the "Add" buttons are disabled if Autofill
   is disabled by policy.

Screenshots (Googlers only): https://drive.google.com/open?id=1eVYdk0o5E2ka5xSr9ZBYlZawPL8z28an

Change-Id: I3008ea588f497070b94f23fe449f3cc122620087
Bug:  860526 
Reviewed-on: https://chromium-review.googlesource.com/1214045
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591056}
[modify] https://crrev.com/224f33c98ecdaf0e2efeff58ba4d7befeb83fd98/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/224f33c98ecdaf0e2efeff58ba4d7befeb83fd98/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPaymentMethodsFragment.java
[modify] https://crrev.com/224f33c98ecdaf0e2efeff58ba4d7befeb83fd98/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java

Comment 69 by durgapandey@google.com, Sep 24

Description: Show this description

Comment 70 by ftirelo@chromium.org, Sep 24

Owner: se...@chromium.org

Comment 71 by ftirelo@chromium.org, Sep 24

Labels: -Type-Feature Type-Launch

Comment 72 by ftirelo@chromium.org, Sep 24

Labels: -Type-Launch Type-Feature

Comment 73 by ftirelo@chromium.org, Sep 24

Labels: -Type-Feature Type-Bug

Comment 74 by ftirelo@chromium.org, Sep 24

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)

Comment 75 by ftirelo@chromium.org, Sep 24

Labels: -Launch-Privacy-ReviewRequested -Launch-Accessibility-ReviewRequested -Launch-Legal-ReviewRequested -Launch-Security-ReviewRequested -Launch-Test-ReviewRequested -Launch-UI-ReviewRequested Launch-Accessibility-NA Launch-Legal-NA Launch-Privacy-NA Launch-Security-NA Launch-Test-NA Launch-UI-NA

Comment 76 by ftirelo@chromium.org, Sep 24 

This is not a launch bug, so no review labels apply.
►

Sign in to add a comment