New issue
Advanced search Search tips

Issue 860525 link

Starred by 1 user
Status: WontFix
Owner:
jkrcal@chromium.org
Closed: Jul 9
Cc:
estevenson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.9 KB regression in resource_sizes (MonochromePublic.apk) at 572650:572650

Project Member Reported by estevenson@chromium.org, Jul 5 
Caused by "[Autofill profile] Integrate USS bridge behind a feature toggle"

Commit: 7d2b56d415390e16176357a002f2f49389361974

Link to size graph: https://chromeperf.appspot.com/report?sid=bb23072657e2d7ca892a1c3fa4643b1ee29b3a0a44d0732adda87168e89c0380&num_points=10&rev=572650

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Base on the graph: native code size

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jul 5 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=860525

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1afd1c6faee88f5a877ebdd5fe806f8d53d2d3cc19e3a8bc9719cba01a856ed2


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jul 5 

Assigning to jkrcal@chromium.org because this is the only CL in range:
[Autofill profile] Integrate USS bridge behind a feature toggle

This CL adds a new feature toggle that enables the new USS
implementation of autofill profile sync bridge. Initially, this is set
to disabled by default for users and also disabled for trybots. When
we get complete test coverage, we enable this feature for trybots.

Bug: 836718
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa9893f6780e0cbcdb54365b18baf88b398b8a9c
Reviewed-on: https://chromium-review.googlesource.com/1114968
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572650}

Comment 3 by jkrcal@chromium.org, Jul 9

Status: WontFix (was: Assigned)
This size increase is expected; the CL forced the linker to include the new code (because it is now determined during run-time whether it is needed).

This is part of a refactoring effort within Chrome Sync, we update the sync integration for individual sync data types to use a newer sync API (called USS).

 - Short-term this means code increase because we have two integrations in parallel;
 - Mid-term (when we remove the previous integration) resource_sizes should come back to neutral or even slightly negative. 
 - Long-term (when we migrate all data types), we remove *a lot* of native code of the previous sync API.
►

Sign in to add a comment