merge step of performance_test_suite fails with "TypeError: 'NoneType' object is not iterable" |
||
Issue descriptionLog: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Flinux-perf%2F393%2F%2B%2Frecipes%2Fsteps%2Fperformance_test_suite_on_NVIDIA_GPU_on_Linux%2F0%2Flogs%2FMerge_script_log%2F0 We need to improve multiprocessing error handling to see what's going on
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab64006283ffc61d7028d094a5c2adf4ce7d53f7 commit ab64006283ffc61d7028d094a5c2adf4ce7d53f7 Author: Ned Nguyen <nednguyen@google.com> Date: Fri Jul 06 16:59:48 2018 Improve exception logging and handling of multiprocesing in process_perf_results Bug:860518 Change-Id: I328eb1ad5913e6c3438010e73a2b88272cf06982 TBR=eyaich@chromium.org Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi NOTRY=true Change-Id: I328eb1ad5913e6c3438010e73a2b88272cf06982 Reviewed-on: https://chromium-review.googlesource.com/1128040 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#573001} [modify] https://crrev.com/ab64006283ffc61d7028d094a5c2adf4ce7d53f7/tools/perf/process_perf_results.py
,
Jul 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3f710d70a68f43e9424907df12547581f146b78 commit a3f710d70a68f43e9424907df12547581f146b78 Author: Ned Nguyen <nednguyen@google.com> Date: Sun Jul 08 00:36:28 2018 Correct the return value of _upload_individual_benchmark in case of Exception raised. Previously, when there is any exception, this return (benchmark_name, False). The correct value is (benchmark_name, True) since the second param describes "whether the benchmark has failed". This also add logic to handles the case perf dashboard output_file doesn't exist in _write_perf_data_to_logfile (see the error stack at the end of https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2Flinux-perf%2F415%2F%2B%2Frecipes%2Fsteps%2Fperformance_test_suite_on_NVIDIA_GPU_on_Linux%2F0%2Flogs%2FMerge_script_log%2F0) Bug:860518, 861527 Change-Id: I17bc1b0a66670301c00c7aec9f1ec8e61446bc3d TBR=eyaich@chromium.org Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi NOTRY=true Change-Id: I17bc1b0a66670301c00c7aec9f1ec8e61446bc3d Reviewed-on: https://chromium-review.googlesource.com/1128410 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#573176} [modify] https://crrev.com/a3f710d70a68f43e9424907df12547581f146b78/tools/perf/process_perf_results.py
,
Jul 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea28776424d02e0c21242069bdfe89d90315a951 commit ea28776424d02e0c21242069bdfe89d90315a951 Author: Ned Nguyen <nednguyen@google.com> Date: Sun Jul 08 06:13:57 2018 Fix reference to output_json_file.get_viewer_url with viewer_url variable This also wrap the call to _handle_perf_results in a try catch to block to handle any failures of that method gracefully. NOTRY=true TBR=eyaich@chromium.org Bug: 860518, 861527 Change-Id: Ibf99b132d2520227b4da861935ef939ebafbd542 Reviewed-on: https://chromium-review.googlesource.com/1128418 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#573183} [modify] https://crrev.com/ea28776424d02e0c21242069bdfe89d90315a951/tools/perf/process_perf_results.py
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 5