New issue
Advanced search Search tips

Issue 860513 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PictureInPictureWindowControllerBrowserTest.CrossOriginFrameEnterLeaveCloseWindow" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 5

Issue description

"PictureInPictureWindowControllerBrowserTest.CrossOriginFrameEnterLeaveCloseWindow" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyXAsSBUZsYWtlIlFQaWN0dXJlSW5QaWN0dXJlV2luZG93Q29udHJvbGxlckJyb3dzZXJUZXN0LkNyb3NzT3JpZ2luRnJhbWVFbnRlckxlYXZlQ2xvc2VXaW5kb3cM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 853643 .
 
Owner: fbeaufort@chromium.org
Status: Assigned (was: Untriaged)
A CL to disable the test is in CQ

Assign to fbeaufort@ who is the owner of  issue 853643 .
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ebf32ceb4a23b87372b573a8870e2df0299ae17

commit 1ebf32ceb4a23b87372b573a8870e2df0299ae17
Author: Ella Ge <eirage@chromium.org>
Date: Thu Jul 05 17:24:12 2018

Disable flaky CrossOriginFrameEnterLeaveCloseWindow test

TBR=mlamouri@chromium.org

Bug:  860513 
Change-Id: I7e9287c7fad16728a79c296dd50f8b41bdfe683e
Reviewed-on: https://chromium-review.googlesource.com/1127151
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572821}
[modify] https://crrev.com/1ebf32ceb4a23b87372b573a8870e2df0299ae17/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Labels: -Sheriff-Chromium
Cc: mlamouri@chromium.org
mlamouri@ any idea what could cause this?
Test logs show [1:1:0705/073947.468303:FATAL:webmediaplayer_impl.cc(816)] Check failed: !pipeline_controller_.IsStable(). 


I would expect things to improve with https://chromium-review.googlesource.com/c/chromium/src/+/1126450
Components: Blink>Media>PictureInPicture
Cc: -mlamouri@chromium.org fbeaufort@chromium.org
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fe1784a5f87ee8c82fafee88c18c3d3bc0dcde3

commit 7fe1784a5f87ee8c82fafee88c18c3d3bc0dcde3
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jul 10 03:06:51 2018

Picture-in-Picture: re-enable flaky browsertests.

All the flaky tests were because of a DCHECK that is no longer relevant.

Bug:  855883 ,  860513 
Change-Id: I71de5bf9506e76959e3da4507b91a1e34672f7f4
Reviewed-on: https://chromium-review.googlesource.com/1130850
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573601}
[modify] https://crrev.com/7fe1784a5f87ee8c82fafee88c18c3d3bc0dcde3/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment