New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860511 link

Starred by 2 users
Status: Fixed
Owner:
█ akaba@google.com
Last visit > 30 days ago
Closed: Jul 10
Cc:
wjmaclean@chromium.org
█ fsam...@chromium.org
mcnee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot zoom in per-tab zoom mode

Project Member Reported by mcnee@chromium.org, Jul 5 
Chrome Version: 69.0.3481.0

What steps will reproduce the problem?
(1) Install an extension that uses the tabs zoom API to set zoom settings such as "Tabs Zoom API Demo" ( https://developer.chrome.com/extensions/samples#search:tabs%20zoom%20api%20demo )
(2) Visit a web page
(3) Open the extension's popup
(4) Observe that mode is automatic and scope is per-origin
(5) Change scope to per-tab
(6) Press the Set Zoom Settings button
(7) Close the extension's popup
(8) Attempt to zoom the page

What is the expected result?
The page zooms.

What happens instead?
The page does not zoom (although the zoom bubble is shown as if it were).

This was noticed in https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ExtVOuIWddU
The reporter identified https://chromium.googlesource.com/chromium/src/+/c6bd1218e88d15c43a495a638c8cd65105c146e4 as the culprit CL, so assigning to the author.

Comment 1 by akaba@google.com, Jul 5 

Apparently the problem is caused by temporary zoom. The problem is gone when the following lines are commented:

1258-1259 in RenderWidget.cc
1829-1830 in RenderViewImpl.cc

I might have bad assumptions about how temporary zoom works in my mind, so I will look into this further and talk to the person who implemented temporary zoom to see if I can get a better idea on what it does exactly.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50

commit 3483d8fd93ad2ac6c6b86cad2cca55ea37442d50
Author: akaba <akaba@google.com>
Date: Tue Jul 10 21:43:09 2018

Fix zoom in per-tab mode.

Zoom in per-tab mode was broken after
https://chromium.googlesource.com/chromium/src/+/c6bd1218e88d15c43a495a638c8cd65105c146e4
because RenderWidget::UpdateZoom and RenderViewImpl::UpdateZoomLevel were not updating the
zoom level when temporary zoom level is enabled in both the visual properties and RenderWidget.
This is not the intended behavior and this CL addresses this issue by removing temporary zoom
as part of visual properties and handling temporary zoom settings in the browser side instead.

Bug:  860511 
TBR: kenrb@chromium.org
Change-Id: Ic4326438cdec27936fee59d9384a71e7d1e9a238
Reviewed-on: https://chromium-review.googlesource.com/1127465
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573925}
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/host_zoom_map_impl.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/common/frame_messages.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/common/frame_visual_properties.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/common/view_messages.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/common/visual_properties.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/public/renderer/render_frame.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/browser_plugin/browser_plugin.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_frame_impl.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_view_impl.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_view_impl.h
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_widget.cc
[modify] https://crrev.com/3483d8fd93ad2ac6c6b86cad2cca55ea37442d50/content/renderer/render_widget.h

Comment 3 by akaba@google.com, Jul 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment