New issue
Advanced search Search tips

Issue 860502 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl try for a single bot broken

Project Member Reported by petermayo@google.com, Jul 5

Issue description


petermayo@bay:~/clients/chromium/src$ git cl try -b linux-blink-gen-property-trees
Scheduling CQ dry run on: https://chromium-review.googlesource.com/1119230


I didn't ask for a CQ dry run, I asked for a single tryjob.
That's what I wanted, it's what the git cl try --help indicates, and I'm fairly sure it used to work.
 
Potential fix:

--- a/git_cl.py
+++ b/git_cl.py
@@ -424,6 +424,8 @@ def _get_bucket_map_for_builders(builders):
     bucket = builders_map.get(builder, {}).get('bucket')
     if bucket:
       bucket_map.setdefault(bucket, {})[builder] = []
+    else:
+      return None, 'Failed to find builder %s in known master.' % builder
   return bucket_map, None

git cl try -b linux-blink-gen-property-trees -B luci.chromium.try

finds the non-default bot.  We could also document that we need the master if the trybot is not in the default list somewhere more discoverable.

Or we could expand the dict of places we look to match the gerrit web tryjob picker interface.
Components: Infra>SDK
Status: Available (was: Untriaged)

Sign in to add a comment