Incognito text in bullet list doesn't look nice |
||||||||||
Issue descriptionChange language to French What steps will reproduce the problem? (1) Open a new incognito tab What is the expected result? The text in the bullet list should have a better handling of line break. In particular I would expect the new lines to be aligned with either the bullet or the first letter after the bullet. What happens instead? The line break goes back to the edge of the screen. Also, the text is different from the Android text on Canary. Do we plan to have a different incognito text?
,
Jul 10
,
Jul 10
,
Jul 16
@gambard @justincohen do either of you have idea for how to make a bulleted list format nicely instead of an NSAttributedString?
,
Jul 17
ParagraphStyle headIndent? However I don't know how it would work if you change the font size. https://developer.apple.com/documentation/uikit/nsmutableparagraphstyle/1525135-headindent?language=objc
,
Jul 19
Take a look at sad_tab_view.mm. I think peterlaurens@ had to deal with something similar for the bulleted list on the sad tab view (after you tap on Reload).
,
Jul 30
The code in sad_tab_view.mm is indeed helpful, thanks. I'm concerned that trying to properly format this text will be too large a change for M69. It will require either adding new strings or tearing apart the existing string in a way that feels brittle. For M69, I'd like to propose going back to the old incognito description text, but using UIRefresh fonts and supporting dynamic type. I've attached a screenshot.
,
Jul 30
+ folks in case they have more context That is fine by me but what was the reason to change the incognito text to begin with. Was that a hard requirement from another team in Chrome?
,
Jul 30
After discussion with Martijn, we're going to stick with the new text but remove the leading indent from the bulleted lists. This will mitigate the visual impact of having text span multiple lines, but it won't fix the underlying issue. For M70+ I can work on a CL to fix this properly, but it will likely require strings changes.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68a979bd87269cf64f1cb228cef5cb997dfb78cc commit 68a979bd87269cf64f1cb228cef5cb997dfb78cc Author: Rohit Rao <rohitrao@chromium.org> Date: Mon Jul 30 16:49:00 2018 [ios] Removes leading whitespace from the incognito NTP text. The items in the bulleted lists on the NTP are indented with eight leading spaces. This causes issues when text wraps to multiple lines, as the subsequent lines are not indented. Mitigate the impact of this behavior by manually removing the leading whitespace from bulleted list items, so that when text wraps, subsequent lines do not look as bad. BUG= 860500 TEST=The incognito NTP bulleted lists should not be indented. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibbb44f33bbd5bf5c98e7c1d14814b8f183613f63 Reviewed-on: https://chromium-review.googlesource.com/1155090 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#579067} [modify] https://crrev.com/68a979bd87269cf64f1cb228cef5cb997dfb78cc/ios/chrome/browser/ui/ntp/incognito_view.mm
,
Jul 30
,
Jul 30
Let's get canary verification please.
,
Jul 31
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d40e447bf10d82bfc1f23e31e3aabdc7f1a90d28 commit d40e447bf10d82bfc1f23e31e3aabdc7f1a90d28 Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Jul 31 16:09:51 2018 [ios] Removes leading whitespace from the incognito NTP text. The items in the bulleted lists on the NTP are indented with eight leading spaces. This causes issues when text wraps to multiple lines, as the subsequent lines are not indented. Mitigate the impact of this behavior by manually removing the leading whitespace from bulleted list items, so that when text wraps, subsequent lines do not look as bad. BUG= 860500 TEST=The incognito NTP bulleted lists should not be indented. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibbb44f33bbd5bf5c98e7c1d14814b8f183613f63 Reviewed-on: https://chromium-review.googlesource.com/1155090 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579067}(cherry picked from commit 68a979bd87269cf64f1cb228cef5cb997dfb78cc) Reviewed-on: https://chromium-review.googlesource.com/1156944 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#278} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/d40e447bf10d82bfc1f23e31e3aabdc7f1a90d28/ios/chrome/browser/ui/ntp/incognito_view.mm
,
Aug 7
Verified the issue on the build version 70.0.3515.0 canary tested on iPhone 7+(iOS 11.4.1) incognito text gas been changed. Image : https://drive.google.com/file/d/1hDiiGeUHXir4PcFxNSR9tY-rsV3Tavy3/view?usp=sharing
,
Aug 8
Issue verified Version: Chrome Beta 69.0.3497.31 Device: iPhone 8 iOS: 11.4 Text/ lines are aligned changing device language to French https://drive.google.com/open?id=1NbNP8XUA5wojXuTVn4JOWvEn5U75adLl |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by justincohen@chromium.org
, Jul 8Owner: rohitrao@chromium.org