Exp. date formatting on the save card dialog should be controlled by a flag |
||
Issue descriptionWe should add a flag to control expiration date formatting (either "Exp. 18/01" or "18/01") on the save card dialog. The flag should be enabled by default, but we want to be able to A/B test the feature using Finch. This is the implementation bug for crbug.com/860527.
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87552e04abbe541f82c5deff87b3fce96dfe3176 commit 87552e04abbe541f82c5deff87b3fce96dfe3176 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Jul 06 15:43:21 2018 [Save card dialog] Add flag to control expiration date formatting This introduces a flag to control if the expiration date shown on the save card dialog (both local and upstream) includes prefix "Exp:", so we can A/B test if dropping the label has any effect on acceptance ratios for the dialog. Bug: 860493 Change-Id: Ia9f9fccab959e7548b0a4c4143b66eefd742f4c2 Reviewed-on: https://chromium-review.googlesource.com/1127350 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#572979} [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/chrome/browser/about_flags.cc [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/chrome/browser/flag_descriptions.h [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/components/autofill/core/browser/credit_card.cc [modify] https://crrev.com/87552e04abbe541f82c5deff87b3fce96dfe3176/tools/metrics/histograms/enums.xml
,
Jul 9
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b00c31d425e08867ade6a600b32b948c0f717dd7 commit b00c31d425e08867ade6a600b32b948c0f717dd7 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Jul 16 15:38:11 2018 [Save card dialog] Update translation instructions for CC exp. date Bug: 860493 Change-Id: Icf0f6bd8ccc8d8ed8f53ad060dd18f6cafba2824 Reviewed-on: https://chromium-review.googlesource.com/1138185 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#575280} [modify] https://crrev.com/b00c31d425e08867ade6a600b32b948c0f717dd7/components/autofill_strings.grdp |
||
►
Sign in to add a comment |
||
Comment 1 by ftirelo@chromium.org
, Jul 5