New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860490 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2

Blocking:
issue 834345



Sign in to add a comment

Support long-press to paste on steady location bar

Project Member Reported by lod@chromium.org, Jul 5

Issue description

On long press on the unfocused (steady-state) location bar, support following actions: Copy; optionally Paste and Go if there is text content in the clipboard.

 

Comment 1 Deleted

Summary: Support long-press to paste on steady location bar (test) (was: Support long-press to paste on steady location bar)

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97433df55b34cf0f565b773bf44b0c33fe9c5af

commit e97433df55b34cf0f565b773bf44b0c33fe9c5af
Author: Elodie Banel <lod@google.com>
Date: Wed Jul 11 17:48:22 2018

Support long-press to copy and paste on steady location bar

Show the editing menu when long pressing the steady location bar
with elements "Copy" and "Paste and Go". The latter is only shown when
the clipboard contains text content.

Bug:  860490 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifeb7f4206e081b1f92c6066ab5f093edd0343206
Reviewed-on: https://chromium-review.googlesource.com/1127052
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574232}
[modify] https://crrev.com/e97433df55b34cf0f565b773bf44b0c33fe9c5af/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/e97433df55b34cf0f565b773bf44b0c33fe9c5af/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
[modify] https://crrev.com/e97433df55b34cf0f565b773bf44b0c33fe9c5af/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/e97433df55b34cf0f565b773bf44b0c33fe9c5af/ios/chrome/browser/ui/location_bar/location_bar_view_controller.h
[modify] https://crrev.com/e97433df55b34cf0f565b773bf44b0c33fe9c5af/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm

Status: Fixed (was: Started)
Verified in:

App Version: 69.0.3494.0 canary
Devices: iPhone 6 Plus, iPhone X
iOS Versions: 10.3.3, 11.4.1 beta 5

Only "Copy" & "Paste" options are displayed in editing menu when long pressing on location bar instead of "Paste and Go". Please see the screenshot attached.

Copy&Paste.PNG
623 KB View Download
Cc: subhashi...@chromium.org
Status: Verified (was: Fixed)
Screenshot from comment#6 refers to Long tap while editing the omnibox.
But a webpage is opened an longtapped on Location bar, Copy and "Paste and Go" options are displayed. Only Copy option is seen when there is no entry in ClipBoard.

Verified in M69.0.3497.53 beta
iPad Pro, iOS: 11.4.1

Sign in to add a comment