New issue
Advanced search Search tips

Issue 860476 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Jul 17
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Icons overlap with text in DevTools on zoom-in

Reported by khushal....@etouch.net, Jul 5 
Chrome Version : 69.0.3482.0 (Official Build) Revision f55a011c2fd928ccc84df796152c2046a33c8e32-refs/branch-heads/3482@{#1} (32/64-bit)

OS: Windows (7, 10) & Mac (10.12.6, 10.13.1) & Linux (14.04 LTS)

Steps to reproduce:
(1) Launch chrome, open DevTools and go to 'Performance' section.
(2) Click on 'Capture Settings' icon to expand the options.
(3) Now zoom-in DevTools window to extreme and Observe.

Actual Result: Icons overlap with text in DevTools on zoom-in.
Expected Result: Icons should not overlap with text in DevTools on zoom-in.

This is a Regression issue broken in 'M-69' and providing the bisect info below:
Good Build: 69.0.3447.0 (Revision: 563479)
Bad Build:  69.0.3448.0 (Revision: 563958)

You are probably looking for a change made after 563520 (known good), but no later than 563521 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0a643b4cd5ed6be2b661c08e100c6b8310c19e4b..71d2dadf815a92d349500fc9819acb3d749dc39c

Suspect: https://chromium.googlesource.com/chromium/src/+/71d2dadf815a92d349500fc9819acb3d749dc39c

@atotic: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. This issue is resolution specific and reproducible on monitors with display resolution 1366 X 768 and for Linux OS with resolution 800 X 535.
2. Issue is also seen on M-69 Dev (build #69.0.3472.3).

Kindly refer the attached screen cast.

Thank You..!!
Actual Video.mov
3.4 MB View Download
Expected Video.mov
3.4 MB View Download

Comment 1 by atotic@chromium.org, Jul 7

Owner: l...@chromium.org
My CL only rebaselined some LayoutNG tests, so it could not have affected DevTools display.

CL right before mine: https://chromium-review.googlesource.com/c/chromium/src/+/1080036
modified DevTools buttons.
I suspect this caused the regression.

Reassigning to author

Comment 2 by l...@chromium.org, Jul 9

Labels: -Pri-1 Pri-2
Thanks, I will take a look.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4030d08e852df100f4f2d84e96401a797cf28150

commit 4030d08e852df100f4f2d84e96401a797cf28150
Author: Erik Luo <luoe@chromium.org>
Date: Tue Jul 17 03:18:31 2018

DevTools: fix console/timeline toolbar overlap

UI.Toolbars give 'flex: none' to their shadow :host. In [1], an extra
element was placed in between the Toolbar and the flex container,
breaking the 'flex: none'.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1080036

Screenshot: https://imgur.com/a/wyacU7H

Bug:  860476 
Change-Id: If12df76e2bf711c93acee8df5d7f0bbb0a5a868d
Reviewed-on: https://chromium-review.googlesource.com/1139049
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575536}
[modify] https://crrev.com/4030d08e852df100f4f2d84e96401a797cf28150/third_party/blink/renderer/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/4030d08e852df100f4f2d84e96401a797cf28150/third_party/blink/renderer/devtools/front_end/timeline/timelinePanel.css

Comment 4 by l...@chromium.org, Jul 17

Status: Fixed (was: Assigned)

Comment 5 by khushal....@etouch.net, Jul 18

Labels: TE-Verified-M69 TE-Verified-69.0.3495.0
Update:

Rechecked the issue on latest canary version 69.0.3495.0 on Windows (7, 10) & Mac (10.12.6, 10.13.1) & Linux (14.04 LTS) and the issue is found Fixed. Hence, adding respective labels.

Please refer the attached screencast.

Thank You..!!
Fixed Video.mov
3.4 MB View Download
►

Sign in to add a comment