Issue metadata
Sign in to add a comment
|
Regression: Some Manufacturers drop-down entries goes missing in chrome://settings/cupsPrinters |
||||||||||||||||||||||
Issue descriptionChrome Version:69.0.3480.0/10847.0.0 dev channel Jerry,Falco,Gnawty OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Navigate to chrome://settings/cupsPrinters (2)Click on Add printers>> Give some Name and Address, then click on Add (3)In Manufacturers field, type some random text and remove>> observe the drop-down Actual: Some Manufacturers drop-down entries are missing Expected: No such issue should be seen This is a Regression issue as same is working fine in 69.0.3452.0/10773.0.0 dev
,
Jul 6
@scottchen: Can you triage this? Is it related to any cr-input changes?
,
Jul 10
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc commit 1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc Author: Scott Chen <scottchen@chromium.org> Date: Thu Jul 12 19:05:52 2018 Settings: fix cups printer search field logic. An earlier CL (1088163) broke the logic for drop-down search fields in CUPS add/edit printer dialog, by setting the searchTerm_ property to the wrong value. This CL fixes that issue. The aforementioned CL also accidentally notifies the parent of the input value too often, which is also fixed in this CL. Tests are added to prevent both regressions in the future. Bug: 860475 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3949c01edacc53b5aa0f8b6b25ef57b3acb00577 Reviewed-on: https://chromium-review.googlesource.com/1132238 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574659} [modify] https://crrev.com/1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html [modify] https://crrev.com/1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js [modify] https://crrev.com/1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc/chrome/test/data/webui/settings/cups_printer_page_tests.js
,
Jul 16
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kebalaji@chromium.org
, Jul 5