New issue
Advanced search Search tips

Issue 860467 link

Starred by 11 users
Status: Started
Owner:
finnur@chromium.org
Cc:
twelling...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Implement Contacts Picker

Project Member Reported by finnur@chromium.org, Jul 5 
Chrome on Android is lacking the ability for users to provide contact info (from the Android contact list) to web pages. This is problematic, for example, when bootstrapping on a new social network.

This bug keeps track of an effort to experiment with a contacts picker.

PRD and Explainer doc in progress.
Showing comments 19 - 118 of 118 Older ›

Comment 19 Deleted

Comment 20 Deleted

Project Member

Comment 95 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ee8585e3a90c0c6c605182f91c16939b2ddd177

commit 7ee8585e3a90c0c6c605182f91c16939b2ddd177
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Sep 18 11:44:46 2018

Contacts Picker: Improved efficiency, scrolling, Select All, and search.
- Minimize the use of the cursor.
- Load the contact details upfront.
- Keep the ContactDetails in the adapter.
- Improved search: case-insensitive search within all contact details.

Also temporarily disable photos (will be reinstated in a different way).

Bug: 860467
Change-Id: Ia6ddf396bf20d82ae301489a12795d2fad333af8
Reviewed-on: https://chromium-review.googlesource.com/1221551
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592000}
[modify] https://crrev.com/7ee8585e3a90c0c6c605182f91c16939b2ddd177/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactDetails.java
[modify] https://crrev.com/7ee8585e3a90c0c6c605182f91c16939b2ddd177/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerAdapter.java
[modify] https://crrev.com/7ee8585e3a90c0c6c605182f91c16939b2ddd177/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerCategoryView.java
Project Member

Comment 96 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3

commit 5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Sep 26 16:17:38 2018

Contacts Picker: Reintroduce images for contacts.

Images are loaded on a worker thread and stored in an LRU cache,
which is discardable under memory pressure.

Bug: 860467
Change-Id: I5bbd1a3839d22282c1ee3ef2350058d9248f4d2f
Reviewed-on: https://chromium-review.googlesource.com/1243286
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594337}
[modify] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactDetails.java
[modify] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactView.java
[add] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactViewHolder.java
[add] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/FetchIconWorkerTask.java
[modify] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerAdapter.java
[modify] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerCategoryView.java
[modify] https://crrev.com/5d1bd990e4c21787e6371ab8db5b4fd711eaa7c3/chrome/android/java_sources.gni
Project Member

Comment 98 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6604509de15bf27c7b1db66a0b0c77f8d0f166b

commit d6604509de15bf27c7b1db66a0b0c77f8d0f166b
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Oct 03 15:29:20 2018

Contacts Picker: Add test for the dialog.

Bug: 860467
Change-Id: I3173492480955a562415bd8885b6b92fb6cbf5a6
Reviewed-on: https://chromium-review.googlesource.com/c/1256782
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596218}
[modify] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/java/res/layout/contacts_picker_toolbar.xml
[modify] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactViewHolder.java
[modify] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerDialog.java
[modify] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerAdapter.java
[modify] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerCategoryView.java
[modify] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/java_sources.gni
[add] https://crrev.com/d6604509de15bf27c7b1db66a0b0c77f8d0f166b/chrome/android/javatests/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerDialogTest.java
Project Member

Comment 100 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/658449aabf371e0dcc3ff7700db7fb755955fc06

commit 658449aabf371e0dcc3ff7700db7fb755955fc06
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Oct 09 11:18:26 2018

Contacts Picker: Pipe json file through to web page.

Bug: 860467
Change-Id: I79b394ce551a79f478bdc5e82e2c124e93571205
Reviewed-on: https://chromium-review.googlesource.com/c/1206339
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597878}
[modify] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/chrome/browser/BUILD.gn
[modify] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/chrome/browser/file_select_helper.cc
[modify] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/chrome/browser/file_select_helper.h
[add] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/chrome/browser/file_select_helper_contacts_android.cc
[add] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/chrome/browser/file_select_helper_contacts_android.h
[modify] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
[modify] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/ui/shell_dialogs/select_file_dialog_android.cc
[modify] https://crrev.com/658449aabf371e0dcc3ff7700db7fb755955fc06/ui/shell_dialogs/select_file_dialog_android.h
Project Member

Comment 101 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cbb81c493f0c52b64a72d171fd73190a9ca8e3

commit 64cbb81c493f0c52b64a72d171fd73190a9ca8e3
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Oct 09 15:14:19 2018

Contacts & Photo Pickers: Use pre-defined styles for number roll view.

Also deletes an unused file and a TODO that's been resolved.

Bug: 860467,  656015 
Change-Id: I04110075bf309f2013d6b5de02e0d3fa5f5932e6
Reviewed-on: https://chromium-review.googlesource.com/c/1264777
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597919}
[delete] https://crrev.com/9b6626ad9e61b3b7d4344dc9ae80ea28ab116e57/chrome/android/java/res/color/blue_when_enabled.xml
[modify] https://crrev.com/64cbb81c493f0c52b64a72d171fd73190a9ca8e3/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerToolbar.java
[modify] https://crrev.com/64cbb81c493f0c52b64a72d171fd73190a9ca8e3/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PhotoPickerToolbar.java
Project Member

Comment 102 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/669e6b54bf89e6ac090fdde5726de6ae6af89da5

commit 669e6b54bf89e6ac090fdde5726de6ae6af89da5
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Oct 10 09:54:54 2018

Contacts Picker: Fix crash with empty search string.

If you hit Search and immediately go out of search mode with a
blank search string, then -- upon ending search mode -- the code
will try to clear a search results that hasn't been initialized
or already been nulled out.

Bug: 860467
Change-Id: Ieee415bc35c1cbe5987e7618061ec62fa00d1b40
Reviewed-on: https://chromium-review.googlesource.com/c/1270921
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598271}
[modify] https://crrev.com/669e6b54bf89e6ac090fdde5726de6ae6af89da5/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerAdapter.java
[modify] https://crrev.com/669e6b54bf89e6ac090fdde5726de6ae6af89da5/chrome/android/javatests/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerDialogTest.java

Comment 103 by dxie@google.com, Oct 12

Labels: -Pri-2 Proj-Fugu Pri-1
Project Member

Comment 104 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd7f45c897bba76dc79dc64541d2604cd7fadff2

commit dd7f45c897bba76dc79dc64541d2604cd7fadff2
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Oct 16 10:51:55 2018

Contacts Picker: Show contact images as rounded again.

Also fix a couple of comments and make sure all icons are the
same height. We might want to enlarge them all in a future CL,
but they should at least match.

Bug: 860467
Change-Id: I78eb219771a94aa41d7eb312f072ebde8cc65d56
Reviewed-on: https://chromium-review.googlesource.com/c/1280768
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599941}
[modify] https://crrev.com/dd7f45c897bba76dc79dc64541d2604cd7fadff2/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactView.java
[modify] https://crrev.com/dd7f45c897bba76dc79dc64541d2604cd7fadff2/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactViewHolder.java
[modify] https://crrev.com/dd7f45c897bba76dc79dc64541d2604cd7fadff2/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerCategoryView.java

Comment 105 by dxie@google.com, Oct 19

Labels: Target-72
Project Member

Comment 106 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75c28cd0163cf303640ffcb6dedf60e959c0e12a

commit 75c28cd0163cf303640ffcb6dedf60e959c0e12a
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Oct 31 12:12:55 2018

Contacts Picker: Minor tweaks.

- Fix sorting. Use a Sort key that takes into account locale-based
  traditions for sorting names in address books.
- Make sure contact icons are all of equal size.
- Use only single letter for icons without contact images (instead
  of two). Trying to figure out what is the last name requires some
  heuristics.

Bug: 860467
Change-Id: Ib6c03cea6ade5f479d1b46fc2a2164ba55e8ca14
Reviewed-on: https://chromium-review.googlesource.com/c/1307504
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604220}
[modify] https://crrev.com/75c28cd0163cf303640ffcb6dedf60e959c0e12a/chrome/android/java/res/layout/contact_view.xml
[modify] https://crrev.com/75c28cd0163cf303640ffcb6dedf60e959c0e12a/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactView.java
[modify] https://crrev.com/75c28cd0163cf303640ffcb6dedf60e959c0e12a/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactsFetcherWorkerTask.java
[modify] https://crrev.com/75c28cd0163cf303640ffcb6dedf60e959c0e12a/chrome/android/java/src/org/chromium/chrome/browser/widget/RoundedIconGenerator.java
[modify] https://crrev.com/75c28cd0163cf303640ffcb6dedf60e959c0e12a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java

Comment 107 Deleted

Comment 108 by laukst...@gmail.com, Nov 19 

I think this addresses to https://www.chromestatus.com/feature/6511327140904960 and is related to all OSs, not only Android as defined in task.

Comment 109 by finnur@google.com, Nov 19

Components: Blink>Contacts
Project Member

Comment 110 by bugdroid1@chromium.org, Nov 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2

commit 92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Nov 21 11:00:00 2018

Implement navigator.contacts.select()

This provides support for the Contacts Picker API,

 https://github.com/beverloo/contact-api
 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/brKChSa9_d0

allowing contact details to be shared with a web page.

A skeleton select() function is implemented (returns a
DOMException).

BUG: 860467

Change-Id: I7cf4c147271179c0f59a7cd455d88b1b570c9891
Reviewed-on: https://chromium-review.googlesource.com/c/1326501
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609994}
[modify] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/BUILD.gn
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/BUILD.gn
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/DEPS
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/OWNERS
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/README.md
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contact_info.cc
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contact_info.h
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contact_info.idl
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contacts_manager.h
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contacts_manager.idl
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/contacts_select_options.idl
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/navigator_contacts.cc
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/navigator_contacts.h
[add] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/contacts_picker/navigator_contacts.idl
[modify] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/92f8c5b2a2ee02ece1b60500ecf4c60f34ec6ec2/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 112 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b

commit 522d37882df8a41cc3e9bbb591fe8ac5b2f1856b
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Dec 05 02:17:43 2018

Contacts Picker: Plumb the select call into the browser process.

Bug: 860467
Change-Id: I46ef616b643593b9ed7c670eb486694f795bb023
Reviewed-on: https://chromium-review.googlesource.com/c/1349344
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613820}
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSetting.java
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/content/browser/BUILD.gn
[add] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/content/browser/contacts/OWNERS
[add] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/content/browser/contacts/contacts_manager_impl.cc
[add] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/content/browser/contacts/contacts_manager_impl.h
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/public/mojom/contacts/OWNERS
[add] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/public/mojom/contacts/contacts_manager.mojom
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/renderer/modules/contacts_picker/contact_info.cc
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/renderer/modules/contacts_picker/contacts_manager.cc
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/renderer/modules/contacts_picker/contacts_manager.h
[modify] https://crrev.com/522d37882df8a41cc3e9bbb591fe8ac5b2f1856b/third_party/blink/web_tests/http/tests/contacts/select-function.html

Comment 113 by dxie@chromium.org, Dec 6

Labels: -Target-72 M-76 Target-73
finnur, do you have an estimate of this API for Origin Trial? would 73 be reasonable?
Project Member

Comment 114 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae6201ba3291d988ecf896a7294d2b3f47a0062

commit 2ae6201ba3291d988ecf896a7294d2b3f47a0062
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Jan 03 11:38:28 2019

Contacts Picker: Show fewer phone numbers/emails by default.

The UX design calls for showing only one number/email
on-screen, and have the rest show only in details view
(a view that will appear in an upcoming CL).

Bug: 860467
Change-Id: Ifaccdbd89b0fc5041cef7c05e288469032f5e78b
Reviewed-on: https://chromium-review.googlesource.com/c/1393368
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619621}
[modify] https://crrev.com/2ae6201ba3291d988ecf896a7294d2b3f47a0062/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactDetails.java
[modify] https://crrev.com/2ae6201ba3291d988ecf896a7294d2b3f47a0062/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactView.java
[modify] https://crrev.com/2ae6201ba3291d988ecf896a7294d2b3f47a0062/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerAdapter.java
[modify] https://crrev.com/2ae6201ba3291d988ecf896a7294d2b3f47a0062/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/2ae6201ba3291d988ecf896a7294d2b3f47a0062/chrome/android/java/strings/android_chrome_strings_grd/IDS_CONTACTS_PICKER_MORE_DETAILS.png.sha1
Project Member

Comment 116 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d1e64f40c69483844d519d1027233cb383a9817

commit 4d1e64f40c69483844d519d1027233cb383a9817
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Wed Jan 16 01:00:35 2019

Contacts Picker: A sizable UI overhaul.

Sync with the design that passed UI review:
- Remove the Select All/Undo button from toolbar.
- Add sharing disclaimer at top ("what you select will be shared with...").
- Add Select All checkbox as top item in RecyclerView.
- Remove Undo State when undoing Select All (undoing now clears all).
- Remove blue row selection background highlight.
- Show animated checkmark for contacts selected.

Bug: 860467
Change-Id: I78764414aac2397728b86ff761f50f9b3d15bc2f
Reviewed-on: https://chromium-review.googlesource.com/c/1398283
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622954}
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/chrome_modern_public_apk.proguard_flags.expected
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/chrome_public_apk.proguard_flags.expected
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/monochrome_public_apk.proguard_flags.expected
[delete] https://crrev.com/eb7dc7cec8a4b2cc4b8e99e271cd17032735cfe6/chrome/android/java/res/drawable/ic_select_all.xml
[delete] https://crrev.com/eb7dc7cec8a4b2cc4b8e99e271cd17032735cfe6/chrome/android/java/res/drawable/ic_undo.xml
[add] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/res/layout/checkbox_layout.xml
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/res/layout/contact_view.xml
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/res/layout/contacts_picker_toolbar.xml
[add] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/res/layout/top_view.xml
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactView.java
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerAdapter.java
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerCategoryView.java
[add] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/TopView.java
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableItemView.java
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/strings/android_chrome_strings_grd/IDS_CONTACTS_PICKER_ALL_CONTACTS.png.sha1
[add] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java/strings/android_chrome_strings_grd/IDS_DISCLAIMER_SHARING_CONTACT_DETAILS.png.sha1
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/java_sources.gni
[modify] https://crrev.com/4d1e64f40c69483844d519d1027233cb383a9817/chrome/android/javatests/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerDialogTest.java
Project Member

Comment 117 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b172f347bedc5b6400cb92a096269e0b3f1daee

commit 8b172f347bedc5b6400cb92a096269e0b3f1daee
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Jan 17 21:42:53 2019

Contacts Picker: Allow all details to fit in the list view.

Bug: 860467
Change-Id: I40ca64b3562d6a860abd10a8a426aa0bdcbf1294
Reviewed-on: https://chromium-review.googlesource.com/c/1412395
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623860}
[modify] https://crrev.com/8b172f347bedc5b6400cb92a096269e0b3f1daee/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactView.java
Project Member

Comment 118 by bugdroid1@chromium.org, Yesterday (24 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e1e8d1bc314e543f9783550feb53493f60d736

commit d1e1e8d1bc314e543f9783550feb53493f60d736
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Tue Jan 22 10:56:35 2019

Contacts Picker: Implement the JNI communications for the contacts dialog.

TBR: tedchoc, kinuko
Bug: 860467
Change-Id: I4e1715d1635f4461938984b6dd49ba106762cfe7
Reviewed-on: https://chromium-review.googlesource.com/c/1411608
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624755}
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactDetails.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerDialog.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/chrome/android/java/src/org/chromium/chrome/browser/contacts_picker/PickerCategoryView.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/chrome/android/javatests/src/org/chromium/chrome/browser/contacts_picker/ContactsPickerDialogTest.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/BUILD.gn
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/contacts/contacts_manager_impl.cc
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/contacts/contacts_manager_impl.h
[add] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/contacts/contacts_provider.h
[add] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/contacts/contacts_provider_android.cc
[add] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/contacts/contacts_provider_android.h
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/public/android/BUILD.gn
[add] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/content/public/android/java/src/org/chromium/content/browser/ContactsDialogHost.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/ui/android/java/src/org/chromium/ui/ContactsPickerListener.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/ui/android/java/src/org/chromium/ui/UiUtils.java
[modify] https://crrev.com/d1e1e8d1bc314e543f9783550feb53493f60d736/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
Showing comments 19 - 118 of 118 Older ›
►

Sign in to add a comment