Short CL to reproduce the issue https://chromium-review.googlesource.com/c/chromium/src/+/1102421

Suspect of what's happening.

Something builds a ProfileSyncService instance immediately or *very* shortly after on profile creation, which in turn builds an InstanceIDProfileService instance.

All failing test suites hook the InstanceIDProfileServiceFactory in their BrowserTestBase::SetUpOnMainThread() override. That runs just *after* the browser (w/ the profile) is created, which means that per this CL, an instance already exists by the time these tests are trying to hook the creation function.

One thing to try is to set the testing factory hook in SetUp() instead of SetUpOnMainThread().
 

Browser tests crashes when ProfileSyncService instantiates InstanceIDProfileService

Short CL to reproduce the issue https://chromium-review.googlesource.com/c/chromium/src/+/1102421

Suspect of what's happening.

Something builds a ProfileSyncService instance immediately or *very* shortly after on profile creation, which in turn builds an InstanceIDProfileService instance.

All failing test suites hook the InstanceIDProfileServiceFactory in their BrowserTestBase::SetUpOnMainThread() override. That runs just *after* the browser (w/ the profile) is created, which means that per this CL, an instance already exists by the time these tests are trying to hook the creation function.

One thing to try is to set the testing factory hook in SetUp() instead of SetUpOnMainThread().
 

Browser tests crashes when ProfileSyncService instantiates InstanceIDProfileService

Short CL to reproduce the issue https://chromium-review.googlesource.com/c/chromium/src/+/1102421

Suspect of what's happening.

Something builds a ProfileSyncService instance immediately or *very* shortly after on profile creation, which in turn builds an InstanceIDProfileService instance.

All failing test suites hook the InstanceIDProfileServiceFactory in their BrowserTestBase::SetUpOnMainThread() override. That runs just *after* the browser (w/ the profile) is created, which means that per this CL, an instance already exists by the time these tests are trying to hook the creation function.

One thing to try is to set the testing factory hook in SetUp() instead of SetUpOnMainThread().