[MdRefresh]: Mirrored Profile icon is seen on toolbar when Force UI diection is set to RTL |
||||||
Issue descriptionChrome Version:69.0.3481.0 OS: Win10, Mac OS 10.13.3, Debian Pre-Condition:Enable Force UI direction flag to "Right to Left" from chrome://flags What steps will reproduce the problem? (1) Launch chrome and observe profile icon on toolbar Expected: Profile icon should be as it is. Actual: Mirrored image is seen when UI is set to RTL. NOTE: Issue is seen in M-68 and M-69
,
Jul 9
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67dfce1fde18a82e97527ad3c755b2e9ea720d07 commit 67dfce1fde18a82e97527ad3c755b2e9ea720d07 Author: Peter Boström <pbos@chromium.org> Date: Tue Jul 10 15:59:28 2018 Add AvatarToolbarButton error states Adds an error label and corresponding styling to AvatarToolbarButton to signal error and paused states. This is done through the following changes: * Turn ToolbarButton from an ImageButton to LabelButton. After turning RTL flipping on by default this has no visual impact on buttons that do not use the label text but allows AvatarToolbarButton to use a label. * Style ToolbarButton for text by using the same label-to-image spacing as bookmarks. Increase left insets when text is visible. * Add highlight-color support to ToolbarButton. For AvatarToolbarButton this is currently used as red for sync errors and blue for paused. When set, this color is permanently painted with low opacity as the ToolbarButton background. It's also used as the inkdrop base color. * Add inset support to SolidRoundRectPainter. This is required to match the inkdrop shapes which are inset from the view edges. This is done so that ToolbarButtons are larger than their visible size on ChromeOS touch devices to provide larger hit targets that are easier to hit. This change also makes several AvatarToolbarButton getters const by turning AvatarButtonController::HasAvatarError() const. This change also fixes a RTL issue where the avatar image was flipped. Bug: chromium:851530 , chromium:860416 Change-Id: I06ee5eeb55d5b19cd57bb7b8445f05ead4ff1216 Reviewed-on: https://chromium-review.googlesource.com/1123172 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#573752} [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/app/profiles_strings.grdp [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/avatar_button_error_controller.h [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/profiles/avatar_toolbar_button.h [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_button.h [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/ui/views/painter.cc [modify] https://crrev.com/67dfce1fde18a82e97527ad3c755b2e9ea720d07/ui/views/painter.h
,
Jul 10
Triage: fixed?
,
Jul 10
Issue 856590 has been merged into this issue.
,
Jul 10
,
Jul 11
Able to reproduce this issue on reported version hence verifying the fix on latest canary 69.0.3488.0 using Windows 10, Mac 10.13.3 and Debian. Now not observing any flip of avatar bubble. Attaching screenshot for reference. As fix is working as expected adding TE-Verified labels. Thanks!
,
Jul 11
Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sindhu.chelamcherla@chromium.org
, Jul 54.5 KB
4.5 KB View Download
56.8 KB
56.8 KB View Download