pschaffner@ Do you want this animation changed or is this WAI?

This isn't great. justincohen@ do you think you could manage a logic that auto-scrolls the scrollview at a certain offset? To see what I mean, play with scrolling the searchbar on the root VC in Settings.app in to/out of view to see how it snaps two the two position (or see the attached video). I imagine a similar technique could be used here and somewhat alleviate the weird dual state.

If this would be non-trivial to do before 69, we can change the priority to <1.

Deleted: scrollview_snappy_scrolling.mov 9.7 MB

	scrollview_snappy_scrolling.mov 9.7 MB View Download

There was an error in calculating the fake omnibox scroll animation (https://chromium-review.googlesource.com/c/chromium/src/+/1138347) so the progress doesn't start until the fake omnibox starts scrolling underneath the toolbar.  You can still see 2 omniboxes, but it happens much more cleanly.

pschaffner@, I don't know what `auto-scrolls the scrollview at a certain offset` means or what you are suggesting from that video.

I attached a video of what crrev.com/c/1138347 will look like assuming it lands as-is.  WDYT?

Deleted: 860414.mov 619 KB

	860414.mov 619 KB View Download

What you've implemented looks good to me for 69.

I will open a new bug for the "auto-scrolling" behavior for post-69 and try to do a better job of explaining what I want.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/829dc7dccae21bd3e669a300b85e064551078ee9

commit 829dc7dccae21bd3e669a300b85e064551078ee9
Author: Justin Cohen <justincohen@google.com>
Date: Tue Jul 17 18:36:38 2018

[ios] Image and styling tweaks to NTP.

 - Update most visited and search icon image.
 - Change hint text to go from 17pt to +.15 scale
 - Center hint text.
 - Make fake omnibox pill-like.
 - Tweak omnibox fade on RxR.

Bug:  857433 ,  854093 ,  860414 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie236f03daf20b074cb4b4382b3c70e79fc9eca9f
Reviewed-on: https://chromium-review.googlesource.com/1138347
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575731}
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/ntp_bookmarks_icon.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/ntp_bookmarks_icon@2x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_bookmarks_icon.imageset/ntp_bookmarks_icon@3x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/ntp_history_icon.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/ntp_history_icon@2x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_history_icon.imageset/ntp_history_icon@3x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/ntp_readinglist_icon.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/ntp_readinglist_icon@2x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_readinglist_icon.imageset/ntp_readinglist_icon@3x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/ntp_recent_icon.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/ntp_recent_icon@2x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/cells/resources/ntp_recent_icon.imageset/ntp_recent_icon@3x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.mm
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/ntp_search_icon.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/ntp_search_icon@2x.png
[modify] https://crrev.com/829dc7dccae21bd3e669a300b85e064551078ee9/ios/chrome/browser/ui/content_suggestions/resources/ntp_search_icon.imageset/ntp_search_icon@3x.png

Per #c10 marking Fixed.

Behavior matches with the video attached in comment#9.
Verified in iPad Pro, iOS11.4.1, M69.0.3497.53 beta