New issue
Advanced search Search tips

Issue 860403 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task


Sign in to add a comment

[Meta] Onion-soupify content/renderer Loader code

Project Member Reported by kinuko@chromium.org, Jul 5

Issue description

Thought that it could be good to have a meta bug so that all misc changes change can be also associated with this one. Some particular bigger items:

- WebURLLoaderFactory and WebURLLoader classes should probably go away in favor of mojom::URLLoader{Factory}, while there are some non-trivial differences. E.g. sync abstraction must be moved into blink side, deferLoading logic needs to be sorted out (we have mojom::URLLoader::{Pause,Resume}ReadingFromNet but works only for Net)

- WebURL{Request,Response} should be refactored/merged into blink::Resource{Request,Response} (e.g.  issue 770624)

- RenderFrameImpl and WorkerFetchContextImpl's loader related hooks like WillSendRequest should be moved into FetchContext (e.g. issue 751427)

- content::(Associated)ResourceFetcher consumers could be probably migrated over SimpleURLLoader and CORSURLLoader (issue 775402)
 
WebAssociatedURLLoader is used by //media/blink code to load media data.  Not yet sure how //media/blink code should look after onion-soup is done.  (The code path doesn't go through content/renderer code path so we can put it off for now)

Comment 2 Deleted

Sorry, had some correction... (deleted comment 2 to avoid confusion)

1. Replace WebURLError with { network::CompletionStatus, GURL failing_error } (can be passed over as std::pair or a struct)
2. Replace WebURLResponse with network::ResourceResponse
3. Deprecate content::RequestPeer::OnReceivedData() in favor of content::RequestPeer::OnStartLoadingResponseBody()
4. Replace WebURLRequest with network::ResourceRequest. WebURLRequest::ExtraData would need to be passed around separately.
5. Make network::ResourceResponse a mojo / non-native type and add a typemap for blink::ResourceResource
6. Make network::ResourceRequest a mojo / non-native type and add a typemap for blink::ResourceRequest

(More steps need to follow, but doing all these alone would still improve code health a lot)
I did some investigations around network::ResourceRequest, and want to confirm:
  - Making ResourceRequest a mojo / non-native struct then making it typemapped with network::ResourceRequest for Chromium variant, I think it's fine because existing codes are already using such mapping via mojom [Native] syntax.
    But for Blink variant, why do we bother to typemap it with blink::ResourceRequest? It seems to me in the future we can use the generated struct directly when we have some Mojo interfaces sending/receiving ResourceRequest inside Blink. By my understanding, if blink::RR content is so close enough to typemap with the mojom one, ultimately we'd replace it with the mojom one everywhere, otherwise we'd keep these 2 structs separately with different usages.
  - IIUC step 6 does not depend on the previous 5 steps, right?
Cc: leon....@intel.com
Cc: richard...@intel.com kinuko@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ad26ad8086df04cffc98b1c5b43752a47e8b06

commit 69ad26ad8086df04cffc98b1c5b43752a47e8b06
Author: Leon Han <leon.han@intel.com>
Date: Wed Nov 28 07:29:43 2018

[OnionSoup] Replace blink::ReferrerPolicy with network::mojom::ReferrerPolicy

This CL tries to unify the definition of referrer policy enum, removing
blink::ReferrerPolicy by replacing it with
network::mojom::ReferrerPolicy everywhere inside Blink.

BUG=860403

Change-Id: Ia14a116facf2f8a1901a9c8ea6e4fdc960aa6ae5
Reviewed-on: https://chromium-review.googlesource.com/c/1347779
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611587}
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/bindings/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/bindings/core/v8/referrer_script_info.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/bindings/core/v8/referrer_script_info.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/bindings/core/v8/referrer_script_info_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/css/parser/css_parser_context.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/css/parser/css_parser_context.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/css/selector_query_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/dom/document_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/execution_context/execution_context.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/execution_context/execution_context.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/exported/web_document.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/exported/web_history_item.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/exported/web_security_policy.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/fetch/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/fetch/fetch_request_data.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/fetch/fetch_request_data.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/fetch/request.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_frame_owner_element.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_frame_owner_element.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_iframe_element.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_iframe_element.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_image_element.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_image_element.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/imports/link_import.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/link_style.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/css_preload_scanner.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/html_preload_scanner.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/html_preload_scanner_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/html_resource_preloader_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/html/parser/preload_request.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/image_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/image_loader.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/link_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/link_loader.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/link_loader_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/ping_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/private/prerender_handle.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/resource/css_style_sheet_resource.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/loader/resource/css_style_sheet_resource.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/page/context_menu_controller.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/page/create_window.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/dedicated_worker.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/dedicated_worker.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/dedicated_worker_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/experimental/thread_pool.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/global_scope_creation_params.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/global_scope_creation_params.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/worker_thread_test.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/core/workers/worker_thread_test_helper.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/modules/cache_storage/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/modules/cookie_store/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/modules/service_worker/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/modules/websockets/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/exported/web_prerender.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/exported/web_service_worker_request.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/exported/web_url_request.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/resource_request.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/resource_request.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/fetch/script_fetch_options.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/mojo/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/prerender.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/weborigin/DEPS
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/weborigin/referrer.h
[delete] https://crrev.com/3b1e936d9eb9ec71a2253f6b7688efcd7b1cec22/third_party/blink/renderer/platform/weborigin/referrer_policy.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/weborigin/security_policy.cc
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/weborigin/security_policy.h
[modify] https://crrev.com/69ad26ad8086df04cffc98b1c5b43752a47e8b06/third_party/blink/renderer/platform/weborigin/security_policy_test.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f2dea052bfddad8bed08fddc5de541e1f55f7eb

commit 7f2dea052bfddad8bed08fddc5de541e1f55f7eb
Author: Leon Han <leon.han@intel.com>
Date: Wed Dec 19 00:31:20 2018

Make net::URLRequest::MAX_REFERRER_POLICY point to the real max value

net::URLRequest::MAX_REFERRER_POLICY should point to the real max value
net::URLRequest::NO_REFERRER rather than being a new value itself.

BUG=860403

Change-Id: I7487ed43ec9100c0fd50a01144148d2ae38c5d44
Reviewed-on: https://chromium-review.googlesource.com/c/1382011
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#617687}
[modify] https://crrev.com/7f2dea052bfddad8bed08fddc5de541e1f55f7eb/content/public/common/referrer.cc
[modify] https://crrev.com/7f2dea052bfddad8bed08fddc5de541e1f55f7eb/ios/web/public/referrer_util_unittest.cc
[modify] https://crrev.com/7f2dea052bfddad8bed08fddc5de541e1f55f7eb/net/url_request/url_request.h
[modify] https://crrev.com/7f2dea052bfddad8bed08fddc5de541e1f55f7eb/net/url_request/url_request_job.cc
[modify] https://crrev.com/7f2dea052bfddad8bed08fddc5de541e1f55f7eb/services/network/public/cpp/net_ipc_param_traits.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9278acaca70fd85c7000969f5ecfec33a4badc17

commit 9278acaca70fd85c7000969f5ecfec33a4badc17
Author: Leon Han <leon.han@intel.com>
Date: Mon Jan 14 02:48:40 2019

[OnionSoup] Create mojom traits for typemapping network.mojom.URLRequest

This CL makes network.mojom.URLRequest not a [Native] mojom struct:
  - define all its fields well.
  - create the mojom struct traits for keeping its typemap to
    network::ResourceRequest.
  - the legacy IPC struct traits of network::ResourceRequest becomes
    useless, remove it.

This makes network.mojom.URLRequest no more than a mirror of
network::ResourceRequest, by defining each field as almost the same type
with the mirror filed in network::ResourceRequest, this is not the final
definition but a start point for refining, which may happen in the
future when we create the typemap to blink::ResourceRequest for Blink
variant.

The future plan would be:
 - make network.mojom.URLRequestBody not a [Native] one, keeping its
   typemap to network::ResourceRequestBody.
 - for Blink variant create a typemap to blink::EncodedFormData for
   network.mojom.URLRequestBody.
 - for Blink variant create a typemap to blink::ResourceRequest for
   network.mojom.URLRequest.

BUG=860403

Change-Id: I4b962cd42d093d3f03070a2eeb197dabfcbd9d01
Reviewed-on: https://chromium-review.googlesource.com/c/1381735
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622375}
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/http_request_headers.typemap
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/http_request_headers_mojom_traits.h
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/resource_request.cc
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/url_request.typemap
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/url_request_mojom_traits.cc
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/url_request_mojom_traits.h
[add] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/cpp/url_request_mojom_traits_unittest.cc
[modify] https://crrev.com/9278acaca70fd85c7000969f5ecfec33a4badc17/services/network/public/mojom/url_loader.mojom

I think this caused a compile error on 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel

Excerpt from
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8924362314416941424/+/steps/compile/0/stdout :

[32474/69319] STAMP obj/third_party/blink/public/blink_android_mojo_bindings_shared.stamp
[32475/69319] CXX obj/services/network/public/cpp/cpp_base/url_request_mojom_traits.o
FAILED: obj/services/network/public/cpp/cpp_base/url_request_mojom_traits.o 
/b/swarming/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/services/network/public/cpp/cpp_base/url_request_mojom_traits.o.d -DIS_NETWORK_CPP_BASE_IMPL -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -DCR_CLANG_REVISION=\"350768-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -DCR_LIBCXX_REVISION=349080 -DCR_LIBCXXABI_REVISION=347903 -D_LIBCPP_ABI_UNSTABLE -D_LIBCPP_ENABLE_NODISCARD -DCR_SYSROOT_HASH=e7c53f04bd88d29d075bfd1f62b073aeb69cbe09 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DENABLE_IPC_FUZZER -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -Igen/third_party/webrtc -I../../third_party/abseil-cpp -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -fcomplete-member-pointers -m64 -march=x86-64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/glib-2.0 -isystem../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wno-shorten-64-to-32 -Wno-header-guard -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nss -isystem../../build/linux/debian_sid_amd64-sysroot/usr/include/nspr -std=c++14 -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../services/network/public/cpp/url_request_mojom_traits.cc -o obj/services/network/public/cpp/cpp_base/url_request_mojom_traits.o
In file included from ../../services/network/public/cpp/url_request_mojom_traits.cc:11:
../../url/mojom/origin_mojom_traits.h:11:10: fatal error: 'url/mojom/origin.mojom.h' file not found
#include "url/mojom/origin.mojom.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[32476/69319] LINK ./net_dns_response_fuzzer
I just realized that this was submitted just very recently so I should have reverted the CL. However, now I have created a fix. https://chromium-review.googlesource.com/c/chromium/src/+/1409015

I'll TBR kinuko@
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dab46313f1b41e8cd591d2c0e5e610a8c7f3afbc

commit dab46313f1b41e8cd591d2c0e5e610a8c7f3afbc
Author: Dominic Battre <battre@chromium.org>
Date: Mon Jan 14 13:02:57 2019

Add dependency to fix compilation

http://crrev.com/9278aca introduced an include for url/mojom/origin.mojom.h.
This CL adds the necessary build dependency.

TBR=kinuko@chromium.org

Bug: 860403
Change-Id: Ic0300665fc97b4f1416d0f6fee04528fc17eb654
Reviewed-on: https://chromium-review.googlesource.com/c/1409015
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622435}
[modify] https://crrev.com/dab46313f1b41e8cd591d2c0e5e610a8c7f3afbc/services/network/public/cpp/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b32f46e421683240c8cede7069940cc909c2145

commit 2b32f46e421683240c8cede7069940cc909c2145
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Jan 14 17:12:36 2019

Reduce the size of execution_context.h

execution_context.h is used in 4400+ compilation units. This reduces
its pre-processed size by ~1.1M.

The referrer_policy.mojom-shared.h include was added by
https://crrev.com/611587.

Bug: 242216, 860403
Change-Id: I5cdcbf17f05a6b121672f7fa9263f098a6450ee5
Reviewed-on: https://chromium-review.googlesource.com/c/1408970
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#622488}
[modify] https://crrev.com/2b32f46e421683240c8cede7069940cc909c2145/third_party/blink/renderer/core/execution_context/execution_context.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f586ef701ff4fdc6f225c15fd7d6b92340031b6

commit 2f586ef701ff4fdc6f225c15fd7d6b92340031b6
Author: Richard Li <richard.li@intel.com>
Date: Thu Jan 17 05:30:37 2019

[OnionSoup] replace network::DataElement::Type with DataElementType

This CL defines a new mojom enum network.mojom.DataElementType to
replace network::DataElement::Type.

In the future, network::ResourceRequestBody will be typemapped with
network.mojom.URLRequestBody with every field defined in specific forms.
This CL is one of preparation works for building typemapping.

TBR=mkwst@chromium.org

Change-Id: I06991e47ce19947a63a633b355856bd1992905c0
Bug: 860403
Reviewed-on: https://chromium-review.googlesource.com/c/1393106
Commit-Queue: Richard Li <richard.li@intel.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#623596}
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/child_process_security_policy_impl.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/loader/upload_data_stream_builder.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/service_worker/service_worker_navigation_loader.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/speech/speech_recognition_engine_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/browser/speech/speech_recognizer_impl_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/common/page_state_serialization.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/common/page_state_serialization_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/extensions/browser/api/web_request/web_request_info.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/image_annotation/annotator_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/data_element.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/data_element.h
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/network_ipc_param_traits.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/resource_request_body.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/resource_request_body.h
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/cpp/simple_url_loader_unittest.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/public/mojom/url_loader.mojom
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/test/test_utils.cc
[modify] https://crrev.com/2f586ef701ff4fdc6f225c15fd7d6b92340031b6/services/network/url_loader.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 17 (6 days ago)

Sign in to add a comment