New issue
Advanced search Search tips

Issue 860391 link

Starred by 4 users
Status: Verified
Owner:
kevers@chromium.org
Closed: Jan 3
Cc:
smcgruer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocking:
issue 918952



Sign in to add a comment

CSS Animation: new semantics for transform interpolation

Project Member Reported by ericwilligers@chromium.org, Jul 5 
Discussed in this week's CSS WG meeting:
https://github.com/w3c/csswg-drafts/issues/927

The agreed behavior for interpolation between transform lists:
RESOLVED: pad the shorter one with identity functions, find the common prefix, interpolate common prefix pairwise, interpolate the rest matrix-wise.

There should be no change in behavior when the 'from' and 'to' transform lists have the same lengths and all the transform function types match.

Comment 1 by majidvp@chromium.org, Jul 5

Cc: smcgruer@chromium.org
Labels: Hotlist-Interop
Status: Available (was: Untriaged)

Comment 2 by kevers@chromium.org, Dec 3

Owner: kevers@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3038d348f38e5917fc7bea5a7bcc785f51f8d477

commit 3038d348f38e5917fc7bea5a7bcc785f51f8d477
Author: Kevin Ellis <kevers@chromium.org>
Date: Thu Jan 03 16:59:38 2019

Update transform list interpolation.

Update interpolation of transform lists to reflect recent changes to the spec (https://drafts.csswg.org/css-transforms/#interpolation-of-transforms).

* If the transform lists are of different lengths, but the transformations are pairwise compatible to the end of the shorter list, extend the shorter list with corresponding identity transforms.
* If the transform lists are incompatible, perform pairwise transforms for compatible entities at the start of the list and fallback to matrix interpolation for the remaining transformations.
* Fix discrete fallback.

Bug:  860391 ,  267348 ,  918643 

Change-Id: I8b2d770e354f3d77dad00e088a2eafe6c1ad655a
Reviewed-on: https://chromium-review.googlesource.com/c/1372025
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619661}
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/cc/animation/transform_operations.cc
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/cc/animation/transform_operations.h
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/cc/animation/transform_operations_unittest.cc
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/renderer/platform/transforms/interpolated_transform_operation.cc
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/renderer/platform/transforms/interpolated_transform_operation.h
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/renderer/platform/transforms/matrix_3d_transform_operation.cc
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/renderer/platform/transforms/matrix_transform_operation.cc
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/renderer/platform/transforms/transform_operations.cc
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/renderer/platform/transforms/transform_operations.h
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/composition/transform-composition.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/interpolation/transform-interpolation-003.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/interpolation/transform-interpolation-004.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/interpolation/webkit-transform-interpolation-003.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/interpolation/webkit-transform-interpolation-004.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/rotate-transform-equivalent.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/animations/transform-post-multiplication.html
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/external/wpt/css/css-transforms/animation/list-interpolation-expected.txt
[modify] https://crrev.com/3038d348f38e5917fc7bea5a7bcc785f51f8d477/third_party/blink/web_tests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt

Comment 4 by kevers@chromium.org, Jan 3

Status: Verified (was: Assigned)

Comment 5 by kbr@chromium.org, Jan 3

Blocking: 918952
►

Sign in to add a comment