New issue
Advanced search Search tips

Issue 860380 link

Starred by 1 user
Status: Fixed
Owner:
bashi@chromium.org
Closed: Jul 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 860361



Sign in to add a comment

ServiceWorkerProviderHostTest.AllowsServiceWorker fails with S13nSW

Project Member Reported by falken@chromium.org, Jul 5 
ServiceWorkerProviderHostTest.AllowsServiceWorker fails with S13nSW.

[56767:56767:0705/110824.605490:2070645457540:FATAL:service_worker_script_loader_factory.cc(28)] Check failed: loader_factory_.
#0 0x7fe8ac5999dc base::debug::StackTrace::StackTrace()
#1 0x7fe8ac4c61cb logging::LogMessage::~LogMessage()
#2 0x7fe8aa8f00f6 content::ServiceWorkerScriptLoaderFactory::ServiceWorkerScriptLoaderFactory()
#3 0x7fe8aa8d3b70 content::ServiceWorkerProviderHost::CompleteStartWorkerPreparation()
#4 0x000001a7c7f0 content::CreateProviderHostForServiceWorkerContext()
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9e8349e76dc711f9e67e182568d3bc7add8182

commit 1d9e8349e76dc711f9e67e182568d3bc7add8182
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Mon Jul 09 09:10:03 2018

service worker: Add a mock SharedURLLoaderFactory in test utils

In some unit tests we need a ServiceWorkerScriptLoaderFactory, which
requires a SharedURLLoaderFactory. This CL adds a mock
SharedURLLoaderFactory. For now the factory always fails to start
because the current unit tests don't require the factory to work.

This makes ServiceWorkerProviderHostTest.AllowsServiceWorker pass.

Bug:  860380 
Change-Id: I5063748b241c971576be7b76f670a129f4c7857b
Reviewed-on: https://chromium-review.googlesource.com/1128692
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573248}
[modify] https://crrev.com/1d9e8349e76dc711f9e67e182568d3bc7add8182/content/browser/service_worker/service_worker_provider_host_unittest.cc
[modify] https://crrev.com/1d9e8349e76dc711f9e67e182568d3bc7add8182/content/browser/service_worker/service_worker_test_utils.cc

Comment 2 by bashi@chromium.org, Jul 13

Owner: bashi@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment