New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860378 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Pressing Enter key of HW layout fails to submit candidate.

Project Member Reported by xiulingw@chromium.org, Jul 5

Issue description

Version 69.0.3480.0(Official build) canary (32-bit)
Platform 10845.0.0(official build) canary-channel kevin
Firmware Google_Kevin.8785.264.0


REPRO STEPS:
1.Switch to any Keyboard, e.g. US.
2.Switch to HW layout.
3.Type something to make candidates display.
4.Touch the Enter key.


Actual result:
No any candidate is submitted, only cursor jumps to the next line.

Expected:
The default high-lighted candidate is submitted.

 
Jul 5 2018 11_13 AM.webm
170 KB View Download
Cc: wuyingbing@chromium.org
Owner: shend@chromium.org
I can have a look
Owner: wuyingbing@chromium.org
Hmm, I'm not quite sure how to do this. I'm guessing we'll need to overload the IME_ACTION code to submit the top candidate when in handwriting mode?
Labels: -Type-Bug Type-Feature
Darren,
I change the bug to feature request.
We need to discuss later.
Whether to implement in this way.
Since we already support press space to commit the first candidate.
Space bar is bigger than enter key.

Cc: iloahz@chromium.org
 Issue 831465  has been merged into this issue.
Components: -UI>Input>Text>IME UI>Input>VirtualKeyboard
I think this actually is properly classified as a bug -- the enter key is there and clearly marked in BLUE, so we should either remove the enter key or make it submit the text.  

What are our options for addressing it?
Labels: -Type-Feature Type-Bug
It definitely got me a few times, especially when doing searches on the omnibox (write a word and press enter, oops!). I guess we have two options:

1) Make it commit the top candidate. When doing a search query you have to press enter again to actual search.

2) Make it commit the top candidate AND press enter.

What does GBoard do?
Gboard does #2
I like #2
Status: Started (was: Assigned)
Let's follow gboard
Labels: -M-69
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified fixed on the latest version: 72.0.3582.0, 11171.0.0 canary-channel kevin.

Sign in to add a comment