New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860370 link

Starred by 0 users
Status: Untriaged
Owner: ----
Cc:
yyushkina@chromium.org
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Deprecate SearchBox::CheckIsUserSignedInToChromeAs

Project Member Reported by ramyan@chromium.org, Jul 5 
This is part of the EmbeddedSearch API, but doesn't actually seem to be used anywhere, afaict.

https://cs.chromium.org/chromium/src/chrome/renderer/searchbox/searchbox_extension.cc?type=cs&sq=package:chromium&g=0&l=617

https://cs.chromium.org/search/?q=checkIsUserSignedIntoChromeAs&type=cs

It's currently not documented / advertised in https://www.chromium.org/embeddedsearch.

Perhaps some use of IdentityManager::GetPrimaryAccountInfo() and SigninManagerBase::IsAuthenticated() would be the better alternative?

Comment 1 by treib@chromium.org, Jul 5 

I believe it's still used by the remote NTP.

I did do a cleanup pass on the embeddedSearch API a while back. Unless I missed something, everything that's still there should be used *somewhere*.

Comment 2 by ramyan@chromium.org, Jul 5 

Ah, good call, I didn't run a search there.

Is there a documented process for deprecating things in the embeddedSearch API?

Comment 3 by treib@chromium.org, Jul 5 

Not that I'm aware, no.

This particular API was never documented publicly though, and I'm pretty sure none of the third-party NTPs use it. So once the Google remote NTP doesn't use it anymore, it should be fine to just remove.

Comment 4 by ramyan@chromium.org, Jul 5

Labels: RemoteNTP
Sounds good, thanks!
►

Sign in to add a comment