Pass content_unittests when NetS13nSW is on. |
||||||
Issue descriptionIn order to enable NetS13nSW by default, we'll need to make the unit tests pass. I'm not sure it's worth it to make parameterized tests, or just locally ensure they pass when the flag is enabled. But right now we fail many tests because starting a worker fails, since NetworkFactory isn't set.
,
Jul 5
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dd38fabc2b2f8b6f99af90972b8270e2b500c26 commit 3dd38fabc2b2f8b6f99af90972b8270e2b500c26 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Jul 05 04:19:20 2018 service worker: Enable some unit tests with S13nSW flag. Many unit tests fail because they try to start a service worker, which fails if there the URLLoaderGetter/NetworkFactory hasn't been set up. The tests for ServiceWorkerNavigationLoader and ServiceWorkerNewScriptLoader set it up manually, so move the setup to EmbeddedWorkerTestHelper. This adds parameterized tests to EmbeddedWorkerInstance to add test coverage. I don't think we need to add parametrized tests everywhere, but it's a step toward being able to enable the flag by default. Bug: 860361 Change-Id: I2efaa93d21571c795fc15145d65ccc2cf392d4f0 Reviewed-on: https://chromium-review.googlesource.com/1126597 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#572703} [modify] https://crrev.com/3dd38fabc2b2f8b6f99af90972b8270e2b500c26/content/browser/service_worker/embedded_worker_instance.h [modify] https://crrev.com/3dd38fabc2b2f8b6f99af90972b8270e2b500c26/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/3dd38fabc2b2f8b6f99af90972b8270e2b500c26/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/3dd38fabc2b2f8b6f99af90972b8270e2b500c26/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/3dd38fabc2b2f8b6f99af90972b8270e2b500c26/content/browser/service_worker/service_worker_navigation_loader_unittest.cc [modify] https://crrev.com/3dd38fabc2b2f8b6f99af90972b8270e2b500c26/content/browser/service_worker/service_worker_new_script_loader_unittest.cc
,
Jul 6
Leaving this as umbrella bug.
,
Jul 9
Observed 9 failures and 73 crashes when I ran content_unittests on my Linux machine with ServiceWorkerServicification flag. 9 tests failed: ServiceWorkerActivationTest.NoInflightRequest ServiceWorkerMetricsTest.ActivatedWorkerPreparation ServiceWorkerRequestHandlerTest.InitializeHandler_HTTPS_MAIN_FRAME ServiceWorkerRequestHandlerTest.InitializeHandler_HTTPS_OPTIONS ServiceWorkerRequestHandlerTest.InitializeHandler_HTTPS_SKIP ServiceWorkerRequestHandlerTest.InitializeHandler_HTTPS_SUB_FRAME ServiceWorkerRequestHandlerTest.InitializeHandler_HTTP_MAIN_FRAME ServiceWorkerRequestHandlerTest.InitializeHandler_HTTP_SUB_FRAME ServiceWorkerTimeoutTimerTest.NonS13nServiceWorker 73 tests crashed: ServiceWorkerActivationTest.SkipWaitingWithInflightRequest ServiceWorkerContextRequestHandlerTest.ErrorCases ServiceWorkerContextRequestHandlerTest.Incumbent ServiceWorkerContextRequestHandlerTest.InstalledWorker ServiceWorkerContextRequestHandlerTest.NewWorker ServiceWorkerContextRequestHandlerTest.ServiceWorkerDataRequestAnnotation ServiceWorkerContextRequestHandlerTest.SkipServiceWorkerForServiceWorkerRequest ServiceWorkerContextRequestHandlerTest.UpdateAfter24Hours ServiceWorkerContextRequestHandlerTest.UpdateAfter24HoursWithUpdateViaCacheAll ServiceWorkerContextRequestHandlerTest.UpdateAfter24HoursWithUpdateViaCacheNone ServiceWorkerContextRequestHandlerTest.UpdateBefore24Hours ServiceWorkerContextRequestHandlerTest.UpdateBefore24HoursWithUpdateViaCacheAll ServiceWorkerContextRequestHandlerTest.UpdateBefore24HoursWithUpdateViaCacheNone ServiceWorkerContextRequestHandlerTest.UpdateForceBypassCache ServiceWorkerContextTest.ProviderHostIterator ServiceWorkerNewScriptLoaderTest.AccessedNetwork ServiceWorkerNewScriptLoaderTest.Error_404 ServiceWorkerNewScriptLoaderTest.Error_BadMimeType ServiceWorkerNewScriptLoaderTest.Error_CertificateError ServiceWorkerNewScriptLoaderTest.Error_NoMimeType ServiceWorkerNewScriptLoaderTest.Error_PathRestriction ServiceWorkerNewScriptLoaderTest.Error_Redirect ServiceWorkerNewScriptLoaderTest.Error_RedundantWorker ServiceWorkerNewScriptLoaderTest.ForceBypassCache ServiceWorkerNewScriptLoaderTest.Success ServiceWorkerNewScriptLoaderTest.Success_EmptyBody ServiceWorkerNewScriptLoaderTest.Success_LargeBody ServiceWorkerNewScriptLoaderTest.Success_PathRestriction ServiceWorkerNewScriptLoaderTest.Update ServiceWorkerNewScriptLoaderTest.UpdateViaCache_All ServiceWorkerNewScriptLoaderTest.UpdateViaCache_Imports ServiceWorkerNewScriptLoaderTest.UpdateViaCache_None ServiceWorkerNewScriptLoaderTest.Update_IdenticalScript ServiceWorkerRequestHandlerTest.InitializeForNavigation_ExternalFileScheme ServiceWorkerRequestHandlerTest.InitializeForNavigation_FTP ServiceWorkerRequestHandlerTest.InitializeForNavigation_HTTP ServiceWorkerRequestHandlerTest.InitializeForNavigation_HTTPS ServiceWorkerURLRequestJobTest.BlobResponse ServiceWorkerURLRequestJobTest.CancelRequest ServiceWorkerURLRequestJobTest.DeletedProviderHostOnFetchEvent ServiceWorkerURLRequestJobTest.EarlyResponse ServiceWorkerURLRequestJobTest.FailFetchDispatch ServiceWorkerURLRequestJobTest.FailToActivate_MainResource ServiceWorkerURLRequestJobTest.FailToActivate_Subresource ServiceWorkerURLRequestJobTest.NavPreloadMetrics_NavPreloadFirst_MainFrame ServiceWorkerURLRequestJobTest.NavPreloadMetrics_NavPreloadFirst_SubFrame ServiceWorkerURLRequestJobTest.NavPreloadMetrics_WorkerAlreadyStarted_MainFrame ServiceWorkerURLRequestJobTest.NavPreloadMetrics_WorkerFirst_MainFrame ServiceWorkerURLRequestJobTest.NavPreloadMetrics_WorkerFirst_SubFrame ServiceWorkerURLRequestJobTest.NonExistentBlobUUIDResponse ServiceWorkerURLRequestJobTest.Simple ServiceWorkerURLRequestJobTest.StreamResponse ServiceWorkerURLRequestJobTest.StreamResponseAndCancel ServiceWorkerURLRequestJobTest.StreamResponse_Abort ServiceWorkerURLRequestJobTest.StreamResponse_AbortAfterData ServiceWorkerURLRequestJobTest.StreamResponse_AbortBeforeData ServiceWorkerURLRequestJobTest.StreamResponse_ConsecutiveRead ServiceWorkerURLRequestJobTest.StreamResponse_ConsecutiveReadAndAbort ServiceWorkerWriteToCacheJobTest.CertStatusError ServiceWorkerWriteToCacheJobTest.Error ServiceWorkerWriteToCacheJobTest.FailedWriteHeadersToCache ServiceWorkerWriteToCacheJobTest.InvalidMimeType ServiceWorkerWriteToCacheJobTest.Normal ServiceWorkerWriteToCacheJobTest.SSLCertificateError ServiceWorkerWriteToCacheJobTest.Update_ElongatedScript ServiceWorkerWriteToCacheJobTest.Update_EmptyScript ServiceWorkerWriteToCacheJobTest.Update_SameScript ServiceWorkerWriteToCacheJobTest.Update_SameSizeScript ServiceWorkerWriteToCacheJobTest.Update_TruncatedScript ServiceWorkerWriteToCacheLocalhostTest.CertStatusError ServiceWorkerWriteToCacheLocalhostTest.CertStatusError_AllowInsecureLocalhost ServiceWorkerWriteToCacheLocalhostTest.SSLCertificateError
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daaa437fe271fda8785c74b2230576db17e07331 commit daaa437fe271fda8785c74b2230576db17e07331 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jul 19 06:05:43 2018 S13nSW: Skip ServiceWorkerTimeoutTimerTest.NonS13nServiceWorker We should just do early return when S13nServiceWorker is on because we want to make the flag on by default in the future. Bug: 860361 Change-Id: I241b491f7f49e47b7cbfa5bfaeb1fab1978442db Reviewed-on: https://chromium-review.googlesource.com/1143050 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576389} [modify] https://crrev.com/daaa437fe271fda8785c74b2230576db17e07331/content/renderer/service_worker/service_worker_timeout_timer_unittest.cc
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfed753411f21d5b38cf166df5537695a8c3a94b commit dfed753411f21d5b38cf166df5537695a8c3a94b Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jul 19 06:07:37 2018 S13nSW: Fix ServiceWorkerMetricsTest.ActivatedWorkerPreparation As a comment in ServiceWorkerMetrics::RecordActivatedWorkerPreparationForMainFrame() says[1], we don't record .Time histograms. Skip checks for these histograms when S13nServiceWorker is enabled. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_metrics.cc?l=508&rcl=c796dbc93b6490e94e9b843b1e0ecee3e115d2a3 Bug: 860361 Change-Id: Id0d153eab1e7c7a7102c01bf1945f4b8536b2d9f Reviewed-on: https://chromium-review.googlesource.com/1143047 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576390} [modify] https://crrev.com/dfed753411f21d5b38cf166df5537695a8c3a94b/content/browser/service_worker/service_worker_metrics_unittest.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/271eaf50594eb818c9295dc78d364aea18c82ea8 commit 271eaf50594eb818c9295dc78d364aea18c82ea8 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jul 20 01:50:10 2018 S13nServiceWorker: Skip InitializeHandler tests As a comment in ServiceWorkerRequestHandler::InitializeHandler() says[1], we may call it but do nothing when S13nServiceWorker is enabled. Skip tests for InitializeHandler() when S13nServiceWorker is enabled. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_request_handler.cc?l=232&rcl=e09f67110c9a517c981814b643b69c8de0833aac Bug: 860361 Change-Id: I55afa47c165c33d82b38e9e2b89b153ff8aaffb2 Reviewed-on: https://chromium-review.googlesource.com/1144580 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576753} [modify] https://crrev.com/271eaf50594eb818c9295dc78d364aea18c82ea8/content/browser/service_worker/service_worker_request_handler_unittest.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48437a966eaff8eb841b301449d3fab7ff923653 commit 48437a966eaff8eb841b301449d3fab7ff923653 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jul 20 04:18:31 2018 S13nSW: Make ServiceWorkerActivationTest.NoInflightRequest pass When S13nServiceWorker is on, this test was faiiling because we didn't implement SetIdleTimerDelayToZero() in MockServiceWorker. This resulted in not calling StopWorkerIfIdle() on the first active ServiceWorkerVersion. This CL implements SetIdleTimerDelayToZero() as an empty virtual method in EmbeddedWorkerTestHelper. MockServiceWorker just calls it. Subclasses of the helper implement the method as needed. To make ServiceWorkerActivationTest.NoInflightRequest pass, this CL creates a new subclass of the helper. It implements SetIdleTimerDelayToZero() so that it calls RequestTermination() for the corresponding EmbeddedWorkerInstanceHost. This results in calling ServiceWorkerVersion::StopWorkerIfIdle(). Bug: 860361 Change-Id: Ibd178d5ca1f01e7fddd115296188793fb31edb53 Reviewed-on: https://chromium-review.googlesource.com/1136160 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#576776} [modify] https://crrev.com/48437a966eaff8eb841b301449d3fab7ff923653/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/48437a966eaff8eb841b301449d3fab7ff923653/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/48437a966eaff8eb841b301449d3fab7ff923653/content/browser/service_worker/service_worker_registration_unittest.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a030518e07b1ee5112998fcd3938d704fbeddf6 commit 5a030518e07b1ee5112998fcd3938d704fbeddf6 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jul 20 06:02:31 2018 Add tests ServiceWorkerRequestHandler::InitializeForNavigationNetworkService() Similar to non-S13nServiceWorker tests, just checks if handlers are created (or not created) accordingly. Bug: 860361 Change-Id: I070731dcbe7e5f037453005a2cca8ef462fdf03e Reviewed-on: https://chromium-review.googlesource.com/1144598 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576794} [modify] https://crrev.com/5a030518e07b1ee5112998fcd3938d704fbeddf6/content/browser/service_worker/service_worker_request_handler_unittest.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70da8dedaa24aa523847d504504fdb0e849e9dbd commit 70da8dedaa24aa523847d504504fdb0e849e9dbd Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jul 20 08:41:05 2018 S13nServiceWorker: Skip unittests for ServiceWorkerWriteToCacheJob We don't use it when S13nServiceWorker is enabled. Bug: 860361 Change-Id: I6b38b59d6227d7270b2fcd60c5d018c7c2e7de63 Reviewed-on: https://chromium-review.googlesource.com/1144801 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576812} [modify] https://crrev.com/70da8dedaa24aa523847d504504fdb0e849e9dbd/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8966c05f67582a29aa7091090497334efbde1a03 commit 8966c05f67582a29aa7091090497334efbde1a03 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jul 20 08:59:04 2018 S13nServiceWorker: Reset URLLoaderFactoryGetter's test factory before setting a new factory In URLLoaderFactoryGetter we have a DCHECK which makes sure that we don't override existing |test_factory_|. However EmbeddedWorkerTestHelper needs to override it. To work around this, reset the test factory before setting an actual factory. Bug: 860361 Change-Id: If95e30c449346e35747c4623ab3fa012b3ddf61c Reviewed-on: https://chromium-review.googlesource.com/1144819 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576813} [modify] https://crrev.com/8966c05f67582a29aa7091090497334efbde1a03/content/browser/service_worker/embedded_worker_test_helper.cc
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/514c0abe75c1685e65820130c1612b710094c56b commit 514c0abe75c1685e65820130c1612b710094c56b Author: Kenichi Ishibashi <bashi@chromium.org> Date: Tue Jul 24 06:14:03 2018 S13nServiceWorker: Add tests for ServiceWorkerScriptLoaderFactory This CL adds three tests which basically correspond to ServiceWorkerContextRequestHandlerTest.ErrorCases. Bug: 860361 Change-Id: I57bca1d4ad53ffa53e45fd6b3e340d678133a856 Reviewed-on: https://chromium-review.googlesource.com/1146539 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577437} [modify] https://crrev.com/514c0abe75c1685e65820130c1612b710094c56b/content/browser/service_worker/service_worker_script_loader_factory.h [add] https://crrev.com/514c0abe75c1685e65820130c1612b710094c56b/content/browser/service_worker/service_worker_script_loader_factory_unittest.cc [modify] https://crrev.com/514c0abe75c1685e65820130c1612b710094c56b/content/test/BUILD.gn
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef124da334e64752467c2d7f4ba895b9cd14928a commit ef124da334e64752467c2d7f4ba895b9cd14928a Author: Kenichi Ishibashi <bashi@chromium.org> Date: Tue Jul 24 08:21:20 2018 Disable S13nServiceWorker in ServiceWorkerURLRequestJobTest ServiceWorkerURLRequestJob is non-S13nServiceWorker specific class and we don't use it when S13nServiceWorker is enabled. This CL explicitly disable S13nServiceWorker in ServiceWorkerURLRequestJobTest. Bug: 860361 Change-Id: I9432b773b02cdee13ab877395f3d3ed3d5839c87 Reviewed-on: https://chromium-review.googlesource.com/1147897 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577458} [modify] https://crrev.com/ef124da334e64752467c2d7f4ba895b9cd14928a/content/browser/service_worker/service_worker_url_request_job_unittest.cc
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1269fbd8d2f5d963643c9b40f2069ab76ec408ac commit 1269fbd8d2f5d963643c9b40f2069ab76ec408ac Author: Kenichi Ishibashi <bashi@chromium.org> Date: Tue Jul 24 08:54:27 2018 S13nServiceWorker: Skip tests in ServiceWorkerContextRequestHandlerTest We don't use ServiceWorkerContextRequestHandler when S13nServiceWorker is enabled. Bug: 860361 Change-Id: Ib0e73f84b0e014d652941e1d8b3292fc32005149 Reviewed-on: https://chromium-review.googlesource.com/1146138 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577461} [modify] https://crrev.com/1269fbd8d2f5d963643c9b40f2069ab76ec408ac/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c23ba43c20ac76a29609072bbe696a46d34b95e commit 7c23ba43c20ac76a29609072bbe696a46d34b95e Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Jul 30 05:02:21 2018 service worker: Update ServiceWorkerControlleeRequestHandlerTest Update tests for ServiceWorkerControlleeRequestHandler to have better coverage with S13nServiceWorker enabled/disabled. Bug: 860361 Change-Id: Ie4b915fd2aea96afc9880c759d4bcdb82d320892 Reviewed-on: https://chromium-review.googlesource.com/1151070 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578977} [modify] https://crrev.com/7c23ba43c20ac76a29609072bbe696a46d34b95e/content/browser/service_worker/service_worker_controllee_request_handler.h [modify] https://crrev.com/7c23ba43c20ac76a29609072bbe696a46d34b95e/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc [modify] https://crrev.com/7c23ba43c20ac76a29609072bbe696a46d34b95e/content/browser/service_worker/service_worker_navigation_loader.cc [modify] https://crrev.com/7c23ba43c20ac76a29609072bbe696a46d34b95e/content/browser/service_worker/service_worker_navigation_loader.h [modify] https://crrev.com/7c23ba43c20ac76a29609072bbe696a46d34b95e/content/browser/service_worker/service_worker_url_job_wrapper.cc [modify] https://crrev.com/7c23ba43c20ac76a29609072bbe696a46d34b95e/content/browser/service_worker/service_worker_url_job_wrapper.h
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28e28546ddc11ea114061ad9d7dc0ae5d1779de4 commit 28e28546ddc11ea114061ad9d7dc0ae5d1779de4 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Tue Jul 31 00:16:46 2018 S13nServiceWorker: Pass SharedWorkerServiceImplTest When S13nServiceWorker is enabled these tests requre an instance of URLLoaderFactory. Add a mock URLLoaderFactory and set them in tests. This makes tests pass. Bug: 860361 Change-Id: I2cfa371c1c1076d895398686b3df36340664e30b Reviewed-on: https://chromium-review.googlesource.com/1152337 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#579243} [modify] https://crrev.com/28e28546ddc11ea114061ad9d7dc0ae5d1779de4/content/browser/shared_worker/shared_worker_service_impl_unittest.cc [modify] https://crrev.com/28e28546ddc11ea114061ad9d7dc0ae5d1779de4/content/public/test/mock_render_process_host.cc
,
Jul 31
All content_unittests pass on my Linux machine. $ out/Release/content_unittests --enable-features=ServiceWorkerServicification I will re-open this if I find further failures on bots etc.
,
Aug 7
Looks like following tests are failing now. Not sure I missed these before or they started failing recently.
8 tests failed:
URLLoaderClientImplTest.CancelOnReceiveData (../../content/renderer/loader/url_loader_client_impl_unittest.cc:252)
URLLoaderClientImplTest.CancelOnReceiveDataWhileFlushing (../../content/renderer/loader/url_loader_client_impl_unittest.cc:496)
URLLoaderClientImplTest.CancelOnReceiveResponse (../../content/renderer/loader/url_loader_client_impl_unittest.cc:230)
URLLoaderClientImplTest.OnCompleteShouldBeTheLastMessage (../../content/renderer/loader/url_loader_client_impl_unittest.cc:200)
URLLoaderClientImplTest.OnReceiveCachedMetadata (../../content/renderer/loader/url_loader_client_impl_unittest.cc:122)
URLLoaderClientImplTest.OnReceiveResponse (../../content/renderer/loader/url_loader_client_impl_unittest.cc:79)
URLLoaderClientImplTest.OnTransferSizeUpdated (../../content/renderer/loader/url_loader_client_impl_unittest.cc:138)
URLLoaderClientImplTest.ResponseBody (../../content/renderer/loader/url_loader_client_impl_unittest.cc:89)
1 test crashed:
URLLoaderClientImplTest.SetDeferredDuringFlushingDeferredMessage (../../content/renderer/loader/url_loader_client_impl_unittest.cc:392)
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac3744bb037f6d3e856971d01aa30b2283b0944a commit ac3744bb037f6d3e856971d01aa30b2283b0944a Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Aug 09 08:51:22 2018 S13nServiceWorker: Fix URLLoaderClientImplTests crrev.com/c/1160133 introduced MimeSniffingThrottle which may defer a request. Since URLLoaderClientImplTest has a (probably wrong) assumption that the request wouldn't be deferred, these tests were failing when S13nServiceWorker/Network is on. To work around the assumption this CL sets |fetch_request_context_type| to REQUEST_CONTEXT_TYPE_FETCH so that ResourceDispatcher won't install MimeSniffingThrottle. Bug: 860361 Change-Id: I6dab15515089a46f1b1c2a7501c826b9433e46b3 Reviewed-on: https://chromium-review.googlesource.com/1168705 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581830} [modify] https://crrev.com/ac3744bb037f6d3e856971d01aa30b2283b0944a/content/renderer/loader/url_loader_client_impl_unittest.cc
,
Aug 10
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by falken@chromium.org
, Jul 5