New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860359 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

CSS Animation: contain and will-change no longer animatable

Project Member Reported by ericwilligers@chromium.org, Jul 5

Issue description

From CSS WG Resolutions
https://github.com/w3c/csswg-drafts/issues/2737#issuecomment-402574750

RESOLVED: contain is not animatable
RESOLVED: will-change is not animatable

This makes them like 'display' and the transition* and animation* properties.

 
https://github.com/w3c/csswg-drafts/issues/2751#issuecomment-402604609
direciton/writing-mode/unicode-bidi also become non-animatable.

Cc: smcgruer@chromium.org
Labels: Hotlist-Interop
Owner: majidvp@chromium.org
Status: Assigned (was: Untriaged)
Re #1: ericwilligers@ Is there a reason why text-orientation should not also become none-animatable?
The github issue does mention text-orientation next to other so I believe the intention is to make that also none-animatable.
Cc: obru...@igalia.com emilio@chromium.org r...@chromium.org
 Issue 860732  has been merged into this issue.
FYI here is the patch I was about to land to resolve this: https://chromium-review.googlesource.com/c/chromium/src/+/1127062

At the moment it has a conflict on WPT since emilio@ landed a change [1] on FF end but should be easy to resolve. 

[1] https://github.com/web-platform-tests/wpt/commit/2950d5a51855c59ef1ddcb616eb8a282ce9a040e#diff-f75ccd39488ebc8dc3a1e425f8ffdb00

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e40e6a11c82b19232dc1d168f61d6773fdf0c4a

commit 2e40e6a11c82b19232dc1d168f61d6773fdf0c4a
Author: Majid Valipour <majidvp@chromium.org>
Date: Mon Jul 09 16:25:32 2018

[testing] Remove per platform expectations for wpt animation-types tests

The only difference that required per platform expectation files was
the fact that 'hyphens: auto' is only supported in Chromium on Mac.

These tests don't care about the actual css property value but how one
value is animated to another in web animation interpolation model. So instead of
using 'auto' for hyphens, we use 'none' which is supported on all platforms.
This help remove three 500+ lines per platform expectation files and reduce
unnecessary maintenance burden.

Change-Id: I5f3b716ce11a72a5235e7899d2e90f4bbea77ebc
Bug:  860359 
Reviewed-on: https://chromium-review.googlesource.com/1129201
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573328}
[rename] https://crrev.com/2e40e6a11c82b19232dc1d168f61d6773fdf0c4a/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[rename] https://crrev.com/2e40e6a11c82b19232dc1d168f61d6773fdf0c4a/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[rename] https://crrev.com/2e40e6a11c82b19232dc1d168f61d6773fdf0c4a/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
[modify] https://crrev.com/2e40e6a11c82b19232dc1d168f61d6773fdf0c4a/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/property-list.js
[delete] https://crrev.com/aed681a847aacb58ca66f0a6dc3a249fc5922781/third_party/WebKit/LayoutTests/platform/mac/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[delete] https://crrev.com/aed681a847aacb58ca66f0a6dc3a249fc5922781/third_party/WebKit/LayoutTests/platform/win/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[delete] https://crrev.com/aed681a847aacb58ca66f0a6dc3a249fc5922781/third_party/WebKit/LayoutTests/platform/win/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2c37b68be95744a72784fe6e1ec813397b938c2

commit d2c37b68be95744a72784fe6e1ec813397b938c2
Author: Majid Valipour <majidvp@chromium.org>
Date: Mon Jul 09 23:11:45 2018

[web-animation] Make contain/will-change/writing modes props not animatable

Match the recent CSSWG resolutions:
https://github.com/w3c/csswg-drafts/issues/2737#issuecomment-402574750
https://github.com/w3c/csswg-drafts/issues/2751#issuecomment-402604609


Make following properties none animatable:

* contain
* direction
* display
* text-orientation
* unicode-bidi
* will-change
* writing-mode


Note that wpt tests have already been updated for direction and writing-mode
here [1]

[1] https://github.com/web-platform-tests/wpt/commit/41f4ab65b239a5a9e9eeedadc2cae3d1fe0234c0

Bug:  860359 
Change-Id: I3e7296e3c28ff494eddbc6f011621dd29ba7d2aa
Reviewed-on: https://chromium-review.googlesource.com/1127062
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573509}
[modify] https://crrev.com/d2c37b68be95744a72784fe6e1ec813397b938c2/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[modify] https://crrev.com/d2c37b68be95744a72784fe6e1ec813397b938c2/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[modify] https://crrev.com/d2c37b68be95744a72784fe6e1ec813397b938c2/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
[modify] https://crrev.com/d2c37b68be95744a72784fe6e1ec813397b938c2/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/property-list.js
[delete] https://crrev.com/cc98218982bbe642978d7e4654e9540818de17f7/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/d2c37b68be95744a72784fe6e1ec813397b938c2/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[modify] https://crrev.com/d2c37b68be95744a72784fe6e1ec813397b938c2/third_party/blink/renderer/core/animation/css/css_animations.cc

Status: Fixed (was: Started)

Sign in to add a comment