Currently we don't closure compiler for test files. Since we started growing our test code, having some new types for testing etc, it's better to have closure compiler to check those files.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9025984c2c16156a590918081ea1628285044e27 commit 9025984c2c16156a590918081ea1628285044e27 Author: Trent Apted <tapted@chromium.org> Date: Tue Jul 31 02:47:11 2018 Gallery: closure-compile image_view_unittest.js Bug: 867700 , 860355 Change-Id: Ifcc4ada00bc459b8cd59a5c2b234af0ef3554c61 Reviewed-on: https://chromium-review.googlesource.com/1150015 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#579292} [modify] https://crrev.com/9025984c2c16156a590918081ea1628285044e27/ui/file_manager/file_manager/common/js/mock_entry.js [modify] https://crrev.com/9025984c2c16156a590918081ea1628285044e27/ui/file_manager/gallery/js/image_editor/BUILD.gn [modify] https://crrev.com/9025984c2c16156a590918081ea1628285044e27/ui/file_manager/gallery/js/image_editor/image_view_unittest.js
linking these up, but they can be fixed independently. Issue 867700 is for gallery stuff, which I'm trying to decouple from file manager.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63af8d5f9bbb4a065a76073e44855c54a6444f2f commit 63af8d5f9bbb4a065a76073e44855c54a6444f2f Author: Trent Apted <tapted@chromium.org> Date: Thu Aug 02 03:03:43 2018 Gallery: closure-compile image_editor/image_encoder_unittest.js The shared, unittest_util.js optionally overwrites some vars specified by externs that may or may not exist in the unit test. Suppress the warnings around these. Bug: 867700 , 860355 Change-Id: I461ed7921e7d454869d8e64de8c0eeeb626e4af7 Reviewed-on: https://chromium-review.googlesource.com/1154774 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580043} [modify] https://crrev.com/63af8d5f9bbb4a065a76073e44855c54a6444f2f/ui/file_manager/file_manager/common/js/BUILD.gn [modify] https://crrev.com/63af8d5f9bbb4a065a76073e44855c54a6444f2f/ui/file_manager/file_manager/common/js/unittest_util.js [modify] https://crrev.com/63af8d5f9bbb4a065a76073e44855c54a6444f2f/ui/file_manager/gallery/js/image_editor/BUILD.gn [modify] https://crrev.com/63af8d5f9bbb4a065a76073e44855c54a6444f2f/ui/file_manager/gallery/js/image_editor/image_encoder_unittest.js [modify] https://crrev.com/63af8d5f9bbb4a065a76073e44855c54a6444f2f/ui/file_manager/gallery/js/image_editor/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d43146b8a734469cf956139c64f963142cd96193 commit d43146b8a734469cf956139c64f963142cd96193 Author: Trent Apted <tapted@chromium.org> Date: Fri Aug 03 01:19:54 2018 FileManager: closure-compile exif_parser.js The ExifParser constructor was missing a comment causing the compiler to ignore all the other annotations. Closure didn't complain about the constructor itself missing a comment because it's never invoked as a constructor by name. It's passed as a factory to registerParserClass(). Bug: 860355 Change-Id: I12bf8bf1c0b3ac9c5b4825e22a58558121258fa9 Reviewed-on: https://chromium-review.googlesource.com/1160061 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580403} [modify] https://crrev.com/d43146b8a734469cf956139c64f963142cd96193/ui/file_manager/file_manager/foreground/js/metadata/exif_parser.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe commit a2bbe9dedf867fccce6d8073dc8e9c864c662bfe Author: Trent Apted <tapted@chromium.org> Date: Fri Sep 07 00:04:12 2018 Closure compile all file_manager/image_loader unittests. This was making refactoring for https://crbug.com/879958 difficult. Closure-compile existing unit_tests for the image_loader extension, and delete the handcrafted unittest.html files. Bug: 860355 Change-Id: I0d99d0383eb8fe48813d9142a14ce9af28da2dc5 Reviewed-on: https://chromium-review.googlesource.com/1207784 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589377} [modify] https://crrev.com/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe/chrome/browser/chromeos/file_manager/image_loader_jstest.cc [modify] https://crrev.com/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe/ui/file_manager/BUILD.gn [modify] https://crrev.com/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe/ui/file_manager/file_manager/common/js/BUILD.gn [modify] https://crrev.com/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe/ui/file_manager/image_loader/BUILD.gn [delete] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/ui/file_manager/image_loader/cache_unittest.html [delete] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/ui/file_manager/image_loader/image_loader_client_unittest.html [modify] https://crrev.com/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe/ui/file_manager/image_loader/image_loader_client_unittest.js [delete] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/ui/file_manager/image_loader/image_loader_unittest.html [delete] https://crrev.com/f46bf54d8c0d3e0e5f0d7c75275def7f04c933d0/ui/file_manager/image_loader/piex_loader_unittest.html [modify] https://crrev.com/a2bbe9dedf867fccce6d8073dc8e9c864c662bfe/ui/file_manager/image_loader/piex_loader_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f919e4565e1f3960548400a1349a23ee75ff7866 commit f919e4565e1f3960548400a1349a23ee75ff7866 Author: Trent Apted <tapted@chromium.org> Date: Fri Sep 07 05:18:02 2018 Closure compile file_manager/.../thumbnail_loader_unittest.js. The //ui/file_manager/common/js:util target has a dependency on the file_manager_private extern. Break out that extern to a separate target to bundle its hidden dependencies together, since multiple things depend on it. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icfa65dff5c692b6bd415f9f2d5c67b14a0db0ef6 Reviewed-on: https://chromium-review.googlesource.com/1212706 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#589437} [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/externs/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/file_manager/common/js/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/file_manager/foreground/js/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn [delete] https://crrev.com/f3b67c85008a2de4e1146316974a0e2e15aa9207/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.html [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/file_manager/test/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/gallery/js/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/image_loader/BUILD.gn [modify] https://crrev.com/f919e4565e1f3960548400a1349a23ee75ff7866/ui/file_manager/video_player/js/cast/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84e30b509b75f7076ecce3fd52ba02bb93aaaf21 commit 84e30b509b75f7076ecce3fd52ba02bb93aaaf21 Author: Trent Apted <tapted@chromium.org> Date: Mon Sep 10 06:50:29 2018 Upstream js_unit_tests.gni to third_party/closure_compiler. This is used for unit tests in ui/file_manager, but it is neat and other targets should use it too. It's now pretty stable. It reduces boilerplate in BUILD.gn files and allows foo_unittest.html files to be automatically generated from build dependencies, rather than being handcrafted. js_unit_test.py currently lacks the performance optimization added for js_binary in r581961 to cache dependency subtrees, so it's a bit slow. Upstreaming allows the two python scripts to share the dependency walker in a sane manner. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iedddd39907137dd40ec21f507cb560756251c8b1 Reviewed-on: https://chromium-review.googlesource.com/1212364 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589840} [modify] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/third_party/closure_compiler/README.chromium [rename] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/third_party/closure_compiler/js_unit_test.py [rename] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/third_party/closure_compiler/js_unit_tests.gni [modify] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/ui/file_manager/file_manager/foreground/js/BUILD.gn [modify] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/ui/file_manager/gallery/js/BUILD.gn [modify] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/ui/file_manager/gallery/js/image_editor/BUILD.gn [modify] https://crrev.com/84e30b509b75f7076ecce3fd52ba02bb93aaaf21/ui/file_manager/image_loader/BUILD.gn
I'm tackling ui/file_manager/file_manager/common in https://chromium-review.googlesource.com/c/chromium/src/+/1250762 except for metrics_unittest :/. metrics_unittest is currently disabled in file_manager_jstest.cc . Also it has a ton of errors :'(
Does not seem to be milestone specific.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27d5bb460978eff41f46e0f59d7ea12520a06516 commit 27d5bb460978eff41f46e0f59d7ea12520a06516 Author: Trent Apted <tapted@chromium.org> Date: Fri Oct 05 06:51:26 2018 Prefix includes in html files generated by js_unit_test.py This allows the html files generated under out/foo/gen/.... to be opened in Chrome as a file:/// URL. It doesn't affect how the files are served by the embedded test server (leading ../..'s are ignored). Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6a7a8838c6158f9f5cdeb9fa8e0745c23d88f602 Reviewed-on: https://chromium-review.googlesource.com/c/1264095 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#597016} [modify] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/third_party/closure_compiler/js_unit_test.py [modify] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/third_party/closure_compiler/js_unit_tests.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a213f73434501b59ab1f7a10039e13365113c17 commit 3a213f73434501b59ab1f7a10039e13365113c17 Author: Trent Apted <tapted@chromium.org> Date: Fri Oct 05 06:56:16 2018 Closure compile all but one js unittest in ui/file_manager/common Adds - FileManagerJsTest.ImporterCommonTest - FileManagerJsTest.LRUCacheTest - FileManagerJsTest.AsyncUtilTest - FileManagerJsTest.FilesAppEntryTypes - FileManagerJsTest.UtilTest Also adds test_importer_common.js to be typechecked, which isn't itself a unit test. This exposed a weird dependency group on ui/file_manager/exerns/volume_info.js - encapsulate those dependencies as well as we can. Remove the dependency on cr.EventListenerType: it's a @typedef {...|*} so adds no type safety and requires a dependency on "//ui/webui/resources/js/cr:event_target" which is not an extern. Bug: 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I479f8e7b22b56ea315c27fabc5e7ccdeb6277728 Reviewed-on: https://chromium-review.googlesource.com/c/1250762 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597017} [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/audio_player/js/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/base/js/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/externs/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/externs/volume_manager.js [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/BUILD.gn [delete] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/ui/file_manager/file_manager/common/js/async_util_unittest.html [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/async_util_unittest.js [delete] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js [delete] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/ui/file_manager/file_manager/common/js/importer_common_unittest.html [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/importer_common_unittest.js [delete] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/ui/file_manager/file_manager/common/js/lru_cache_unittest.html [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/mock_entry.js [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/test_importer_common.js [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/common/js/unittest_util.js [delete] https://crrev.com/27d5bb460978eff41f46e0f59d7ea12520a06516/ui/file_manager/file_manager/common/js/util_unittest.html [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/gallery/js/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/video_player/js/BUILD.gn [modify] https://crrev.com/3a213f73434501b59ab1f7a10039e13365113c17/ui/file_manager/video_player/js/cast/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fc0f5ddb59e2445813dec1a8e6887413bfdd508 commit 6fc0f5ddb59e2445813dec1a8e6887413bfdd508 Author: Trent Apted <tapted@chromium.org> Date: Tue Oct 16 04:15:51 2018 FilesApp: Closure compile background/.../volume_manager_unittest Related apps under ui/file_manager all use background_base.js, which instantiates a VolumeManagerFactory. VolumeManagerFactory, BackgroundBase, their tests, and things they depend on should all move to //ui/file_manager/base/*. Capturing deps by Closure-compiling makes things easier to move. Start with volume_manager_unittest.js. Break its dependency on the files app `unittest_util.js` (which shouldn't move) by splitting out some test utility functions to ui/file_manager/base/js/mock_chrome.js. Bug: 879035, 860355 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieab83e90607da78cf06352ecce73c0f8d62a2838 Reviewed-on: https://chromium-review.googlesource.com/c/1278622 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599845} [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/BUILD.gn [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/base/js/BUILD.gn [add] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/base/js/mock_chrome.js [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/device_handler_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html [delete] https://crrev.com/def776e75cfc3b34930e83402a7bb2c186bc4eb2/ui/file_manager/file_manager/background/js/volume_manager_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/background/js/volume_manager_unittest.js [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/common/js/BUILD.gn [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/common/js/unittest_util.js [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/import_controller_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html [modify] https://crrev.com/6fc0f5ddb59e2445813dec1a8e6887413bfdd508/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/036350672c7cc81d99da59975900b7a07331aaea commit 036350672c7cc81d99da59975900b7a07331aaea Author: Stuart Langley <slangley@google.com> Date: Mon Oct 22 06:16:26 2018 Move actions_submenu_unittest to be closure compiled. Added BUILD target for mock_actions_model.js that is testonly. Bug: 860355 Change-Id: Idb81f1e2bdcbda7ba4164b502e4b81f551f2b0bb Reviewed-on: https://chromium-review.googlesource.com/c/1292660 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601485} [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/ui/file_manager/BUILD.gn [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/ui/file_manager/file_manager/foreground/js/BUILD.gn [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/ui/file_manager/file_manager/foreground/js/directory_model.js [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/ui/file_manager/file_manager/foreground/js/mock_actions_model.js [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn [delete] https://crrev.com/d50b8f5c289c196cb1ec1b73eb3579e556504360/ui/file_manager/file_manager/foreground/js/ui/actions_submenu_unittest.html [modify] https://crrev.com/036350672c7cc81d99da59975900b7a07331aaea/ui/file_manager/file_manager/foreground/js/ui/actions_submenu_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff commit 0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff Author: Stuart Langley <slangley@google.com> Date: Tue Oct 23 04:00:41 2018 Update file_table_unittest & file_list_selection_model_unittest to be generated. This CL updates file_table_unittest & file_list_selection_model_unittest to be autogenerated from dependencies. Required fixing VolumeManager, where a method was only defined in FilteredVolumeManager and not in the interface. Populate the base class with a method that always logs an error to keep the closure compiler happy. Bug: 860355 Change-Id: I90192479d7faf4368a140460400357dae0f2da4c Reviewed-on: https://chromium-review.googlesource.com/c/1295429 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#601843} [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/base/js/filtered_volume_manager.js [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/externs/volume_manager.js [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/file_manager/background/js/mock_volume_manager.js [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/file_manager/background/js/volume_manager_impl.js [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn [delete] https://crrev.com/1a04703f56c783822df7b041451d1b4bf6f54df0/ui/file_manager/file_manager/foreground/js/ui/file_list_selection_model_unittest.html [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/file_manager/foreground/js/ui/file_table.js [delete] https://crrev.com/1a04703f56c783822df7b041451d1b4bf6f54df0/ui/file_manager/file_manager/foreground/js/ui/file_table_unittest.html [modify] https://crrev.com/0544b8e9bbb594dbf0fdf51bbdbf655b5674dbff/ui/file_manager/file_manager/foreground/js/ui/file_table_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dad275695870b8e9234665ede2c20f4fdf7f2f2 commit 2dad275695870b8e9234665ede2c20f4fdf7f2f2 Author: Stuart Langley <slangley@google.com> Date: Tue Oct 23 10:47:23 2018 Move file_tap_handler_unittest to be auto generated. More work to have unittest closure compiled. Fixed the closure and linter errors after making these changes. No logic changes. Bug: 860355 Change-Id: Iaddb21d332877f901997e513c92fcb0b6b1c210e Reviewed-on: https://chromium-review.googlesource.com/c/1295972 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#601905} [modify] https://crrev.com/2dad275695870b8e9234665ede2c20f4fdf7f2f2/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/2dad275695870b8e9234665ede2c20f4fdf7f2f2/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn [delete] https://crrev.com/8c0f6ea878fed460d10f082393f9fc8e1a57c8a2/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html [modify] https://crrev.com/2dad275695870b8e9234665ede2c20f4fdf7f2f2/ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dea3b9e5359a52df8d8a61b32d356bab86b65f54 commit dea3b9e5359a52df8d8a61b32d356bab86b65f54 Author: Stuart Langley <slangley@google.com> Date: Mon Oct 29 05:47:04 2018 Closure compile mocks in //file_manager/foreground/js. This just gets the mocks to be closure compiled, there will likely be more changes when we start taking direct dependencies. Bug: 860355 Change-Id: I7ddfe6f82830a3d2e5b0858596dba80f921e5534 Reviewed-on: https://chromium-review.googlesource.com/c/1304036 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#603420} [modify] https://crrev.com/dea3b9e5359a52df8d8a61b32d356bab86b65f54/ui/file_manager/file_manager/common/js/mock_entry.js [modify] https://crrev.com/dea3b9e5359a52df8d8a61b32d356bab86b65f54/ui/file_manager/file_manager/foreground/js/BUILD.gn [modify] https://crrev.com/dea3b9e5359a52df8d8a61b32d356bab86b65f54/ui/file_manager/file_manager/foreground/js/mock_directory_model.js [modify] https://crrev.com/dea3b9e5359a52df8d8a61b32d356bab86b65f54/ui/file_manager/file_manager/foreground/js/mock_thumbnail_loader.js
Issue 724894 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1aefd75c94dd4d91d5792ccda76a114b0146ba6b commit 1aefd75c94dd4d91d5792ccda76a114b0146ba6b Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Nov 01 01:53:37 2018 FilesApp closure compile crostini unittest Bug: 860355 Change-Id: I73b7eb298cf462c5e981f0cfb3a0132499b0083c Reviewed-on: https://chromium-review.googlesource.com/c/1312134 Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604485} [modify] https://crrev.com/1aefd75c94dd4d91d5792ccda76a114b0146ba6b/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/1aefd75c94dd4d91d5792ccda76a114b0146ba6b/ui/file_manager/file_manager/foreground/js/BUILD.gn [modify] https://crrev.com/1aefd75c94dd4d91d5792ccda76a114b0146ba6b/ui/file_manager/file_manager/foreground/js/crostini.js [delete] https://crrev.com/1f3652ef0ed395d204bf25f600908c6b0b5d5dbb/ui/file_manager/file_manager/foreground/js/crostini_unittest.html [modify] https://crrev.com/1aefd75c94dd4d91d5792ccda76a114b0146ba6b/ui/file_manager/file_manager/foreground/js/crostini_unittest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecb81c3fe10845a0cbdbc7872a89054908c023cc commit ecb81c3fe10845a0cbdbc7872a89054908c023cc Author: Noel Gordon <noel@chromium.org> Date: Fri Nov 30 02:34:03 2018 FilesApp analytics: remove metrics unittest CL:1347648 removed google analytics from FilesApp so metrics_unittest, which was disabled on issue 842880 , can now be deleted [1]. [1] The metrics_unittest test fixtures required a {analytics.Tracker}, which no longer exists in FilesApp. Bug: 847729 , 860355 Change-Id: I0ec71ef837e747cd6647d7359546b9876d62dbc8 Reviewed-on: https://chromium-review.googlesource.com/c/1355303 Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612528} [modify] https://crrev.com/ecb81c3fe10845a0cbdbc7872a89054908c023cc/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [delete] https://crrev.com/4cebe24d76e6eeb89c5820b7b1a2da067b16692b/ui/file_manager/file_manager/common/js/metrics_unittest.html [delete] https://crrev.com/4cebe24d76e6eeb89c5820b7b1a2da067b16692b/ui/file_manager/file_manager/common/js/metrics_unittest.js
With issue 910975 issue 910774 done, all the Files app backend unittests have been converted.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69afc37e2d739bfbe4466dc983d862f3bf1e35c2 commit 69afc37e2d739bfbe4466dc983d862f3bf1e35c2 Author: Noel Gordon <noel@chromium.org> Date: Tue Dec 04 07:00:01 2018 Background BUILD.gn: don't ../.. to mock_entry no more Bug: 860355 Change-Id: I6639500a50f536b67fc0c084a4b319ff0d98ae24 Reviewed-on: https://chromium-review.googlesource.com/c/1360196 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#613453} [modify] https://crrev.com/69afc37e2d739bfbe4466dc983d862f3bf1e35c2/ui/file_manager/file_manager/background/js/BUILD.gn
Final issue 914197 about to close ...
Comment 1 by sashab@chromium.org
, Jul 19Status: Available (was: Untriaged)