New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860344 link

Starred by 21 users

Mouse cursor misplaced on undocked Devtools

Reported by franco.v...@outlook.com, Jul 4

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3472.3 Safari/537.36

Steps to reproduce the problem:
1. Open some page
2. Open Devtools
3. Undock DevTools

What is the expected behavior?
The mouse works just fine

What went wrong?
I have to click above normal with the mouse anywhere in the interface to click correctly where I want. The pointer seems to be misplaced.

Did this work before? Yes I don't know, maybe 68

Chrome version: 69.0.3472.3  Channel: dev
OS Version: OS X 10.13.4
Flash Version: Shockwave Flash 30.0 r0
 
Labels: Needs-Triage-M69
Labels: Needs-Bisect

Comment 3 Deleted

Thanks for filing the issue!

Unable to reproduce the issue on reported chrome version 69.0.3472.3 using Mac 10.13.1 with the below mentioned steps.
1. Launched Chrome
2. Inspected a page to open DevTools
3. Undocked DevTools
Observed the mouse working fine without having to click anywhere. Attaching the screen cast of the same.

@Reporter: Could you please have a look at the screen cast and let us know if we have missed anything in the process. Any further inputs from your end may help us.
860344.mp4
4.3 MB View Download
Here is a screen recording. I do almost the same as you

Jul 5, 2018 9_43 AM.webm
7.5 MB View Download
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 5

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
@Reporter: Your screencast(...comment#5) explaining the mouse cursor misplacement was very helpful in understanding the issue being faced by you, besides we were unable to reproduce it from our end i.e., the mouse cursor placement was proper when hovered on undocked DevTools. Could you please check the same in a new profile with out any apps & extensions and let us know if the issue still persists. It would also be helpful in mentioned whether similar issue is being seen on other machines too...!

Thanks!
I can confirm that in a new profile I CAN'T reproduce the issue.
I don't know what extension/app or setting could be doing this, but I'm pretty sure this did't happen before I update to latest version, and I had the same extensions/apps or settings.
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 6

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Ok, I disabled all extensions in MY profile and the issue is gone. So maybe now I have to identify what extension is causing the issue, I have some extensions that I don't use anymore so maybe I need some clean up :(
Labels: Needs-Feedback
@Reporter: From your comment#10 it is clearly understood that the issue isn't with chrome rather it's with any of the installed extension(s), so could you please let us know if we can close this issue!

Thanks!
This is triggered by any extension that adds to the Chrome devtools, such as HTTPS Everywhere, or React Developer Tools.
Yes, I can confirm that. I turn on React Developer Tools and I have the issue. Well...
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 9

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
You are probably looking for a change made after 563000 (known good), but no later than 563011 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c1aee266961732caac973b18dc6c6f87ae6b59ca..892c291ac3526d45fd01d37655eac336c36836ce

(Performed this bisect with `--enable-features=ViewsBrowserWindows`.)
Cc: dgozman@chromium.org
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
I can't reproduce this, but perhaps its as I do not have ViewsBrowserWindows on.

+ccameron, as https://chromium.googlesource.com/chromium/src/+/6be8acd7b09a2378d8c47ca9fa91b9fd9b4839ba looks like the culprit.
+dgozman, in case you've seen something related

thanks very much for the investigation, jleedev!
and thanks for the details and video, franco.
Labels: -Needs-Bisect
The issue seems to be with an extension rather than with chrome(...as per comment#8, #10) and the CL is provided in comment#15, hence removing Needs-Bisect label, please feel free to add the label back if required.

Thanks!
Thanks, I can reproduce this now. It reproduces in MacViewsBrowser as well.
Disabling ng-inspect-for-angularjs solved the issue for me. This is another extension that adds a sidebar pane to the elements panel.
 Issue 863692  has been merged into this issue.
Cc: spqc...@chromium.org ccameron@chromium.org
 Issue 863554  has been merged into this issue.
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3fa3357f872fd2175fba29df3da5f8f10bffb6e

commit d3fa3357f872fd2175fba29df3da5f8f10bffb6e
Author: Christopher Cameron <ccameron@chromium.org>
Date: Sat Jul 21 06:38:58 2018

MacViews: Fix GetOffsetFromRootSurface

This should be based off of the ui::Layer heirarchy, not the NSView
heirarchy.

Bug:  860344 
Change-Id: I307a1d681a21846886bb6118a3e3acf97c2b268e
Reviewed-on: https://chromium-review.googlesource.com/1144215
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577073}
[modify] https://crrev.com/d3fa3357f872fd2175fba29df3da5f8f10bffb6e/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/d3fa3357f872fd2175fba29df3da5f8f10bffb6e/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/d3fa3357f872fd2175fba29df3da5f8f10bffb6e/content/browser/renderer_host/render_widget_host_view_mac.mm

This is fixed in latest version (70.0.3499.0).
The latest version fixed the "unlock into separate window" situation, but it still has the issue on "dock to bottom", "dock to left" and "dock to right"

mac 70.0.3499.0
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffd2547f1bd23b0b5788e7a07fa65e5d2a15cdce

commit ffd2547f1bd23b0b5788e7a07fa65e5d2a15cdce
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Jul 23 07:20:25 2018

Fix typo causing warped mouse input

This function was computing the right transform, and then applying it
to a temporary variable instead of the input.

TBR=fsamuel

Bug:  860344 
Change-Id: I917b1ea2610b6edaaa43eb2d7abc6febbb44f0fc
Reviewed-on: https://chromium-review.googlesource.com/1146480
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577118}
[modify] https://crrev.com/ffd2547f1bd23b0b5788e7a07fa65e5d2a15cdce/content/browser/renderer_host/browser_compositor_view_mac.mm

70.0.3499 broke everything except for "separate window", including lots of web contents. If there are still issues in 70.0.3501 (not released yet), let me know

Comment 27 Deleted

Is there any idea on when 70.0.3501 will be released?
Cc: chelamcherla@chromium.org ellyjo...@chromium.org ajha@chromium.org
 Issue 866429  has been merged into this issue.

Comment 30 Deleted

Cc: franco.v...@outlook.com
Labels: Needs-Feedback
As per comment# 4 & 7, this issue is unable to reproduce from TE end.
@ccameron/franco.valerio: As this issue is unable to reproduce from TE end, could you please try to test this issue on latest chrome# 70.0.3501.0 and help us in verifying the fix.

Thanks!
 Issue 866586  has been merged into this issue.
Labels: Hotlist-ConOps
Labels: Merge-Request-69
Requesting merge for 69.
Project Member

Comment 35 by sheriffbot@chromium.org, Jul 27

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M69 branch 3497 by 4:00 PM PT today, so we can pick it up for next week LAST M69 Dev release before Beta promotion. Thank you
Project Member

Comment 37 by bugdroid1@chromium.org, Jul 27

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e33646c8fab5498f291f5231119514c266b84cd

commit 7e33646c8fab5498f291f5231119514c266b84cd
Author: Christopher Cameron <ccameron@chromium.org>
Date: Fri Jul 27 21:59:49 2018

MacViews: Fix GetOffsetFromRootSurface

This should be based off of the ui::Layer heirarchy, not the NSView
heirarchy.

TBR=ccameron@chromium.org

(cherry picked from commit d3fa3357f872fd2175fba29df3da5f8f10bffb6e)

Bug:  860344 
Change-Id: I307a1d681a21846886bb6118a3e3acf97c2b268e
Reviewed-on: https://chromium-review.googlesource.com/1144215
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577073}
Reviewed-on: https://chromium-review.googlesource.com/1153788
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#180}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/7e33646c8fab5498f291f5231119514c266b84cd/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/7e33646c8fab5498f291f5231119514c266b84cd/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/7e33646c8fab5498f291f5231119514c266b84cd/content/browser/renderer_host/render_widget_host_view_mac.mm

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12378e11010e06069ee3f705b78acbd60acb240b

commit 12378e11010e06069ee3f705b78acbd60acb240b
Author: Christopher Cameron <ccameron@chromium.org>
Date: Fri Jul 27 22:04:07 2018

Fix typo causing warped mouse input

This function was computing the right transform, and then applying it
to a temporary variable instead of the input.

TBR=ccameron@chromium.org, fsamuel

(cherry picked from commit ffd2547f1bd23b0b5788e7a07fa65e5d2a15cdce)

Bug:  860344 
Change-Id: I917b1ea2610b6edaaa43eb2d7abc6febbb44f0fc
Reviewed-on: https://chromium-review.googlesource.com/1146480
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577118}
Reviewed-on: https://chromium-review.googlesource.com/1153789
Cr-Commit-Position: refs/branch-heads/3497@{#181}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/12378e11010e06069ee3f705b78acbd60acb240b/content/browser/renderer_host/browser_compositor_view_mac.mm

Status: Fixed (was: Assigned)
Project Member

Comment 40 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e43348c15932af15393fb5c82e7c13fbf2387e89

commit e43348c15932af15393fb5c82e7c13fbf2387e89
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Jul 30 20:03:18 2018

MacViews: Add unit test for input coordinate transform

This broke because of no testing.

Bug:  860344 
Change-Id: Ic86918d1cf44112e7effa54483384c11b1ccb08b
Reviewed-on: https://chromium-review.googlesource.com/1155159
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579135}
[modify] https://crrev.com/e43348c15932af15393fb5c82e7c13fbf2387e89/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Cc: nyerramilli@chromium.org manoranj...@chromium.org sdy@chromium.org rbasuvula@chromium.org
 Issue 852732  has been merged into this issue.
Cc: krajshree@chromium.org phanindra.mandapaka@chromium.org
 Issue 862861  has been merged into this issue.

Sign in to add a comment