Allow only one keyframe model per target property in cc::KeyframeEffect |
||
Issue descriptionCurrently in cc a keyframe effect may have the following keyframe model sequence: opacity, transform, opacity; but this is never true in reality. Adding 2 opacity animations for the same target should be done with 2 separate animations.
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/248b42203b256d2b0e2d310c5dae115a06d72fdd commit 248b42203b256d2b0e2d310c5dae115a06d72fdd Author: Yi Gu <yigu@chromium.org> Date: Mon Jul 09 23:01:48 2018 Add DCHECK to make sure that keyframe models in the same group don't animate the same property Currently in cc a keyframe effect is allowed to have the following keyframe model sequence: opacity, transform, opacity; but this is never true in reality if they are in the same group, i.e., start together. This patch is to forbid such behavior and update tests accordingly. Bug: 860341 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I39e7765faf910ff4e9385b18b796baa394d0e660 Reviewed-on: https://chromium-review.googlesource.com/1129200 Reviewed-by: Ali Juma <ajuma@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573504} [modify] https://crrev.com/248b42203b256d2b0e2d310c5dae115a06d72fdd/cc/animation/element_animations_unittest.cc [modify] https://crrev.com/248b42203b256d2b0e2d310c5dae115a06d72fdd/cc/animation/keyframe_effect.cc
,
Jul 16
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 6