New issue
Advanced search Search tips

Issue 860337 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

"SnapshotBrowserTest.SyncMultiWindowTest" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 4 
"SnapshotBrowserTest.SyncMultiWindowTest" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidTbmFwc2hvdEJyb3dzZXJUZXN0LlN5bmNNdWx0aVdpbmRvd1Rlc3QM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 853651 .

Comment 1 by eirage@chromium.org, Jul 4

Labels: OS-Chrome
Owner: ccameron@chromium.org
Status: Assigned (was: Untriaged)
The test is flaky on chromeOS trybot 
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_content_browsertests%20(with%20patch)&tests=SnapshotBrowserTest.SyncMultiWindowTest

I'll disable it on chromeos
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443298d812bf2dbafc30aa21915eee11d777d70f

commit 443298d812bf2dbafc30aa21915eee11d777d70f
Author: Ella Ge <eirage@chromium.org>
Date: Wed Jul 04 21:35:32 2018

Disable SnapshotBrowserTest.SyncMultiWindowTest on ChromeOS

TBR=ccameron@chromium.org
NOTRY=true

Bug: 860337
Change-Id: I35e3bd87fa5551f21129b29de7aca56929ad07ad
Reviewed-on: https://chromium-review.googlesource.com/1126489
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572658}
[modify] https://crrev.com/443298d812bf2dbafc30aa21915eee11d777d70f/content/browser/snapshot_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b90477746d5915bfb2d17e000e26e40752b55ebc

commit b90477746d5915bfb2d17e000e26e40752b55ebc
Author: Ella Ge <eirage@chromium.org>
Date: Wed Jul 04 21:43:16 2018

Revert "Disable SnapshotBrowserTest.SyncMultiWindowTest on ChromeOS"

This reverts commit 443298d812bf2dbafc30aa21915eee11d777d70f.

Reason for revert: compile error

Original change's description:
> Disable SnapshotBrowserTest.SyncMultiWindowTest on ChromeOS
> 
> TBR=ccameron@chromium.org
> NOTRY=true
> 
> Bug: 860337
> Change-Id: I35e3bd87fa5551f21129b29de7aca56929ad07ad
> Reviewed-on: https://chromium-review.googlesource.com/1126489
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572658}

TBR=ccameron@chromium.org,eirage@chromium.org

Change-Id: I3ba4b15f4de9d2b594ac018598c392414c6403ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860337
Reviewed-on: https://chromium-review.googlesource.com/1126289
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572659}
[modify] https://crrev.com/b90477746d5915bfb2d17e000e26e40752b55ebc/content/browser/snapshot_browsertest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe452d8e173cf09d26e3b9efd50dda43350bf43

commit fbe452d8e173cf09d26e3b9efd50dda43350bf43
Author: Ella Ge <eirage@chromium.org>
Date: Wed Jul 04 21:50:06 2018

Reland "Disable SnapshotBrowserTest.SyncMultiWindowTest on ChromeOS"

This reverts commit b90477746d5915bfb2d17e000e26e40752b55ebc.

Reason for revert: fix parentheses

Original change's description:
> Revert "Disable SnapshotBrowserTest.SyncMultiWindowTest on ChromeOS"
>
> This reverts commit 443298d812bf2dbafc30aa21915eee11d777d70f.
>
> Reason for revert: compile error
>
> Original change's description:
> > Disable SnapshotBrowserTest.SyncMultiWindowTest on ChromeOS
> >
> > TBR=ccameron@chromium.org
> > NOTRY=true
> >
> > Bug: 860337
> > Change-Id: I35e3bd87fa5551f21129b29de7aca56929ad07ad
> > Reviewed-on: https://chromium-review.googlesource.com/1126489
> > Reviewed-by: Ella Ge <eirage@chromium.org>
> > Commit-Queue: Ella Ge <eirage@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#572658}
>
> TBR=ccameron@chromium.org,eirage@chromium.org
>
> Change-Id: I3ba4b15f4de9d2b594ac018598c392414c6403ec
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 860337
> Reviewed-on: https://chromium-review.googlesource.com/1126289
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Commit-Queue: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572659}

TBR=ccameron@chromium.org

Change-Id: I999efe9a736c87771477d5213a92d46a7e7cf9ab
No-Try: true
Bug: 860337
Reviewed-on: https://chromium-review.googlesource.com/1126290
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572661}
[modify] https://crrev.com/fbe452d8e173cf09d26e3b9efd50dda43350bf43/content/browser/snapshot_browsertest.cc

Comment 5 by eirage@chromium.org, Jul 4

Labels: -Sheriff-Chromium
Sorry for making it worse :(

Test is disabled now.

Comment 7 by ccameron@chromium.org, Jul 6

Owner: ----
Status: Available (was: Assigned)
Un-assigning me -- I fixed macOS flakeyness in  issue 853651 , but that's not this issue.
►

Sign in to add a comment