New issue
Advanced search Search tips

Issue 860325 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 800418



Sign in to add a comment

TWAs don't play well with recents

Project Member Reported by peconn@chromium.org, Jul 4

Issue description

TWAs don't persist when you open the Recents switcher.

They appear to get FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS from the Intent copied over from the ChromeLauncherActivity.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95ecf6b551fe3a33c23f2882188b9aa68ee5d930

commit 95ecf6b551fe3a33c23f2882188b9aa68ee5d930
Author: Peter E Conn <peconn@chromium.org>
Date: Mon Jul 09 13:27:52 2018

🤝 Use new Intent flags while creating the TWA Intent.

The ChromeLauncherActivity has android:excludeFromRecents="true" set in
the AndroidManifest.xml. This causes the Intent used to launch it to
have Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS set. The Intent used to
launch a Trusted Web Activity copies the flag from this first Intent.

As I can currently see not advantage to copying the flags over, this
CL stops this and therefore prevents TWAs being launched with
Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS.

Bug:  860325 
Change-Id: I135bd9f5a070e5b34a0fedaf6d66714604712170
Reviewed-on: https://chromium-review.googlesource.com/1126390
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573286}
[modify] https://crrev.com/95ecf6b551fe3a33c23f2882188b9aa68ee5d930/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java

Status: Fixed (was: Started)

Sign in to add a comment