New issue
Advanced search Search tips

Issue 860313 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-logical] Logical border colors ignored in :visited rules

Project Member Reported by obru...@igalia.com, Jul 4

Issue description

What steps will reproduce the problem?
(1) Use a logical border color property inside a :visited rule

What is the expected result?
The property is honored, like if it were a physical border color property.

What happens instead?
The property is ignored.

 
logical-box-border-color-visited-link.html
885 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f00566428aa0a559701367a4d34cc2274c03b5d

commit 4f00566428aa0a559701367a4d34cc2274c03b5d
Author: Oriol Brufau <obrufau@igalia.com>
Date: Fri Jul 06 16:37:47 2018

[css-logical] Allow flow-relative border colors in :visited rules

They should be allowed like the physical border colors.

Spec: https://drafts.csswg.org/css-logical/#border-color
Spec: https://drafts.csswg.org/selectors/#visited-pseudo

BUG= 860313 

TEST=fast/css/logical-box-border-color-visited.html

Change-Id: I9ccb94f1488e5998cf36cfe3de0af6631e7b2ea4
Reviewed-on: https://chromium-review.googlesource.com/1126383
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572990}
[add] https://crrev.com/4f00566428aa0a559701367a4d34cc2274c03b5d/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-expected.html
[add] https://crrev.com/4f00566428aa0a559701367a4d34cc2274c03b5d/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link.html
[modify] https://crrev.com/4f00566428aa0a559701367a4d34cc2274c03b5d/third_party/blink/renderer/core/css/CSSProperties.json5

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0de7b5ae9d18f14d5ab20739ac623024895f0e49

commit 0de7b5ae9d18f14d5ab20739ac623024895f0e49
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 06 17:47:31 2018

Revert "[css-logical] Allow flow-relative border colors in :visited rules"

This reverts commit 4f00566428aa0a559701367a4d34cc2274c03b5d.

Reason for revert: May have caused no-op build failures, see:  https://crbug.com/860761 

Original change's description:
> [css-logical] Allow flow-relative border colors in :visited rules
> 
> They should be allowed like the physical border colors.
> 
> Spec: https://drafts.csswg.org/css-logical/#border-color
> Spec: https://drafts.csswg.org/selectors/#visited-pseudo
> 
> BUG= 860313 
> 
> TEST=fast/css/logical-box-border-color-visited.html
> 
> Change-Id: I9ccb94f1488e5998cf36cfe3de0af6631e7b2ea4
> Reviewed-on: https://chromium-review.googlesource.com/1126383
> Commit-Queue: Oriol Brufau <obrufau@igalia.com>
> Reviewed-by: Manuel Rego <rego@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#572990}

TBR=rego@igalia.com,obrufau@igalia.com

Change-Id: Ie9edf063c2a4c98a5f2cd986b8be040e54d7d70e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  860313 
Reviewed-on: https://chromium-review.googlesource.com/1127961
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573008}
[delete] https://crrev.com/af5f261852e90d21ec7e97d78e66a48c9ab346e8/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-expected.html
[delete] https://crrev.com/af5f261852e90d21ec7e97d78e66a48c9ab346e8/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link.html
[modify] https://crrev.com/0de7b5ae9d18f14d5ab20739ac623024895f0e49/third_party/blink/renderer/core/css/CSSProperties.json5

Status: Started (was: Fixed)
Was reverted in  issue 860761 
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ec679efb5502f04e8eb06c6caa76c8de24b421

commit 29ec679efb5502f04e8eb06c6caa76c8de24b421
Author: Oriol Brufau <obrufau@igalia.com>
Date: Fri Aug 17 12:59:24 2018

[css-logical] Allow flow-relative border colors in :visited rules

They should be allowed like the physical border colors.

Spec: https://drafts.csswg.org/css-logical/#border-color
Spec: https://drafts.csswg.org/selectors/#visited-pseudo

BUG= 860313 

TEST=fast/css/css/logical-box-border-color-visited-001.html
TEST=fast/css/css/logical-box-border-color-visited-002.html
TEST=fast/css/css/logical-box-border-color-visited-003.html

Change-Id: I20967bf4b00716e5c4ec2bac2e3781c81cdaa688
Reviewed-on: https://chromium-review.googlesource.com/1178043
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584036}
[add] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-001-expected.html
[add] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-001.html
[add] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-002-expected.html
[add] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-002.html
[add] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-003-expected.html
[add] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/WebKit/LayoutTests/fast/css/logical-box-border-color-visited-link-003.html
[modify] https://crrev.com/29ec679efb5502f04e8eb06c6caa76c8de24b421/third_party/blink/renderer/core/css/CSSProperties.json5

Status: Fixed (was: Started)

Sign in to add a comment