New issue
Advanced search Search tips

Issue 860310 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Fix hang in Tast ARC tests when waiting for sys.boot_completed

Project Member Reported by derat@chromium.org, Jul 4

Issue description

It looks like some Tast ARC tests aren't exiting when their deadlines are reached, which makes it a bit harder to debug failures (since you get a generic "Test timed out" error instead of descriptions of what they were waiting for).

arc.Boot at http://stainless/browse/chromeos-autotest-results/213673330-chromeos-test/
2018/07/02 16:00:24 [16:00:24.016] Waiting for Android boot
2018/07/02 16:02:02 [16:02:01.800] Error at bundle.go:210: Test timed out

arc.IntentForward at http://stainless/browse/chromeos-autotest-results/213673395-chromeos-test/
2018/07/02 16:19:53 [16:19:53.110] Waiting for Android boot
2018/07/02 16:21:35 [16:21:34.926] Error at bundle.go:210: Test timed out

I suspect that the problem is in waitProp in arc/boot_phase.go, which looks like it needs to check ctx.Err() -- if I'm not misreading, right now it loops forever and only returns on success.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/39ca2ed9902de3204fb7949a15261e84e7e71a16

commit 39ca2ed9902de3204fb7949a15261e84e7e71a16
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jul 05 08:10:57 2018

tast-tests: Fix sys.boot_completed ARC test hang.

Make arc.WaitBootCompleted return an error when the context
deadline is reached while waiting for sys.boot_completed.

BUG= chromium:860310 
TEST=arc.Boot still passes

Change-Id: Ibf1a7ee4f80c6e203554026ba70720e339003ade
Reviewed-on: https://chromium-review.googlesource.com/1126335
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/39ca2ed9902de3204fb7949a15261e84e7e71a16/src/chromiumos/tast/local/arc/boot_phase.go

Status: Fixed (was: Started)

Sign in to add a comment