New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860306 link

Starred by 1 user
Status: Fixed
Owner:
█ akaba@google.com
Last visit > 30 days ago
Closed: Jul 11
Cc:
samans@chromium.org
█ fsam...@chromium.org
kylec...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857575



Sign in to add a comment

Move code for updating SurfaceReferences to Surface

Project Member Reported by samans@chromium.org, Jul 4 
We'll need to periodically ask a surface to update its references. It's nicer for this code to live in Surface or SurfaceManager as opposed to CompositorFrameSinkSupport. The part for adding a reference to the root should stay in CompositorFrameSinkSupport.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/832610e24633dc3b9079fd42408ba84fcc70f301

commit 832610e24633dc3b9079fd42408ba84fcc70f301
Author: akaba <akaba@google.com>
Date: Wed Jul 11 17:55:37 2018

Move UpdateSurfaceReferences to SurfaceManager

This CL move the surface references update from CompositorFrameSinkSupport to SurfaceManager, while keeping the root display surface reference change in CompositorFrameSinkSupport.

Bug:  860306 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I156c40d8eb3ce6c702d2797ce8981554b83c0b2a
Reviewed-on: https://chromium-review.googlesource.com/1132319
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Andre Kaba <akaba@google.com>
Cr-Commit-Position: refs/heads/master@{#574240}
[modify] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/BUILD.gn
[modify] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/frame_sinks/compositor_frame_sink_support.cc
[modify] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/frame_sinks/compositor_frame_sink_support.h
[rename] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/surfaces/referenced_surface_tracker.cc
[rename] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/surfaces/referenced_surface_tracker.h
[rename] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/surfaces/referenced_surface_tracker_unittest.cc
[modify] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/surfaces/surface.cc
[modify] https://crrev.com/832610e24633dc3b9079fd42408ba84fcc70f301/components/viz/service/surfaces/surface.h

Comment 2 by akaba@google.com, Jul 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment