New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860303 link

Starred by 1 user
Status: Fixed
Owner:
█ tigero@google.com
Last visit > 30 days ago
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Support following OWNERS file references in supersize

Project Member Reported by tigero@google.com, Jul 4 
OWNERS files can reference other OWNERS files rather than duplicating their content. 

Example:
https://cs.chromium.org/chromium/src/chrome/browser/metrics/OWNERS

We should have supersize use the body of the referenced file for Components, if the OWNERS file it is looking at has a reference and no Component.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03

commit e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03
Author: Tiger Oakes <tigero@google.com>
Date: Thu Jul 12 18:57:34 2018

Groups small symbols at the file level

Previously, symbols below min_symbol_size were all placed in an
"(Other)" file entry at the root of the tree. Now, they are placed
inside their original file entry but grouped together based on type.
This ensures byte counts are always accurate, even past the root node.
This is also the only blocker before we can remove the old UI.

Additionally made some changes to improve first-load performance by
starting tree building as soon as possible.

Bug:  860303 
Change-Id: I02daee8994d9b7b236837b78585ac8a9c3297125
Reviewed-on: https://chromium-review.googlesource.com/1135193
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574655}
[modify] https://crrev.com/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03/tools/binary_size/libsupersize/html_report.py
[modify] https://crrev.com/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03/tools/binary_size/libsupersize/template_tree_view/index.html
[add] https://crrev.com/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03/tools/binary_size/libsupersize/template_tree_view/start-worker.js
[modify] https://crrev.com/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03/tools/binary_size/libsupersize/template_tree_view/state.js
[modify] https://crrev.com/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03/tools/binary_size/libsupersize/template_tree_view/tree-ui.js
[modify] https://crrev.com/e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03/tools/binary_size/libsupersize/template_tree_view/tree-worker.js
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e09fae4913385ebf51daa44e8c1cd9286c552cb0

commit e09fae4913385ebf51daa44e8c1cd9286c552cb0
Author: Tiger Oakes <tigero@google.com>
Date: Thu Jul 19 00:53:33 2018

Follow OWNERS file references in supersize

OWNERS files can reference other OWNERS files rather than duplicating
their content. If a COMPONENT is not found in an OWNERS file, the
reference is followed to try to find a COMPONENT.

Bug:  860303 
Change-Id: Ia676156a4a3945c85409dd93f5ee9f407faa94a8
Reviewed-on: https://chromium-review.googlesource.com/1134093
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576287}
[add] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/chrome/test/data/xr/webvr_info
[add] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/chrome/test/data/xr/webxr_samples
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/Archive_Apk.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/Archive_Elf.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/Archive_OutputDirectory.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/Archive_Pak_Files.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/Console.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/Diff_Basic.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/FullDescription.golden
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden
[add] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/TEST_OWNERS
[add] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/mock_source_directory/base/OWNERS
[modify] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/mock_source_directory/out/Release/build.ninja
[add] https://crrev.com/e09fae4913385ebf51daa44e8c1cd9286c552cb0/tools/binary_size/libsupersize/testdata/mock_source_directory/third_party/container/OWNERS

Comment 3 by tigero@google.com, Jul 19

Owner: tigero@google.com
Status: Fixed (was: Untriaged)
►

Sign in to add a comment